diff mbox series

[2/2] dt-bindings: remoteproc: mediatek: Add optional memory-region to mtk, scp

Message ID 20220429211111.2214119-3-nfraprado@collabora.com (mailing list archive)
State New, archived
Headers show
Series Mediatek SCP dt-binding tweaks | expand

Commit Message

Nícolas F. R. A. Prado April 29, 2022, 9:11 p.m. UTC
The SCP co-processor can optionally be passed a reserved memory region
to use. Add this property in the dt-binding.

Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---

 Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 4 ++++
 1 file changed, 4 insertions(+)

Comments

AngeloGioacchino Del Regno May 2, 2022, 8:40 a.m. UTC | #1
Il 29/04/22 23:11, Nícolas F. R. A. Prado ha scritto:
> The SCP co-processor can optionally be passed a reserved memory region
> to use. Add this property in the dt-binding.
> 
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Rob Herring May 2, 2022, 4:04 p.m. UTC | #2
On Fri, Apr 29, 2022 at 05:11:10PM -0400, Nícolas F. R. A. Prado wrote:
> The SCP co-processor can optionally be passed a reserved memory region
> to use. Add this property in the dt-binding.
> 
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> ---
> 
>  Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> index ec9ddeb6ca2c..64a9d2c7ed0d 100644
> --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> @@ -51,6 +51,10 @@ properties:
>    interrupts:
>      maxItems: 1
>  
> +  memory-region:
> +    $ref: /schemas/types.yaml#/definitions/phandle

memory-region has a type already, so drop. What's needed is how many 
entries and what they are if more than 1.

> +    description: phandle to reserved memory region.
> +
>  required:
>    - compatible
>    - reg
> -- 
> 2.36.0
> 
>
Nícolas F. R. A. Prado May 2, 2022, 6:35 p.m. UTC | #3
On Mon, May 02, 2022 at 11:04:11AM -0500, Rob Herring wrote:
> On Fri, Apr 29, 2022 at 05:11:10PM -0400, Nícolas F. R. A. Prado wrote:
> > The SCP co-processor can optionally be passed a reserved memory region
> > to use. Add this property in the dt-binding.
> > 
> > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> > ---
> > 
> >  Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> > index ec9ddeb6ca2c..64a9d2c7ed0d 100644
> > --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> > +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> > @@ -51,6 +51,10 @@ properties:
> >    interrupts:
> >      maxItems: 1
> >  
> > +  memory-region:
> > +    $ref: /schemas/types.yaml#/definitions/phandle
> 
> memory-region has a type already, so drop. What's needed is how many 
> entries and what they are if more than 1.

Hi Rob,

OK, didn't notice this common property was already documented elsewhere. In that
case I'll also drop the description since it's only 1.

Thanks,
Nícolas

> 
> > +    description: phandle to reserved memory region.
> > +
> >  required:
> >    - compatible
> >    - reg
> > -- 
> > 2.36.0
> > 
> >
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
index ec9ddeb6ca2c..64a9d2c7ed0d 100644
--- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
@@ -51,6 +51,10 @@  properties:
   interrupts:
     maxItems: 1
 
+  memory-region:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description: phandle to reserved memory region.
+
 required:
   - compatible
   - reg