| Message ID | 20220728062749.18701-2-zhiyong.tao@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Mediatek MT6366 Regulator patch | expand |
On 28/07/2022 08:27, Zhiyong Tao wrote: > From: zhiyong tao <zhiyong.tao@mediatek.com> > > Add mt6366 regulator document As usual with Mediatek your emails fail to properly pass modern SMTP checks and you end up in spam. I reported it months ago to folks in Mediatek. No improvements since that time. I stopped checking my spam folder for Mediatek stuff and all will be ignored. I will also stop complaining about it - just ignore Mediatek. Fix your systems, instead of putting additional effort on community and on reviewers. > > Signed-off-by: zhiyong tao <zhiyong.tao@mediatk.com> > --- > .../regulator/mediatek,mt6366-regulator.yaml | 375 ++++++++++++++++++ > 1 file changed, 375 insertions(+) Subject does not match subsystem. > create mode 100755 Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.yaml > > diff --git a/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.yaml b/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.yaml > new file mode 100755 > index 000000000000..eb72c64757cf > --- /dev/null > +++ b/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.yaml > @@ -0,0 +1,375 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/regulator/mediatek,mt6366-regulator.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MT6366 Regulator from MediaTek Integrated > + > +maintainers: > + - Zhiyong Tao <zhiyong.tao@mediatek.com> > + > +description: | > + List of regulators provided by this controller. It is named > + according to its regulator type, buck_<name> and ldo_<name>. > + MT6366 regulators node should be sub node of the MT6397 MFD node. > + > +properties: > + compatible: > + const: mediatek,mt6366-regulator > + > + regulators: > + type: object > + description: List of regulators and its properties > + > + patternProperties: > + "^buck-v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$": > + type: object > + $ref: "regulator.yaml#" No need for quotes. > + unevaluatedProperties: false > + > + properties: > + regulator-name: > + pattern: "^v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$" Why do you enforce specific regulator-name? Remove. > + > + "^ldo-v(dram2|sim1|ibr|rf12|usb|camio|camd|cn18|fe28)$": > + type: object > + $ref: "regulator.yaml#" > + > + properties: > + regulator-name: > + pattern: "^v(dram2|sim1|ibr|rf12|usb|camio|camd|cn18|fe28)$" > + > + "^ldo-v(xo22|efuse|mch|vcama1|emc|a12|vcama2|mc)$": > + type: object > + $ref: "regulator.yaml#" > + > + properties: > + regulator-name: > + pattern: "^v(xo22|efuse|mch|vcama1|emc|a12|vcama2|mc)$" > + > + "^buck-(vcore)-sshub$": > + type: object > + $ref: "regulator.yaml#" > + unevaluatedProperties: false > + > + properties: > + regulator-name: > + pattern: "^vcore-sshub$" > + > + "^ldo-vcn(28|33)-bt$": > + type: object > + $ref: "regulator.yaml#" > + unevaluatedProperties: false > + > + properties: > + regulator-name: > + pattern: "^vcn(28|33)-bt$" > + > + "^ldo-vcn(33)-wifi$": > + type: object > + $ref: "regulator.yaml#" > + unevaluatedProperties: false > + > + properties: > + regulator-name: > + pattern: "^vcn33-wifi$" > + > + "^ldo-vsram-(others)-sshub$": > + type: object > + $ref: "regulator.yaml#" > + unevaluatedProperties: false > + > + properties: > + regulator-name: > + pattern: "^vsram-others-sshub$" > + > + "^ldo-vsram-(proc11|others|gpu|proc12)$": > + type: object > + $ref: "regulator.yaml#" > + unevaluatedProperties: false > + > + properties: > + regulator-name: > + pattern: "^vsram-(proc11|others|gpu|proc12)$" > + > + "^ldo-v(aud|bif|io|ldo)28$": > + type: object > + $ref: "regulator.yaml#" > + > + properties: > + regulator-name: > + pattern: "^v(aud|bif|io|ldo)28$" > + > + "^ldo-v(io|aux|rf)18$": > + type: object > + $ref: "regulator.yaml#" > + > + properties: > + regulator-name: > + pattern: "^v(io|aux|rf)18$" > + > + "^ldo-vsim[2]$": > + type: object > + $ref: "regulator.yaml#" > + > + properties: > + regulator-name: > + pattern: "^vsim2$" > + > + required: > + - regulator-name > + > +required: > + - compatible > + - regulators > + > +additionalProperties: false > + > +examples: > + - | > + pmic { > + compatible = "mediatek,mt6366-regulator"; > + > + regulators { > + mt6366_vdram1_reg: buck-vdram1 { > + regulator-name = "vdram1"; Messed up indentation. Use only one, so 4 space for DTS example. Best regards, Krzysztof
On Thu, Jul 28, 2022 at 02:27:49PM +0800, Zhiyong Tao wrote: > + properties: > + regulator-name: > + pattern: "^v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$" regulator-name should be free form text for the system integrator to describe the use of the supply on their board, no constraints should be placed on it by the regulator.
On Thu, 2022-07-28 at 12:07 +0100, Mark Brown wrote: > On Thu, Jul 28, 2022 at 02:27:49PM +0800, Zhiyong Tao wrote: > > > + properties: > > + regulator-name: > > + pattern: > > "^v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$" > > regulator-name should be free form text for the system integrator to > describe the use of the supply on their board, no constraints should > be > placed on it by the regulator. Hi Mark, we put regulator-name here, we describe it by mt6366 datasheet. we think that it is the common attribute. So we place it here. Thanks.
On Mon, Aug 01, 2022 at 11:23:03AM +0800, zhiyong.tao wrote: > On Thu, 2022-07-28 at 12:07 +0100, Mark Brown wrote: > > On Thu, Jul 28, 2022 at 02:27:49PM +0800, Zhiyong Tao wrote: > > > + properties: > > > + regulator-name: > > > + pattern: > > > "^v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$" > > regulator-name should be free form text for the system integrator to > > describe the use of the supply on their board, no constraints should > > be > > placed on it by the regulator. > we put regulator-name here, we describe it by mt6366 datasheet. > we think that it is the common attribute. > So we place it here. No, for the reasons above.
On Thu, 2022-07-28 at 18:46 +0800, Krzysztof Kozlowski wrote: > On 28/07/2022 08:27, Zhiyong Tao wrote: > > From: zhiyong tao <zhiyong.tao@mediatek.com> > > > > Add mt6366 regulator document > > As usual with Mediatek your emails fail to properly pass modern SMTP > checks and you end up in spam. > > I reported it months ago to folks in Mediatek. No improvements since > that time. > > I stopped checking my spam folder for Mediatek stuff and all will be > ignored. I will also stop complaining about it - just ignore > Mediatek. > > Fix your systems, instead of putting additional effort on community > and > on reviewers. > Hello Krzysztof, I am Rex from MediaTek chrome project team. We noticed your complain of our upstream mail. First of all, sorry for the inconvenience. We really want to fix this SPAM issue. From our side, we can make sure mails for kernel upstream from MediaTek is clear and these mails pass the verification of DMARC/DKIM/SPF. Therefore, to identify the root cause, could you please provide us some mails that seen as SPAM from MediaTek? It's more useful if you can use the form of attachment. In that case, we can analyze whole mails including mail headers. We really appreciate your big support, and we hope we can fix this issue to reduce the inconvenience for reviewing series from MediaTek. If you can spare some time to help us for this, it would very helpful!! Our IT also adjust the DKIM setting today. If the situation of this issue it much better, please also let us know. Many thanks!! BRs, Rex > > > > > Signed-off-by: zhiyong tao <zhiyong.tao@mediatk.com> > > --- > > .../regulator/mediatek,mt6366-regulator.yaml | 375 > > ++++++++++++++++++ > > 1 file changed, 375 insertions(+) > > Subject does not match subsystem. > > > > create mode 100755 > > Documentation/devicetree/bindings/regulator/mediatek,mt6366- > > regulator.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/regulator/mediatek,mt6366- > > regulator.yaml > > b/Documentation/devicetree/bindings/regulator/mediatek,mt6366- > > regulator.yaml > > new file mode 100755 > > index 000000000000..eb72c64757cf > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/regulator/mediatek,mt6366- > > regulator.yaml > > @@ -0,0 +1,375 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: > > https://urldefense.com/v3/__http://devicetree.org/schemas/regulator/mediatek,mt6366-regulator.yaml*__;Iw!!CTRNKA9wMg0ARbw!3B-3NHQAsJc6ov022NnUIctYLEyx-BfxG5s85TBBvEfGjc4DdYDIqG_Ka_5D7scVo8CRtzLqokEX_thhM7XK_S90wg$ > > +$schema: > > https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!3B-3NHQAsJc6ov022NnUIctYLEyx-BfxG5s85TBBvEfGjc4DdYDIqG_Ka_5D7scVo8CRtzLqokEX_thhM7Un6TPZdw$ > > + > > +title: MT6366 Regulator from MediaTek Integrated > > + > > +maintainers: > > + - Zhiyong Tao <zhiyong.tao@mediatek.com> > > + > > +description: | > > + List of regulators provided by this controller. It is named > > + according to its regulator type, buck_<name> and ldo_<name>. > > + MT6366 regulators node should be sub node of the MT6397 MFD > > node. > > + > > +properties: > > + compatible: > > + const: mediatek,mt6366-regulator > > + > > + regulators: > > + type: object > > + description: List of regulators and its properties > > + > > + patternProperties: > > + "^buck- > > v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$": > > + type: object > > + $ref: "regulator.yaml#" > > No need for quotes. > > > + unevaluatedProperties: false > > + > > + properties: > > + regulator-name: > > + pattern: > > "^v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$" > > Why do you enforce specific regulator-name? Remove. > > > + > > + "^ldo-v(dram2|sim1|ibr|rf12|usb|camio|camd|cn18|fe28)$": > > + type: object > > + $ref: "regulator.yaml#" > > + > > + properties: > > + regulator-name: > > + pattern: > > "^v(dram2|sim1|ibr|rf12|usb|camio|camd|cn18|fe28)$" > > + > > + "^ldo-v(xo22|efuse|mch|vcama1|emc|a12|vcama2|mc)$": > > + type: object > > + $ref: "regulator.yaml#" > > + > > + properties: > > + regulator-name: > > + pattern: > > "^v(xo22|efuse|mch|vcama1|emc|a12|vcama2|mc)$" > > + > > + "^buck-(vcore)-sshub$": > > + type: object > > + $ref: "regulator.yaml#" > > + unevaluatedProperties: false > > + > > + properties: > > + regulator-name: > > + pattern: "^vcore-sshub$" > > + > > + "^ldo-vcn(28|33)-bt$": > > + type: object > > + $ref: "regulator.yaml#" > > + unevaluatedProperties: false > > + > > + properties: > > + regulator-name: > > + pattern: "^vcn(28|33)-bt$" > > + > > + "^ldo-vcn(33)-wifi$": > > + type: object > > + $ref: "regulator.yaml#" > > + unevaluatedProperties: false > > + > > + properties: > > + regulator-name: > > + pattern: "^vcn33-wifi$" > > + > > + "^ldo-vsram-(others)-sshub$": > > + type: object > > + $ref: "regulator.yaml#" > > + unevaluatedProperties: false > > + > > + properties: > > + regulator-name: > > + pattern: "^vsram-others-sshub$" > > + > > + "^ldo-vsram-(proc11|others|gpu|proc12)$": > > + type: object > > + $ref: "regulator.yaml#" > > + unevaluatedProperties: false > > + > > + properties: > > + regulator-name: > > + pattern: "^vsram-(proc11|others|gpu|proc12)$" > > + > > + "^ldo-v(aud|bif|io|ldo)28$": > > + type: object > > + $ref: "regulator.yaml#" > > + > > + properties: > > + regulator-name: > > + pattern: "^v(aud|bif|io|ldo)28$" > > + > > + "^ldo-v(io|aux|rf)18$": > > + type: object > > + $ref: "regulator.yaml#" > > + > > + properties: > > + regulator-name: > > + pattern: "^v(io|aux|rf)18$" > > + > > + "^ldo-vsim[2]$": > > + type: object > > + $ref: "regulator.yaml#" > > + > > + properties: > > + regulator-name: > > + pattern: "^vsim2$" > > + > > + required: > > + - regulator-name > > + > > +required: > > + - compatible > > + - regulators > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + pmic { > > + compatible = "mediatek,mt6366-regulator"; > > + > > + regulators { > > + mt6366_vdram1_reg: buck-vdram1 { > > + regulator-name = "vdram1"; > > Messed up indentation. Use only one, so 4 space for DTS example. > > > > Best regards, > Krzysztof
(Dropping individuals from CC list) On Wed, Aug 3, 2022 at 6:14 PM Rex-BC Chen <rex-bc.chen@mediatek.com> wrote: > > On Thu, 2022-07-28 at 18:46 +0800, Krzysztof Kozlowski wrote: > > On 28/07/2022 08:27, Zhiyong Tao wrote: > > > From: zhiyong tao <zhiyong.tao@mediatek.com> > > > > > > Add mt6366 regulator document > > > > As usual with Mediatek your emails fail to properly pass modern SMTP > > checks and you end up in spam. > > > > I reported it months ago to folks in Mediatek. No improvements since > > that time. > > > > I stopped checking my spam folder for Mediatek stuff and all will be > > ignored. I will also stop complaining about it - just ignore > > Mediatek. > > > > Fix your systems, instead of putting additional effort on community > > and > > on reviewers. > > > > Hello Krzysztof, > > I am Rex from MediaTek chrome project team. > We noticed your complain of our upstream mail. > > First of all, sorry for the inconvenience. > We really want to fix this SPAM issue. > > From our side, we can make sure mails for kernel upstream from MediaTek > is clear and these mails pass the verification of DMARC/DKIM/SPF. > Therefore, to identify the root cause, could you please provide us some > mails that seen as SPAM from MediaTek? > It's more useful if you can use the form of attachment. In that case, > we can analyze whole mails including mail headers. > > We really appreciate your big support, and we hope we can fix this > issue to reduce the inconvenience for reviewing series from MediaTek. > If you can spare some time to help us for this, it would very helpful!! > > Our IT also adjust the DKIM setting today. If the situation of this > issue it much better, please also let us know. Tinghan's patch series [1] that was just sent out doesn't have DKIM headers. As far as I know, people complaining about patches ending up in the spam folder are mostly using Gmail. Gmail has gotten more strict about validating emails. AFAIK it now requires either SPF or DKIM to pass, _and_ that the passing result matches the sender domain. That means SPF is out of the question for mailing lists. DKIM should work if set up, but LAKML (and lists.infradead.org in general) mangles the headers sometimes and would cause the signature check to fail. Other mailing lists on vger.kernel.org or lists.linux.dev should fare better. One can also "train" their Gmail instance to not land all of the emails that fail validation in SPAM, but nevertheless some will end up there. Attaching the full headers of [1] at the end. Regards ChenYu [1] https://lore.kernel.org/linux-mediatek/20220804021553.14867-7-tinghan.shen@mediatek.com/ Received: by 2002:a59:c181:0:b0:2d5:960c:5e50 with SMTP id j1csp54837vqn; Wed, 3 Aug 2022 19:17:48 -0700 (PDT) X-Google-Smtp-Source: AGRyM1v5wlZ5UC+3Erd1R5AK8/4DKV9Dau0nK7xGWTXVGJhzseKMqEiK+ciebo9j7IKTo5raKO8P X-Received: by 2002:a05:6830:43a0:b0:61c:c25b:eb88 with SMTP id s32-20020a05683043a000b0061cc25beb88mr10429847otv.111.1659579468530; Wed, 03 Aug 2022 19:17:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659579468; cv=none; d=google.com; s=arc-20160816; b=0/a7sbxQvavDE6ZcJZ5sodj5S88yzB6m0VHx66EMPPfwV2MZTwi4nvoD/xkLEEezuZ +nkZvPXPHrB8XojB4+eCtw4zCCBzWhOO8yBqyQkUeVRu2EgguOCbKLouCw5rCHoEC9WJ 3MtKbCIwV+TwRLfFze8lj8GKabDXhWAAnpfbB35kFevk+y8CsBIueXgFa+Lxbb/fPtyN ftu1maP4uUViYBHWx8w42KUAsSl2SQcuxJpwSaiK7dSFOt/IOIibpS/ruHCKy+YHPO95 46Ecd0OZ1CGN+rZZS+FzfUi+8VbwYWZ7dKKFuppL93ErlozBuq4Nz2LT++CQarlHOpJ/ MNbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature:dmarc-filter:delivered-to; bh=YugCKNbHuwbwo35Olh6mecj/5LgXHYwXhRiDSNx4g8I=; b=zxhhj5x9+HVTuqp6J76Uc0445tI6tASmU5alucBY762bYJrJQPjH5GHNGpPT241D6e yjFGRoAaMut74akROiHQMlhUEc1OYQSEcVCizruQgaRZupCAuzaWSJaTq2BLXicW9TFs oGzOA6k54Mh18yoiOr/A6MKh+4DG8M2QKi6SIhcOJY5eBmpgO+M+JixJKXnYMqZX9Y9f j8O4OW2evTjCtBpJ/pYEeKxZpWoAC+5WSnUhVuolhP4ZGjrUHFl4WTtMGwVEIdp2jCDb SI2nWrAagOc08AKfBfkoHDlmwgSz3FTg3C9ldzn/SXFh1ovNFmXN8FPecTd+1SQmp3US fRiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20210309 header.b="0rFqA//U"; spf=pass (google.com: domain of srs0=w7s4=yi=lists.infradead.org=linux-arm-kernel-bounces+wens=kernel.org@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=w7S4=YI=lists.infradead.org=linux-arm-kernel-bounces+wens=kernel.org@kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=QUARANTINE) header.from=mediatek.com Return-Path: <SRS0=w7S4=YI=lists.infradead.org=linux-arm-kernel-bounces+wens=kernel.org@kernel.org> Received: from dfw.source.kernel.org (dfw.source.kernel.org. [139.178.84.217]) by mx.google.com with ESMTPS id t130-20020aca5f88000000b00339fe268670si12938186oib.220.2022.08.03.19.17.48 for <wens213@gmail.com> (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Aug 2022 19:17:48 -0700 (PDT) Received-SPF: pass (google.com: domain of srs0=w7s4=yi=lists.infradead.org=linux-arm-kernel-bounces+wens=kernel.org@kernel.org designates 139.178.84.217 as permitted sender) client-ip=139.178.84.217; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20210309 header.b="0rFqA//U"; spf=pass (google.com: domain of srs0=w7s4=yi=lists.infradead.org=linux-arm-kernel-bounces+wens=kernel.org@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=w7S4=YI=lists.infradead.org=linux-arm-kernel-bounces+wens=kernel.org@kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=QUARANTINE) header.from=mediatek.com Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 466CF61780 for <wens213@gmail.com>; Thu, 4 Aug 2022 02:17:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id BBAB0C433C1; Thu, 4 Aug 2022 02:17:47 +0000 (UTC) Delivered-To: wens@kernel.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id DD5F5C433D6 for <wens@kernel.org>; Thu, 4 Aug 2022 02:17:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org DD5F5C433D6 Authentication-Results: smtp.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=mediatek.com Authentication-Results: smtp.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YugCKNbHuwbwo35Olh6mecj/5LgXHYwXhRiDSNx4g8I=; b=0rFqA//UuS3weT eLvNzNB84/VT+8I87477CB14y0czmuPtKWmPxtP4p2TMcwTTk5AMwCmSgANdQ5RGz1eKBdxUR34Rb IRRq0Aaeu8AAab139KLaLqXRIDzWDNAAa1GK9bbVRwPXTX0Ine+Yp6tubhWVv5VR+0c6yoqdOgpIq UeznQpECXWMFv//X3y05jkNdsVZdrZO5ULjhZICKofEpjJWr1oo0Y/9AnL3EgFMT9AZ7jTgHQxRLl nywXZwXjFwiM9cVfPlBihpB4T6bKpQyIPNkeb9CSv5m3FCD59FYkUr41gOcp9Z5yBpl705R5po0VR yqI2dE35ZUbhTCjbEfTA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJQQ7-00DuEr-7h; Thu, 04 Aug 2022 02:17:07 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJQQ2-00Du8m-FY; Thu, 04 Aug 2022 02:17:04 +0000 X-UUID: 2fa656eda2a04d1ab7b69f85d53c4374-20220803 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.8,REQID:1d01f002-57e8-4399-98db-37702f2bfdb3,OB:0,LO B:0,IP:0,URL:25,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACT ION:release,TS:25 X-CID-META: VersionHash:0f94e32,CLOUDID:644b2cd1-841b-4e95-ad42-8f86e18f54fc,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:1,File:nil ,QS:nil,BEC:nil,COL:0 X-UUID: 2fa656eda2a04d1ab7b69f85d53c4374-20220803 Received: from mtkmbs11n2.mediatek.inc [(172.21.101.187)] by mailgw01.mediatek.com (envelope-from <tinghan.shen@mediatek.com>) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 263722393; Wed, 03 Aug 2022 19:16:59 -0700 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Thu, 4 Aug 2022 10:15:56 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 4 Aug 2022 10:15:55 +0800 From: Tinghan Shen <tinghan.shen@mediatek.com> To: Yong Wu <yong.wu@mediatek.com>, Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Lee Jones <lee@kernel.org>, Matthias Brugger <matthias.bgg@gmail.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, Tinghan Shen <tinghan.shen@mediatek.com>, MandyJH Liu <mandyjh.liu@mediatek.com> CC: <iommu@lists.linux.dev>, <linux-mediatek@lists.infradead.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <Project_Global_Chrome_Upstream_Group@mediatek.com> Subject: [PATCH v5 06/20] dt-bindings: power: mediatek: Add bindings for MediaTek SCPSYS Date: Thu, 4 Aug 2022 10:15:39 +0800 Message-ID: <20220804021553.14867-7-tinghan.shen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20220804021553.14867-1-tinghan.shen@mediatek.com> References: <20220804021553.14867-1-tinghan.shen@mediatek.com> MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220803_191702_550657_36D1E4D2 X-CRM114-Status: GOOD ( 15.13 ) X-Spam-Score: -0.0 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The System Control Processor System (SCPSYS) has several power management related tasks in the system. Add the bindings for it. Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com> Reviewed-by: Rob Herring <robh@kernel.org> --- .../bindings/mfd/mediatek,mt8195-scpsys.yaml | 67 +++++++++++++++++++ .../power/mediatek,power-co [...] Content analysis details: (-0.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: linux-arm-kernel <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+wens=kernel.org@lists.infradead.org > Many thanks!! > > BRs, > Rex > > > > > > > > Signed-off-by: zhiyong tao <zhiyong.tao@mediatk.com> > > > --- > > > .../regulator/mediatek,mt6366-regulator.yaml | 375 > > > ++++++++++++++++++ > > > 1 file changed, 375 insertions(+) > > > > Subject does not match subsystem. > > > > > > > create mode 100755 > > > Documentation/devicetree/bindings/regulator/mediatek,mt6366- > > > regulator.yaml > > > > > > diff --git > > > a/Documentation/devicetree/bindings/regulator/mediatek,mt6366- > > > regulator.yaml > > > b/Documentation/devicetree/bindings/regulator/mediatek,mt6366- > > > regulator.yaml > > > new file mode 100755 > > > index 000000000000..eb72c64757cf > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/regulator/mediatek,mt6366- > > > regulator.yaml > > > @@ -0,0 +1,375 @@ > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: > > > https://urldefense.com/v3/__http://devicetree.org/schemas/regulator/mediatek,mt6366-regulator.yaml*__;Iw!!CTRNKA9wMg0ARbw!3B-3NHQAsJc6ov022NnUIctYLEyx-BfxG5s85TBBvEfGjc4DdYDIqG_Ka_5D7scVo8CRtzLqokEX_thhM7XK_S90wg$ > > > +$schema: > > > https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!3B-3NHQAsJc6ov022NnUIctYLEyx-BfxG5s85TBBvEfGjc4DdYDIqG_Ka_5D7scVo8CRtzLqokEX_thhM7Un6TPZdw$ > > > + > > > +title: MT6366 Regulator from MediaTek Integrated > > > + > > > +maintainers: > > > + - Zhiyong Tao <zhiyong.tao@mediatek.com> > > > + > > > +description: | > > > + List of regulators provided by this controller. It is named > > > + according to its regulator type, buck_<name> and ldo_<name>. > > > + MT6366 regulators node should be sub node of the MT6397 MFD > > > node. > > > + > > > +properties: > > > + compatible: > > > + const: mediatek,mt6366-regulator > > > + > > > + regulators: > > > + type: object > > > + description: List of regulators and its properties > > > + > > > + patternProperties: > > > + "^buck- > > > v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$": > > > + type: object > > > + $ref: "regulator.yaml#" > > > > No need for quotes. > > > > > + unevaluatedProperties: false > > > + > > > + properties: > > > + regulator-name: > > > + pattern: > > > "^v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$" > > > > Why do you enforce specific regulator-name? Remove. > > > > > + > > > + "^ldo-v(dram2|sim1|ibr|rf12|usb|camio|camd|cn18|fe28)$": > > > + type: object > > > + $ref: "regulator.yaml#" > > > + > > > + properties: > > > + regulator-name: > > > + pattern: > > > "^v(dram2|sim1|ibr|rf12|usb|camio|camd|cn18|fe28)$" > > > + > > > + "^ldo-v(xo22|efuse|mch|vcama1|emc|a12|vcama2|mc)$": > > > + type: object > > > + $ref: "regulator.yaml#" > > > + > > > + properties: > > > + regulator-name: > > > + pattern: > > > "^v(xo22|efuse|mch|vcama1|emc|a12|vcama2|mc)$" > > > + > > > + "^buck-(vcore)-sshub$": > > > + type: object > > > + $ref: "regulator.yaml#" > > > + unevaluatedProperties: false > > > + > > > + properties: > > > + regulator-name: > > > + pattern: "^vcore-sshub$" > > > + > > > + "^ldo-vcn(28|33)-bt$": > > > + type: object > > > + $ref: "regulator.yaml#" > > > + unevaluatedProperties: false > > > + > > > + properties: > > > + regulator-name: > > > + pattern: "^vcn(28|33)-bt$" > > > + > > > + "^ldo-vcn(33)-wifi$": > > > + type: object > > > + $ref: "regulator.yaml#" > > > + unevaluatedProperties: false > > > + > > > + properties: > > > + regulator-name: > > > + pattern: "^vcn33-wifi$" > > > + > > > + "^ldo-vsram-(others)-sshub$": > > > + type: object > > > + $ref: "regulator.yaml#" > > > + unevaluatedProperties: false > > > + > > > + properties: > > > + regulator-name: > > > + pattern: "^vsram-others-sshub$" > > > + > > > + "^ldo-vsram-(proc11|others|gpu|proc12)$": > > > + type: object > > > + $ref: "regulator.yaml#" > > > + unevaluatedProperties: false > > > + > > > + properties: > > > + regulator-name: > > > + pattern: "^vsram-(proc11|others|gpu|proc12)$" > > > + > > > + "^ldo-v(aud|bif|io|ldo)28$": > > > + type: object > > > + $ref: "regulator.yaml#" > > > + > > > + properties: > > > + regulator-name: > > > + pattern: "^v(aud|bif|io|ldo)28$" > > > + > > > + "^ldo-v(io|aux|rf)18$": > > > + type: object > > > + $ref: "regulator.yaml#" > > > + > > > + properties: > > > + regulator-name: > > > + pattern: "^v(io|aux|rf)18$" > > > + > > > + "^ldo-vsim[2]$": > > > + type: object > > > + $ref: "regulator.yaml#" > > > + > > > + properties: > > > + regulator-name: > > > + pattern: "^vsim2$" > > > + > > > + required: > > > + - regulator-name > > > + > > > +required: > > > + - compatible > > > + - regulators > > > + > > > +additionalProperties: false > > > + > > > +examples: > > > + - | > > > + pmic { > > > + compatible = "mediatek,mt6366-regulator"; > > > + > > > + regulators { > > > + mt6366_vdram1_reg: buck-vdram1 { > > > + regulator-name = "vdram1"; > > > > Messed up indentation. Use only one, so 4 space for DTS example. > > > > > > > > Best regards, > > Krzysztof > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On 03/08/2022 11:50, Rex-BC Chen wrote: > On Thu, 2022-07-28 at 18:46 +0800, Krzysztof Kozlowski wrote: >> On 28/07/2022 08:27, Zhiyong Tao wrote: >>> From: zhiyong tao <zhiyong.tao@mediatek.com> >>> >>> Add mt6366 regulator document >> >> As usual with Mediatek your emails fail to properly pass modern SMTP >> checks and you end up in spam. >> >> I reported it months ago to folks in Mediatek. No improvements since >> that time. >> >> I stopped checking my spam folder for Mediatek stuff and all will be >> ignored. I will also stop complaining about it - just ignore >> Mediatek. >> >> Fix your systems, instead of putting additional effort on community >> and >> on reviewers. >> > > Hello Krzysztof, > > I am Rex from MediaTek chrome project team. > We noticed your complain of our upstream mail. > > First of all, sorry for the inconvenience. > We really want to fix this SPAM issue. > > From our side, we can make sure mails for kernel upstream from MediaTek > is clear and these mails pass the verification of DMARC/DKIM/SPF. > Therefore, to identify the root cause, could you please provide us some > mails that seen as SPAM from MediaTek? > It's more useful if you can use the form of attachment. In that case, > we can analyze whole mails including mail headers. > > We really appreciate your big support, and we hope we can fix this > issue to reduce the inconvenience for reviewing series from MediaTek. > If you can spare some time to help us for this, it would very helpful!! > > Our IT also adjust the DKIM setting today. If the situation of this > issue it much better, please also let us know. > Hi, Since few days there were no @mediatek.com emails in my spam folder, either because nothing was sent to me, or they passed spam filters. If this is the result of some changes, then it seems working. Thank you. I'll let you now when I find something new in the spam. Best regards, Krzysztof
On Thu, 2022-07-28 at 12:46 +0200, Krzysztof Kozlowski wrote: > On 28/07/2022 08:27, Zhiyong Tao wrote: > > From: zhiyong tao <zhiyong.tao@mediatek.com> > > > > Add mt6366 regulator document > > As usual with Mediatek your emails fail to properly pass modern SMTP > checks and you end up in spam. > > I reported it months ago to folks in Mediatek. No improvements since > that time. > > I stopped checking my spam folder for Mediatek stuff and all will be > ignored. I will also stop complaining about it - just ignore > Mediatek. > > Fix your systems, instead of putting additional effort on community > and > on reviewers. > > > > > > Signed-off-by: zhiyong tao <zhiyong.tao@mediatk.com> > > --- > > .../regulator/mediatek,mt6366-regulator.yaml | 375 > > ++++++++++++++++++ > > 1 file changed, 375 insertions(+) > > Subject does not match subsystem. Hi Krzysztof, Do you mean that we should change the title like this: regulator: dt-bindings: mediatek: add mt6366 regulator document is it right? > > > > create mode 100755 > > Documentation/devicetree/bindings/regulator/mediatek,mt6366- > > regulator.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/regulator/mediatek,mt6366- > > regulator.yaml > > b/Documentation/devicetree/bindings/regulator/mediatek,mt6366- > > regulator.yaml > > new file mode 100755 > > index 000000000000..eb72c64757cf > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/regulator/mediatek,mt6366- > > regulator.yaml > > @@ -0,0 +1,375 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: > > https://urldefense.com/v3/__http://devicetree.org/schemas/regulator/mediatek,mt6366-regulator.yaml*__;Iw!!CTRNKA9wMg0ARbw!ziK5XN37dRWX7n6kijp_JwH57ILy3rqwOZZmvARTQ2MuIKSEZOW_ERZ5io2IBghFlHQ$ > > > > +$schema: > > https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!ziK5XN37dRWX7n6kijp_JwH57ILy3rqwOZZmvARTQ2MuIKSEZOW_ERZ5io2IAO1d7DQ$ > > > > + > > +title: MT6366 Regulator from MediaTek Integrated > > + > > +maintainers: > > + - Zhiyong Tao <zhiyong.tao@mediatek.com> > > + > > +description: | > > + List of regulators provided by this controller. It is named > > + according to its regulator type, buck_<name> and ldo_<name>. > > + MT6366 regulators node should be sub node of the MT6397 MFD > > node. > > + > > +properties: > > + compatible: > > + const: mediatek,mt6366-regulator > > + > > + regulators: > > + type: object > > + description: List of regulators and its properties > > + > > + patternProperties: > > + "^buck- > > v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$": > > + type: object > > + $ref: "regulator.yaml#" > > No need for quotes. ==> We will remove the line "$ref: "regulator.yaml#"" in next verison, is it right? > > > + unevaluatedProperties: false > > + > > + properties: > > + regulator-name: > > + pattern: > > "^v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$" > > Why do you enforce specific regulator-name? Remove. ==> we will remove the regulator-name in next version. > > > + > > + "^ldo-v(dram2|sim1|ibr|rf12|usb|camio|camd|cn18|fe28)$": > > + type: object > > + $ref: "regulator.yaml#" > > + > > + properties: > > + regulator-name: > > + pattern: > > "^v(dram2|sim1|ibr|rf12|usb|camio|camd|cn18|fe28)$" > > + > > + "^ldo-v(xo22|efuse|mch|vcama1|emc|a12|vcama2|mc)$": > > + type: object > > + $ref: "regulator.yaml#" > > + > > + properties: > > + regulator-name: > > + pattern: > > "^v(xo22|efuse|mch|vcama1|emc|a12|vcama2|mc)$" > > + > > + "^buck-(vcore)-sshub$": > > + type: object > > + $ref: "regulator.yaml#" > > + unevaluatedProperties: false > > + > > + properties: > > + regulator-name: > > + pattern: "^vcore-sshub$" > > + > > + "^ldo-vcn(28|33)-bt$": > > + type: object > > + $ref: "regulator.yaml#" > > + unevaluatedProperties: false > > + > > + properties: > > + regulator-name: > > + pattern: "^vcn(28|33)-bt$" > > + > > + "^ldo-vcn(33)-wifi$": > > + type: object > > + $ref: "regulator.yaml#" > > + unevaluatedProperties: false > > + > > + properties: > > + regulator-name: > > + pattern: "^vcn33-wifi$" > > + > > + "^ldo-vsram-(others)-sshub$": > > + type: object > > + $ref: "regulator.yaml#" > > + unevaluatedProperties: false > > + > > + properties: > > + regulator-name: > > + pattern: "^vsram-others-sshub$" > > + > > + "^ldo-vsram-(proc11|others|gpu|proc12)$": > > + type: object > > + $ref: "regulator.yaml#" > > + unevaluatedProperties: false > > + > > + properties: > > + regulator-name: > > + pattern: "^vsram-(proc11|others|gpu|proc12)$" > > + > > + "^ldo-v(aud|bif|io|ldo)28$": > > + type: object > > + $ref: "regulator.yaml#" > > + > > + properties: > > + regulator-name: > > + pattern: "^v(aud|bif|io|ldo)28$" > > + > > + "^ldo-v(io|aux|rf)18$": > > + type: object > > + $ref: "regulator.yaml#" > > + > > + properties: > > + regulator-name: > > + pattern: "^v(io|aux|rf)18$" > > + > > + "^ldo-vsim[2]$": > > + type: object > > + $ref: "regulator.yaml#" > > + > > + properties: > > + regulator-name: > > + pattern: "^vsim2$" > > + > > + required: > > + - regulator-name > > + > > +required: > > + - compatible > > + - regulators > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + pmic { > > + compatible = "mediatek,mt6366-regulator"; > > + > > + regulators { > > + mt6366_vdram1_reg: buck-vdram1 { > > + regulator-name = "vdram1"; > > Messed up indentation. Use only one, so 4 space for DTS example. ==> we will fix it by 4 space for DTS example in next version. Thanks. > > > > Best regards, > Krzysztof
On 11/08/2022 11:42, zhiyong.tao wrote: >> >>> >>> Signed-off-by: zhiyong tao <zhiyong.tao@mediatk.com> >>> --- >>> .../regulator/mediatek,mt6366-regulator.yaml | 375 >>> ++++++++++++++++++ >>> 1 file changed, 375 insertions(+) >> >> Subject does not match subsystem. > > Hi Krzysztof, > > Do you mean that we should change the title like this: > regulator: dt-bindings: mediatek: add mt6366 regulator document > is it right? Yes. And remove redundant pieces so for example: regulator: dt-bindings: mediatek: add mt6366 or: regulator: dt-bindings: add mediatek,mt6366 (...) >>> + patternProperties: >>> + "^buck- >>> v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$": >>> + type: object >>> + $ref: "regulator.yaml#" >> >> No need for quotes. > ==> > We will remove the line "$ref: "regulator.yaml#"" in next verison, is > it right? No, it is not. Why do you want to remove it? Best regards, Krzysztof
On Thu, 2022-08-11 at 11:58 +0300, Krzysztof Kozlowski wrote: > On 11/08/2022 11:42, zhiyong.tao wrote: > > > > > > > > > > > Signed-off-by: zhiyong tao <zhiyong.tao@mediatk.com> > > > > --- > > > > .../regulator/mediatek,mt6366-regulator.yaml | 375 > > > > ++++++++++++++++++ > > > > 1 file changed, 375 insertions(+) > > > > > > Subject does not match subsystem. > > > > Hi Krzysztof, > > > > Do you mean that we should change the title like this: > > regulator: dt-bindings: mediatek: add mt6366 regulator document > > is it right? > > Yes. And remove redundant pieces so for example: > > regulator: dt-bindings: mediatek: add mt6366 > or: > regulator: dt-bindings: add mediatek,mt6366 ==> Thanks for your suggestion, we will fix it in next verison. > > > (...) > > > > > + patternProperties: > > > > + "^buck- > > > > v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$": > > > > + type: object > > > > + $ref: "regulator.yaml#" > > > > > > No need for quotes. > > > > ==> > > We will remove the line "$ref: "regulator.yaml#"" in next verison, > > is > > it right? > > No, it is not. Why do you want to remove it? ==> We don't understand "No need for quotes."which means. Do you mean that we should remove the quotation marks. We will change it like this:$ref: regulator.yaml# is it right? Thanks > > > Best regards, > Krzysztof
On 11/08/2022 12:14, zhiyong.tao wrote: > On Thu, 2022-08-11 at 11:58 +0300, Krzysztof Kozlowski wrote: >> On 11/08/2022 11:42, zhiyong.tao wrote: >>>> >>>>> >>>>> Signed-off-by: zhiyong tao <zhiyong.tao@mediatk.com> >>>>> --- >>>>> .../regulator/mediatek,mt6366-regulator.yaml | 375 >>>>> ++++++++++++++++++ >>>>> 1 file changed, 375 insertions(+) >>>> >>>> Subject does not match subsystem. >>> >>> Hi Krzysztof, >>> >>> Do you mean that we should change the title like this: >>> regulator: dt-bindings: mediatek: add mt6366 regulator document >>> is it right? >> >> Yes. And remove redundant pieces so for example: >> >> regulator: dt-bindings: mediatek: add mt6366 >> or: >> regulator: dt-bindings: add mediatek,mt6366 > ==> > Thanks for your suggestion, we will fix it in next verison. >> >> >> (...) >> >>>>> + patternProperties: >>>>> + "^buck- >>>>> v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$": >>>>> + type: object >>>>> + $ref: "regulator.yaml#" >>>> >>>> No need for quotes. >>> >>> ==> >>> We will remove the line "$ref: "regulator.yaml#"" in next verison, >>> is >>> it right? >> >> No, it is not. Why do you want to remove it? > ==> > We don't understand "No need for quotes."which means. > Do you mean that we should remove the quotation marks. > We will change it like this:$ref: regulator.yaml# > is it right? Yes, remove the quotation marks. You wanted to remove entire line which is not correct. $ref should stay. Best regards, Krzysztof
On Thu, 2022-08-11 at 12:15 +0300, Krzysztof Kozlowski wrote: > On 11/08/2022 12:14, zhiyong.tao wrote: > > On Thu, 2022-08-11 at 11:58 +0300, Krzysztof Kozlowski wrote: > > > On 11/08/2022 11:42, zhiyong.tao wrote: > > > > > > > > > > > > > > > > > Signed-off-by: zhiyong tao <zhiyong.tao@mediatk.com> > > > > > > --- > > > > > > .../regulator/mediatek,mt6366-regulator.yaml | 375 > > > > > > ++++++++++++++++++ > > > > > > 1 file changed, 375 insertions(+) > > > > > > > > > > Subject does not match subsystem. > > > > > > > > Hi Krzysztof, > > > > > > > > Do you mean that we should change the title like this: > > > > regulator: dt-bindings: mediatek: add mt6366 regulator document > > > > is it right? > > > > > > Yes. And remove redundant pieces so for example: > > > > > > regulator: dt-bindings: mediatek: add mt6366 > > > or: > > > regulator: dt-bindings: add mediatek,mt6366 > > > > ==> > > Thanks for your suggestion, we will fix it in next verison. > > > > > > > > > (...) > > > > > > > > > + patternProperties: > > > > > > + "^buck- > > > > > > v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$": > > > > > > + type: object > > > > > > + $ref: "regulator.yaml#" > > > > > > > > > > No need for quotes. > > > > > > > > ==> > > > > We will remove the line "$ref: "regulator.yaml#"" in next > > > > verison, > > > > is > > > > it right? > > > > > > No, it is not. Why do you want to remove it? > > > > ==> > > We don't understand "No need for quotes."which means. > > Do you mean that we should remove the quotation marks. > > We will change it like this:$ref: regulator.yaml# > > is it right? > > Yes, remove the quotation marks. You wanted to remove entire line > which > is not correct. $ref should stay. ==> Thanks for your suggestion, we will fix it in next verison. Thanks many. > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.yaml b/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.yaml new file mode 100755 index 000000000000..eb72c64757cf --- /dev/null +++ b/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.yaml @@ -0,0 +1,375 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/regulator/mediatek,mt6366-regulator.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: MT6366 Regulator from MediaTek Integrated + +maintainers: + - Zhiyong Tao <zhiyong.tao@mediatek.com> + +description: | + List of regulators provided by this controller. It is named + according to its regulator type, buck_<name> and ldo_<name>. + MT6366 regulators node should be sub node of the MT6397 MFD node. + +properties: + compatible: + const: mediatek,mt6366-regulator + + regulators: + type: object + description: List of regulators and its properties + + patternProperties: + "^buck-v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$": + type: object + $ref: "regulator.yaml#" + unevaluatedProperties: false + + properties: + regulator-name: + pattern: "^v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$" + + "^ldo-v(dram2|sim1|ibr|rf12|usb|camio|camd|cn18|fe28)$": + type: object + $ref: "regulator.yaml#" + + properties: + regulator-name: + pattern: "^v(dram2|sim1|ibr|rf12|usb|camio|camd|cn18|fe28)$" + + "^ldo-v(xo22|efuse|mch|vcama1|emc|a12|vcama2|mc)$": + type: object + $ref: "regulator.yaml#" + + properties: + regulator-name: + pattern: "^v(xo22|efuse|mch|vcama1|emc|a12|vcama2|mc)$" + + "^buck-(vcore)-sshub$": + type: object + $ref: "regulator.yaml#" + unevaluatedProperties: false + + properties: + regulator-name: + pattern: "^vcore-sshub$" + + "^ldo-vcn(28|33)-bt$": + type: object + $ref: "regulator.yaml#" + unevaluatedProperties: false + + properties: + regulator-name: + pattern: "^vcn(28|33)-bt$" + + "^ldo-vcn(33)-wifi$": + type: object + $ref: "regulator.yaml#" + unevaluatedProperties: false + + properties: + regulator-name: + pattern: "^vcn33-wifi$" + + "^ldo-vsram-(others)-sshub$": + type: object + $ref: "regulator.yaml#" + unevaluatedProperties: false + + properties: + regulator-name: + pattern: "^vsram-others-sshub$" + + "^ldo-vsram-(proc11|others|gpu|proc12)$": + type: object + $ref: "regulator.yaml#" + unevaluatedProperties: false + + properties: + regulator-name: + pattern: "^vsram-(proc11|others|gpu|proc12)$" + + "^ldo-v(aud|bif|io|ldo)28$": + type: object + $ref: "regulator.yaml#" + + properties: + regulator-name: + pattern: "^v(aud|bif|io|ldo)28$" + + "^ldo-v(io|aux|rf)18$": + type: object + $ref: "regulator.yaml#" + + properties: + regulator-name: + pattern: "^v(io|aux|rf)18$" + + "^ldo-vsim[2]$": + type: object + $ref: "regulator.yaml#" + + properties: + regulator-name: + pattern: "^vsim2$" + + required: + - regulator-name + +required: + - compatible + - regulators + +additionalProperties: false + +examples: + - | + pmic { + compatible = "mediatek,mt6366-regulator"; + + regulators { + mt6366_vdram1_reg: buck-vdram1 { + regulator-name = "vdram1"; + regulator-ramp-delay = <12500>; + regulator-enable-ramp-delay = <0>; + regulator-allowed-modes = <0 1>; + }; + + mt6366_vcore_reg: buck-vcore { + regulator-name = "vcore"; + regulator-ramp-delay = <6250>; + regulator-enable-ramp-delay = <200>; + regulator-allowed-modes = <0 1>; + }; + + mt6366_vproc11_reg: buck-vproc11 { + regulator-name = "vproc11"; + regulator-ramp-delay = <6250>; + regulator-enable-ramp-delay = <200>; + regulator-allowed-modes = <0 1>; + }; + + mt6366_vproc12_reg: buck-vproc12 { + regulator-name = "vproc12"; + regulator-ramp-delay = <6250>; + regulator-enable-ramp-delay = <200>; + regulator-allowed-modes = <0 1>; + }; + + mt6366_vgpu_reg: buck-vgpu { + regulator-name = "vgpu"; + regulator-ramp-delay = <6250>; + regulator-enable-ramp-delay = <200>; + regulator-allowed-modes = <0 1>; + }; + + mt6366_vs2_reg: buck-vs2 { + regulator-name = "vs2"; + regulator-ramp-delay = <12500>; + regulator-enable-ramp-delay = <0>; + }; + + mt6366_vmodem_reg: buck-vmodem { + regulator-name = "vmodem"; + regulator-ramp-delay = <6250>; + regulator-enable-ramp-delay = <900>; + regulator-allowed-modes = <0 1>; + }; + + mt6366_vs1_reg: buck-vs1 { + regulator-name = "vs1"; + regulator-ramp-delay = <12500>; + regulator-enable-ramp-delay = <0>; + }; + + mt6366_vdram2_reg: ldo-vdram2 { + regulator-name = "vdram2"; + regulator-enable-ramp-delay = <3300>; + }; + + mt6366_vsim1_reg: ldo-vsim1 { + regulator-name = "vsim1"; + regulator-enable-ramp-delay = <540>; + }; + + mt6366_vibr_reg: ldo-vibr { + regulator-name = "vibr"; + regulator-enable-ramp-delay = <60>; + }; + + mt6366_vrf12_reg: ldo-vrf12 { + compatible = "regulator-fixed"; + regulator-name = "vrf12"; + regulator-enable-ramp-delay = <120>; + }; + + mt6366_vio18_reg: ldo-vio18 { + compatible = "regulator-fixed"; + regulator-name = "vio18"; + regulator-enable-ramp-delay = <2700>; + }; + + mt6366_vusb_reg: ldo-vusb { + regulator-name = "vusb"; + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vcamio_reg: ldo-vcamio { + compatible = "regulator-fixed"; + regulator-name = "vcamio"; + regulator-enable-ramp-delay = <325>; + }; + + mt6366_vcamd_reg: ldo-vcamd { + regulator-name = "vcamd"; + regulator-enable-ramp-delay = <325>; + }; + + mt6366_vcn18_reg: ldo-vcn18 { + compatible = "regulator-fixed"; + regulator-name = "vcn18"; + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vfe28_reg: ldo-vfe28 { + compatible = "regulator-fixed"; + regulator-name = "vfe28"; + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vsram_proc11_reg: ldo-vsram-proc11 { + regulator-name = "vsram-proc11"; + regulator-ramp-delay = <6250>; + regulator-enable-ramp-delay = <240>; + }; + + mt6366_vcn28_reg: ldo-vcn28 { + compatible = "regulator-fixed"; + regulator-name = "vcn28"; + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vsram_others_reg: ldo-vsram-others { + regulator-name = "vsram-others"; + regulator-ramp-delay = <6250>; + regulator-enable-ramp-delay = <240>; + }; + + mt6366_vsram_gpu_reg: ldo-vsram-gpu { + regulator-name = "vsram-gpu"; + regulator-ramp-delay = <6250>; + regulator-enable-ramp-delay = <240>; + }; + + mt6366_vxo22_reg: ldo-vxo22 { + compatible = "regulator-fixed"; + regulator-name = "vxo22"; + regulator-enable-ramp-delay = <120>; + }; + + mt6366_vefuse_reg: ldo-vefuse { + regulator-name = "vefuse"; + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vaux18_reg: ldo-vaux18 { + compatible = "regulator-fixed"; + regulator-name = "vaux18"; + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vmch_reg: ldo-vmch { + regulator-name = "vmch"; + regulator-enable-ramp-delay = <60>; + }; + + mt6366_vbif28_reg: ldo-vbif28 { + compatible = "regulator-fixed"; + regulator-name = "vbif28"; + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vsram_proc12_reg: ldo-vsram-proc12 { + regulator-name = "vsram-proc12"; + regulator-ramp-delay = <6250>; + regulator-enable-ramp-delay = <240>; + }; + + mt6366_vcama1_reg: ldo-vcama1 { + regulator-name = "vcama1"; + regulator-enable-ramp-delay = <325>; + }; + + mt6366_vemc_reg: ldo-vemc { + regulator-name = "vemc"; + regulator-enable-ramp-delay = <60>; + }; + + mt6366_vio28_reg: ldo-vio28 { + compatible = "regulator-fixed"; + regulator-name = "vio28"; + regulator-enable-ramp-delay = <270>; + }; + + mt6366_va12_reg: ldo-va12 { + compatible = "regulator-fixed"; + regulator-name = "va12"; + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vrf18_reg: ldo-vrf18 { + compatible = "regulator-fixed"; + regulator-name = "vrf18"; + regulator-enable-ramp-delay = <120>; + }; + + mt6366_vcn33_bt_reg: ldo-vcn33-bt { + regulator-name = "vcn33-bt"; + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vcn33_wifi_reg: ldo-vcn33-wifi { + regulator-name = "vcn33-wifi"; + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vcama2_reg: ldo-vcama2 { + regulator-name = "vcama2"; + regulator-enable-ramp-delay = <325>; + }; + + mt6366_vmc_reg: ldo-vmc { + regulator-name = "vmc"; + regulator-enable-ramp-delay = <60>; + }; + + mt6366_vldo28_reg: ldo-vldo28 { + regulator-name = "vldo28"; + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vaud28_reg: ldo-vaud28 { + compatible = "regulator-fixed"; + regulator-name = "vaud28"; + regulator-enable-ramp-delay = <270>; + }; + + mt6366_vsim2_reg: ldo-vsim2 { + regulator-name = "vsim2"; + regulator-enable-ramp-delay = <540>; + }; + + mt6366_vcore_sshub_reg: buck-vcore-sshub { + regulator-name = "vcore-sshub"; + }; + + mt6366_vsram_others_sshub_reg: ldo-vsram-others-sshub { + regulator-name = "vsram-others-sshub"; + }; + }; + }; +...