| Message ID | 20230517230239.187727-95-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | usb: Convert to platform remove callback returning void | expand |
On Thu, May 18, 2023 at 01:02:36AM +0200, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart from > emitting a warning) and this typically results in resource leaks. To improve > here there is a quest to make the remove callback return void. In the first > step of this quest all drivers are converted to .remove_new() which already > returns void. Eventually after all drivers are converted, .remove_new() is > renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/usb/typec/tcpm/tcpci_mt6370.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/typec/tcpm/tcpci_mt6370.c b/drivers/usb/typec/tcpm/tcpci_mt6370.c > index c5bb201a5163..2a079464b398 100644 > --- a/drivers/usb/typec/tcpm/tcpci_mt6370.c > +++ b/drivers/usb/typec/tcpm/tcpci_mt6370.c > @@ -178,12 +178,10 @@ static int mt6370_tcpc_probe(struct platform_device *pdev) > return 0; > } > > -static int mt6370_tcpc_remove(struct platform_device *pdev) > +static void mt6370_tcpc_remove(struct platform_device *pdev) > { > dev_pm_clear_wake_irq(&pdev->dev); > device_init_wakeup(&pdev->dev, false); > - > - return 0; > } > > static const struct of_device_id mt6370_tcpc_devid_table[] = { > @@ -198,7 +196,7 @@ static struct platform_driver mt6370_tcpc_driver = { > .of_match_table = mt6370_tcpc_devid_table, > }, > .probe = mt6370_tcpc_probe, > - .remove = mt6370_tcpc_remove, > + .remove_new = mt6370_tcpc_remove, > }; > module_platform_driver(mt6370_tcpc_driver); > > -- > 2.39.2 >
On Thu, May 18, 2023 at 01:02:36AM +0200, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart from > emitting a warning) and this typically results in resource leaks. To improve > here there is a quest to make the remove callback return void. In the first > step of this quest all drivers are converted to .remove_new() which already > returns void. Eventually after all drivers are converted, .remove_new() is > renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/tcpm/tcpci_mt6370.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/typec/tcpm/tcpci_mt6370.c b/drivers/usb/typec/tcpm/tcpci_mt6370.c > index c5bb201a5163..2a079464b398 100644 > --- a/drivers/usb/typec/tcpm/tcpci_mt6370.c > +++ b/drivers/usb/typec/tcpm/tcpci_mt6370.c > @@ -178,12 +178,10 @@ static int mt6370_tcpc_probe(struct platform_device *pdev) > return 0; > } > > -static int mt6370_tcpc_remove(struct platform_device *pdev) > +static void mt6370_tcpc_remove(struct platform_device *pdev) > { > dev_pm_clear_wake_irq(&pdev->dev); > device_init_wakeup(&pdev->dev, false); > - > - return 0; > } > > static const struct of_device_id mt6370_tcpc_devid_table[] = { > @@ -198,7 +196,7 @@ static struct platform_driver mt6370_tcpc_driver = { > .of_match_table = mt6370_tcpc_devid_table, > }, > .probe = mt6370_tcpc_probe, > - .remove = mt6370_tcpc_remove, > + .remove_new = mt6370_tcpc_remove, > }; > module_platform_driver(mt6370_tcpc_driver); > > -- > 2.39.2
diff --git a/drivers/usb/typec/tcpm/tcpci_mt6370.c b/drivers/usb/typec/tcpm/tcpci_mt6370.c index c5bb201a5163..2a079464b398 100644 --- a/drivers/usb/typec/tcpm/tcpci_mt6370.c +++ b/drivers/usb/typec/tcpm/tcpci_mt6370.c @@ -178,12 +178,10 @@ static int mt6370_tcpc_probe(struct platform_device *pdev) return 0; } -static int mt6370_tcpc_remove(struct platform_device *pdev) +static void mt6370_tcpc_remove(struct platform_device *pdev) { dev_pm_clear_wake_irq(&pdev->dev); device_init_wakeup(&pdev->dev, false); - - return 0; } static const struct of_device_id mt6370_tcpc_devid_table[] = { @@ -198,7 +196,7 @@ static struct platform_driver mt6370_tcpc_driver = { .of_match_table = mt6370_tcpc_devid_table, }, .probe = mt6370_tcpc_probe, - .remove = mt6370_tcpc_remove, + .remove_new = mt6370_tcpc_remove, }; module_platform_driver(mt6370_tcpc_driver);
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() is renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/usb/typec/tcpm/tcpci_mt6370.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)