| Message ID | 20231107031442.2768765-2-zhourui@huaqin.corp-partner.google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | add es8326 dt-bindings and es8326 support | expand |
On 07/11/2023 04:14, Rui Zhou wrote: > Add compatible string "mediatek,mt8188-es8326" to support new board > with es8326 codec. Please use standard email subjects, so with the PATCH keyword in the title. `git format-patch` helps here to create proper versioned patches. Another useful tool is b4. Skipping the PATCH keyword makes filtering of emails more difficult thus making the review process less convenient. > > Signed-off-by: Rui Zhou <zhourui@huaqin.corp-partner.google.com> > --- > .../devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml > index 4c8c95057ef7..9df5e44176d0 100644 > --- a/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml > +++ b/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml > @@ -18,6 +18,7 @@ properties: > - mediatek,mt8188-mt6359-evb > - mediatek,mt8188-nau8825 > - mediatek,mt8188-rt5682s > + - mediatek,mt8188-es8326 Entries should be sorted alphabetically. Best regards, Krzysztof
Thank you very much for your reminder, I will pay attention next time. On Tue, Nov 7, 2023 at 3:11 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 07/11/2023 04:14, Rui Zhou wrote: > > Add compatible string "mediatek,mt8188-es8326" to support new board > > with es8326 codec. > > Please use standard email subjects, so with the PATCH keyword in the > title. `git format-patch` helps here to create proper versioned patches. > Another useful tool is b4. Skipping the PATCH keyword makes filtering of > emails more difficult thus making the review process less convenient. > > > > > Signed-off-by: Rui Zhou <zhourui@huaqin.corp-partner.google.com> > > --- > > .../devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml > > index 4c8c95057ef7..9df5e44176d0 100644 > > --- a/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml > > +++ b/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml > > @@ -18,6 +18,7 @@ properties: > > - mediatek,mt8188-mt6359-evb > > - mediatek,mt8188-nau8825 > > - mediatek,mt8188-rt5682s > > + - mediatek,mt8188-es8326 > > Entries should be sorted alphabetically. > > Best regards, > Krzysztof >
On 07/11/2023 08:59, Rui Zhou wrote:
> Thank you very much for your reminder, I will pay attention next time.
Next time? Does it mean you are not going to fix the patch as I asked
about the order?
Best regards,
Krzysztof
Sorry, I didn't express myself clearly. What I mean is that I will modify everything according to your suggestions in the V2 version. On Tue, Nov 7, 2023 at 4:06 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 07/11/2023 08:59, Rui Zhou wrote: > > Thank you very much for your reminder, I will pay attention next time. > > Next time? Does it mean you are not going to fix the patch as I asked > about the order? > > Best regards, > Krzysztof >
Il 07/11/23 04:14, Rui Zhou ha scritto: > Add compatible string "mediatek,mt8188-es8326" to support new board > with es8326 codec. > > Signed-off-by: Rui Zhou <zhourui@huaqin.corp-partner.google.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Il 07/11/23 04:14, Rui Zhou ha scritto: > Add compatible string "mediatek,mt8188-es8326" to support new board > with es8326 codec. > > Signed-off-by: Rui Zhou <zhourui@huaqin.corp-partner.google.com> > --- > .../devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml > index 4c8c95057ef7..9df5e44176d0 100644 > --- a/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml > +++ b/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml > @@ -18,6 +18,7 @@ properties: > - mediatek,mt8188-mt6359-evb > - mediatek,mt8188-nau8825 > - mediatek,mt8188-rt5682s > + - mediatek,mt8188-es8326 Whoops, sorry, I just noticed that this is not alphabetically ordered. Please move that before mediatek,mt8188-mt6359-evb. Thanks, Angelo > > audio-routing: > description:
diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml index 4c8c95057ef7..9df5e44176d0 100644 --- a/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml +++ b/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml @@ -18,6 +18,7 @@ properties: - mediatek,mt8188-mt6359-evb - mediatek,mt8188-nau8825 - mediatek,mt8188-rt5682s + - mediatek,mt8188-es8326 audio-routing: description:
Add compatible string "mediatek,mt8188-es8326" to support new board with es8326 codec. Signed-off-by: Rui Zhou <zhourui@huaqin.corp-partner.google.com> --- .../devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml | 1 + 1 file changed, 1 insertion(+)