diff mbox series

[3/3] dt-bindings: eeprom: at24: Add property dovdd-supply

Message ID 20240426102949.23057-4-zoie.lin@mediatek.com (mailing list archive)
State New, archived
Headers show
Series misc: eeprom: at24: add optional dovdd-supply | expand

Commit Message

Zoie Lin (林禹妡) April 26, 2024, 10:29 a.m. UTC 
From: Zoie Lin <zoie.lin@mediatek.com>

Include a new property named dovdd-supply to provide an
additional power supply.

Signed-off-by: Zoie Lin <zoie.lin@mediatek.com>
---
 Documentation/devicetree/bindings/eeprom/at24.yaml | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Krzysztof Kozlowski April 26, 2024, 10:59 a.m. UTC | #1 
On 26/04/2024 12:29, zoie.lin wrote:
> From: Zoie Lin <zoie.lin@mediatek.com>
> 
> Include a new property named dovdd-supply to provide an
> additional power supply.

Which pin is it? Which device? Please write something useful...

I cannot find such pin on AT24C64, which you are adding support here.
https://ww1.microchip.com/downloads/en/devicedoc/doc0336.pdf



Best regards,
Krzysztof
Rob Herring (Arm) April 26, 2024, 7:10 p.m. UTC | #2 
On Fri, Apr 26, 2024 at 06:29:49PM +0800, zoie.lin wrote:
> From: Zoie Lin <zoie.lin@mediatek.com>
> 
> Include a new property named dovdd-supply to provide an
> additional power supply.
> 
> Signed-off-by: Zoie Lin <zoie.lin@mediatek.com>
> ---
>  Documentation/devicetree/bindings/eeprom/at24.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml
> index 8befd09963be..0ecb7ea76d1d 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.yaml
> +++ b/Documentation/devicetree/bindings/eeprom/at24.yaml
> @@ -193,6 +193,10 @@ properties:
>      description:
>        phandle of the regulator that provides the supply voltage.
>  
> +  dovdd-supply:
> +    description:
> +      phandle of the regulator that provides the supply voltage.

We already have "the regulator that provides the supply voltage" just 
above.

> +
>  required:
>    - compatible
>    - reg
> -- 
> 2.18.0
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml
index 8befd09963be..0ecb7ea76d1d 100644
--- a/Documentation/devicetree/bindings/eeprom/at24.yaml
+++ b/Documentation/devicetree/bindings/eeprom/at24.yaml
@@ -193,6 +193,10 @@  properties:
     description:
       phandle of the regulator that provides the supply voltage.
 
+  dovdd-supply:
+    description:
+      phandle of the regulator that provides the supply voltage.
+
 required:
   - compatible
   - reg