| Message ID | 20240529-mtk-thermal-mt818x-dtsi-v6-1-0c71478a9c37@baylibre.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Mediatek thermal sensor driver support for MT8186 and MT8188 | expand |
Il 29/05/24 07:57, Julien Panis ha scritto: > Fix a thermal zone name for consistency with the other SoCs: > MFG contains GPU, the latter is more specific and must be used here. > > The naming must be fixed "atomically" so compilation does not break. > As a result, the change is made in the dt-bindings and in the LVTS > driver within a single commit, despite the checkpatch warning. > > The definition can be modified safely here because it is used only > in the LVTS driver, which is modified accordingly. > > Fixes: a2ca202350f9 ("dt-bindings: thermal: mediatek: Add LVTS thermal controller definition for MT8186") > Signed-off-by: Julien Panis <jpanis@baylibre.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On Wed, May 29, 2024 at 07:57:56AM +0200, Julien Panis wrote: > Fix a thermal zone name for consistency with the other SoCs: > MFG contains GPU, the latter is more specific and must be used here. > > The naming must be fixed "atomically" so compilation does not break. > As a result, the change is made in the dt-bindings and in the LVTS > driver within a single commit, despite the checkpatch warning. > > The definition can be modified safely here because it is used only > in the LVTS driver, which is modified accordingly. > > Fixes: a2ca202350f9 ("dt-bindings: thermal: mediatek: Add LVTS thermal controller definition for MT8186") > Signed-off-by: Julien Panis <jpanis@baylibre.com> Same comment on the commit message here. Otherwise, Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor.
diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c index 0bb3a495b56e..506eed52db1e 100644 --- a/drivers/thermal/mediatek/lvts_thermal.c +++ b/drivers/thermal/mediatek/lvts_thermal.c @@ -1436,7 +1436,7 @@ static const struct lvts_ctrl_data mt8186_lvts_data_ctrl[] = { .cal_offsets = { 29, 30, 31 } }, { .dt_id = MT8186_ADSP, .cal_offsets = { 34, 35, 28 } }, - { .dt_id = MT8186_MFG, + { .dt_id = MT8186_GPU, .cal_offsets = { 39, 32, 33 } } }, VALID_SENSOR_MAP(1, 1, 1, 0), diff --git a/include/dt-bindings/thermal/mediatek,lvts-thermal.h b/include/dt-bindings/thermal/mediatek,lvts-thermal.h index bf95309d2525..85d25b4d726d 100644 --- a/include/dt-bindings/thermal/mediatek,lvts-thermal.h +++ b/include/dt-bindings/thermal/mediatek,lvts-thermal.h @@ -24,7 +24,7 @@ #define MT8186_BIG_CPU1 5 #define MT8186_NNA 6 #define MT8186_ADSP 7 -#define MT8186_MFG 8 +#define MT8186_GPU 8 #define MT8188_MCU_LITTLE_CPU0 0 #define MT8188_MCU_LITTLE_CPU1 1
Fix a thermal zone name for consistency with the other SoCs: MFG contains GPU, the latter is more specific and must be used here. The naming must be fixed "atomically" so compilation does not break. As a result, the change is made in the dt-bindings and in the LVTS driver within a single commit, despite the checkpatch warning. The definition can be modified safely here because it is used only in the LVTS driver, which is modified accordingly. Fixes: a2ca202350f9 ("dt-bindings: thermal: mediatek: Add LVTS thermal controller definition for MT8186") Signed-off-by: Julien Panis <jpanis@baylibre.com> --- drivers/thermal/mediatek/lvts_thermal.c | 2 +- include/dt-bindings/thermal/mediatek,lvts-thermal.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)