| Message ID | 20240620054708.2230665-1-wenst@chromium.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm/mediatek: select DRM_GEM_DMA_HELPER if DRM_FBDEV_EMULATION=y | expand |
Hi Am 20.06.24 um 07:47 schrieb Chen-Yu Tsai: > With the recent switch from fbdev-generic to fbdev-dma, the driver now > requires the DRM GEM DMA helpers. This dependency is missing, and will > cause a link failure if fbdev emulation is enabled. > > Add the missing dependency. > > Fixes: 0992284b4fe4 ("drm/mediatek: Use fbdev-dma") > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> Apart from this problem, would it make sense to convert the driver's management to GEM's DMA helpers? It appears there's some code duplication in mtk_gem.c and these helpers. Best regards Thomas > --- > The commit this patch fixes is in drm-misc-next. Ideally this patch > should be applied on top of it directly. > > CK, could you give your ack for it? > > drivers/gpu/drm/mediatek/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig > index 96cbe020f493..d6449ebae838 100644 > --- a/drivers/gpu/drm/mediatek/Kconfig > +++ b/drivers/gpu/drm/mediatek/Kconfig > @@ -7,6 +7,7 @@ config DRM_MEDIATEK > depends on HAVE_ARM_SMCCC > depends on OF > depends on MTK_MMSYS > + select DRM_GEM_DMA_HELPER if DRM_FBDEV_EMULATION > select DRM_KMS_HELPER > select DRM_MIPI_DSI > select DRM_PANEL
On Thu, Jun 20, 2024 at 2:37 PM Thomas Zimmermann <tzimmermann@suse.de> wrote: > > Hi > > Am 20.06.24 um 07:47 schrieb Chen-Yu Tsai: > > With the recent switch from fbdev-generic to fbdev-dma, the driver now > > requires the DRM GEM DMA helpers. This dependency is missing, and will > > cause a link failure if fbdev emulation is enabled. > > > > Add the missing dependency. > > > > Fixes: 0992284b4fe4 ("drm/mediatek: Use fbdev-dma") > > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > > Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> > > Apart from this problem, would it make sense to convert the driver's > management to GEM's DMA helpers? It appears there's some code > duplication in mtk_gem.c and these helpers. It seems at least import_sg_table could be converted. I don't have the bandwidth to do a more in-depth review though. Thanks ChenYu > Best regards > Thomas > > > --- > > The commit this patch fixes is in drm-misc-next. Ideally this patch > > should be applied on top of it directly. > > > > CK, could you give your ack for it? > > > > drivers/gpu/drm/mediatek/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig > > index 96cbe020f493..d6449ebae838 100644 > > --- a/drivers/gpu/drm/mediatek/Kconfig > > +++ b/drivers/gpu/drm/mediatek/Kconfig > > @@ -7,6 +7,7 @@ config DRM_MEDIATEK > > depends on HAVE_ARM_SMCCC > > depends on OF > > depends on MTK_MMSYS > > + select DRM_GEM_DMA_HELPER if DRM_FBDEV_EMULATION > > select DRM_KMS_HELPER > > select DRM_MIPI_DSI > > select DRM_PANEL > > -- > -- > Thomas Zimmermann > Graphics Driver Developer > SUSE Software Solutions Germany GmbH > Frankenstrasse 146, 90461 Nuernberg, Germany > GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman > HRB 36809 (AG Nuernberg) >
Hi, Chen-Yu: Chen-Yu Tsai <wenst@chromium.org> 於 2024年6月20日 週四 下午1:47寫道： > > With the recent switch from fbdev-generic to fbdev-dma, the driver now > requires the DRM GEM DMA helpers. This dependency is missing, and will > cause a link failure if fbdev emulation is enabled. > > Add the missing dependency. Acked-by: Chun-Kuang Hu <chunkuang.hu@mediatek.com> > > Fixes: 0992284b4fe4 ("drm/mediatek: Use fbdev-dma") > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > --- > The commit this patch fixes is in drm-misc-next. Ideally this patch > should be applied on top of it directly. > > CK, could you give your ack for it? > > drivers/gpu/drm/mediatek/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig > index 96cbe020f493..d6449ebae838 100644 > --- a/drivers/gpu/drm/mediatek/Kconfig > +++ b/drivers/gpu/drm/mediatek/Kconfig > @@ -7,6 +7,7 @@ config DRM_MEDIATEK > depends on HAVE_ARM_SMCCC > depends on OF > depends on MTK_MMSYS > + select DRM_GEM_DMA_HELPER if DRM_FBDEV_EMULATION > select DRM_KMS_HELPER > select DRM_MIPI_DSI > select DRM_PANEL > -- > 2.45.2.741.gdbec12cfda-goog >
Queued, thanks. Paolo
On Thu, Jun 20, 2024 at 11:21 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
> Queued, thanks.
Oops, a script started sending "queued" messages for everything that
had "y" in the subject. Sorry about that.
Paolo
Hi Thomas, On Thu, Jun 20, 2024 at 10:20 PM Chun-Kuang Hu <chunkuang.hu@kernel.org> wrote: > > Hi, Chen-Yu: > > Chen-Yu Tsai <wenst@chromium.org> 於 2024年6月20日 週四 下午1:47寫道： > > > > With the recent switch from fbdev-generic to fbdev-dma, the driver now > > requires the DRM GEM DMA helpers. This dependency is missing, and will > > cause a link failure if fbdev emulation is enabled. > > > > Add the missing dependency. > > Acked-by: Chun-Kuang Hu <chunkuang.hu@mediatek.com> Could you help merge this? Thanks ChenYu > > > > Fixes: 0992284b4fe4 ("drm/mediatek: Use fbdev-dma") > > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > > --- > > The commit this patch fixes is in drm-misc-next. Ideally this patch > > should be applied on top of it directly. > > > > CK, could you give your ack for it? > > > > drivers/gpu/drm/mediatek/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig > > index 96cbe020f493..d6449ebae838 100644 > > --- a/drivers/gpu/drm/mediatek/Kconfig > > +++ b/drivers/gpu/drm/mediatek/Kconfig > > @@ -7,6 +7,7 @@ config DRM_MEDIATEK > > depends on HAVE_ARM_SMCCC > > depends on OF > > depends on MTK_MMSYS > > + select DRM_GEM_DMA_HELPER if DRM_FBDEV_EMULATION > > select DRM_KMS_HELPER > > select DRM_MIPI_DSI > > select DRM_PANEL > > -- > > 2.45.2.741.gdbec12cfda-goog > >
Hi Am 26.06.24 um 08:37 schrieb Chen-Yu Tsai: > Hi Thomas, > > On Thu, Jun 20, 2024 at 10:20 PM Chun-Kuang Hu <chunkuang.hu@kernel.org> wrote: >> Hi, Chen-Yu: >> >> Chen-Yu Tsai <wenst@chromium.org> 於 2024年6月20日 週四 下午1:47寫道： >>> With the recent switch from fbdev-generic to fbdev-dma, the driver now >>> requires the DRM GEM DMA helpers. This dependency is missing, and will >>> cause a link failure if fbdev emulation is enabled. >>> >>> Add the missing dependency. >> Acked-by: Chun-Kuang Hu <chunkuang.hu@mediatek.com> > Could you help merge this? It's merged into drm-misc-fixes. Best regards Thomas > > Thanks > ChenYu > >>> Fixes: 0992284b4fe4 ("drm/mediatek: Use fbdev-dma") >>> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> >>> --- >>> The commit this patch fixes is in drm-misc-next. Ideally this patch >>> should be applied on top of it directly. >>> >>> CK, could you give your ack for it? >>> >>> drivers/gpu/drm/mediatek/Kconfig | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig >>> index 96cbe020f493..d6449ebae838 100644 >>> --- a/drivers/gpu/drm/mediatek/Kconfig >>> +++ b/drivers/gpu/drm/mediatek/Kconfig >>> @@ -7,6 +7,7 @@ config DRM_MEDIATEK >>> depends on HAVE_ARM_SMCCC >>> depends on OF >>> depends on MTK_MMSYS >>> + select DRM_GEM_DMA_HELPER if DRM_FBDEV_EMULATION >>> select DRM_KMS_HELPER >>> select DRM_MIPI_DSI >>> select DRM_PANEL >>> -- >>> 2.45.2.741.gdbec12cfda-goog >>>
Am 26.06.24 um 16:07 schrieb Thomas Zimmermann: > Hi > > Am 26.06.24 um 08:37 schrieb Chen-Yu Tsai: >> Hi Thomas, >> >> On Thu, Jun 20, 2024 at 10:20 PM Chun-Kuang Hu >> <chunkuang.hu@kernel.org> wrote: >>> Hi, Chen-Yu: >>> >>> Chen-Yu Tsai <wenst@chromium.org> 於 2024年6月20日 週四 下午1:47寫道： >>>> With the recent switch from fbdev-generic to fbdev-dma, the driver now >>>> requires the DRM GEM DMA helpers. This dependency is missing, and will >>>> cause a link failure if fbdev emulation is enabled. >>>> >>>> Add the missing dependency. >>> Acked-by: Chun-Kuang Hu <chunkuang.hu@mediatek.com> >> Could you help merge this? > > It's merged into drm-misc-fixes. drm-misc-next > > Best regards > Thomas > >> >> Thanks >> ChenYu >> >>>> Fixes: 0992284b4fe4 ("drm/mediatek: Use fbdev-dma") >>>> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> >>>> --- >>>> The commit this patch fixes is in drm-misc-next. Ideally this patch >>>> should be applied on top of it directly. >>>> >>>> CK, could you give your ack for it? >>>> >>>> drivers/gpu/drm/mediatek/Kconfig | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/drivers/gpu/drm/mediatek/Kconfig >>>> b/drivers/gpu/drm/mediatek/Kconfig >>>> index 96cbe020f493..d6449ebae838 100644 >>>> --- a/drivers/gpu/drm/mediatek/Kconfig >>>> +++ b/drivers/gpu/drm/mediatek/Kconfig >>>> @@ -7,6 +7,7 @@ config DRM_MEDIATEK >>>> depends on HAVE_ARM_SMCCC >>>> depends on OF >>>> depends on MTK_MMSYS >>>> + select DRM_GEM_DMA_HELPER if DRM_FBDEV_EMULATION >>>> select DRM_KMS_HELPER >>>> select DRM_MIPI_DSI >>>> select DRM_PANEL >>>> -- >>>> 2.45.2.741.gdbec12cfda-goog >>>> >
diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig index 96cbe020f493..d6449ebae838 100644 --- a/drivers/gpu/drm/mediatek/Kconfig +++ b/drivers/gpu/drm/mediatek/Kconfig @@ -7,6 +7,7 @@ config DRM_MEDIATEK depends on HAVE_ARM_SMCCC depends on OF depends on MTK_MMSYS + select DRM_GEM_DMA_HELPER if DRM_FBDEV_EMULATION select DRM_KMS_HELPER select DRM_MIPI_DSI select DRM_PANEL
With the recent switch from fbdev-generic to fbdev-dma, the driver now requires the DRM GEM DMA helpers. This dependency is missing, and will cause a link failure if fbdev emulation is enabled. Add the missing dependency. Fixes: 0992284b4fe4 ("drm/mediatek: Use fbdev-dma") Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> --- The commit this patch fixes is in drm-misc-next. Ideally this patch should be applied on top of it directly. CK, could you give your ack for it? drivers/gpu/drm/mediatek/Kconfig | 1 + 1 file changed, 1 insertion(+)