[v4,04/15] PCI: brcmstb: Silence set affinity failed warning

Commit Message

Marek Vasut July 23, 2024, 1:27 p.m. UTC

Use newly introduced MSI_FLAG_NO_AFFINITY, which keeps .irq_set_affinity unset
and allows migrate_one_irq() code in cpuhotplug.c to exit right away, without
printing "IRQ...: set affinity failed(-22)" warning.

Remove .irq_set_affinity implementation which only return -EINVAL from this
controller driver.

Signed-off-by: Marek Vasut <[e-mail]>
---
Cc: "Krzysztof Wilczyński" <[e-mail]>
Cc: "Pali Rohár" <[e-mail]>
Cc: "Uwe Kleine-König" <[e-mail]>
Cc: Aleksandr Mishin <[e-mail]>
Cc: Anna-Maria Behnsen <[e-mail]>
Cc: Anup Patel <[e-mail]>
Cc: Bjorn Helgaas <[e-mail]>
Cc: Broadcom internal kernel review list <[e-mail]>
Cc: Daire McNamara <[e-mail]>
Cc: Damien Le Moal <[e-mail]>
Cc: Florian Fainelli <[e-mail]>
Cc: Hou Zhiqiang <[e-mail]>
Cc: Jianjun Wang <[e-mail]>
Cc: Jim Quinlan <[e-mail]>
Cc: Jingoo Han <[e-mail]>
Cc: Jisheng Zhang <[e-mail]>
Cc: Jon Hunter <[e-mail]>
Cc: Jonathan Derrick <[e-mail]>
Cc: Jonathan Hunter <[e-mail]>
Cc: Joyce Ooi <[e-mail]>
Cc: Karthikeyan Mitran <[e-mail]>
Cc: Kishon Vijay Abraham I <[e-mail]>
Cc: Koichiro Den <[e-mail]>
Cc: Lorenzo Pieralisi <[e-mail]>
Cc: Manivannan Sadhasivam <[e-mail]>
Cc: Marc Zyngier <[e-mail]>
Cc: Michal Simek <[e-mail]>
Cc: Nicolas Saenz Julienne <[e-mail]>
Cc: Niklas Cassel <[e-mail]>
Cc: Nipun Gupta <[e-mail]>
Cc: Nirmal Patel <[e-mail]>
Cc: Rob Herring <[e-mail]>
Cc: Ryder Lee <[e-mail]>
Cc: Shivamurthy Shastri <[e-mail]>
Cc: Siddharth Vadapalli <[e-mail]>
Cc: Thierry Reding <[e-mail]>
Cc: Thomas Gleixner <[e-mail]>
Cc: Thomas Petazzoni <[e-mail]>
Cc: Yoshihiro Shimoda <[e-mail]>
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
---
V4: - New patch
---
 drivers/pci/controller/pcie-brcmstb.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

Comments

Florian Fainelli July 24, 2024, midnight UTC | #1

On 7/23/24 06:27, Marek Vasut wrote:
> Use newly introduced MSI_FLAG_NO_AFFINITY, which keeps .irq_set_affinity unset
> and allows migrate_one_irq() code in cpuhotplug.c to exit right away, without
> printing "IRQ...: set affinity failed(-22)" warning.
> 
> Remove .irq_set_affinity implementation which only return -EINVAL from this
> controller driver.
> 
> Signed-off-by: Marek Vasut <[e-mail]>

Reviewed-by: Florian Fainelli <[e-mail]>

Patch

diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c
index c08683febdd40..b9de3acec3753 100644
--- a/drivers/pci/controller/pcie-brcmstb.c
+++ b/drivers/pci/controller/pcie-brcmstb.c
@@ -445,8 +445,8 @@  static struct irq_chip brcm_msi_irq_chip = {
 };
 
 static struct msi_domain_info brcm_msi_domain_info = {
-	.flags	= (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
-		   MSI_FLAG_MULTI_PCI_MSI),
+	.flags	= MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
+		  MSI_FLAG_NO_AFFINITY | MSI_FLAG_MULTI_PCI_MSI,
 	.chip	= &brcm_msi_irq_chip,
 };
 
@@ -484,12 +484,6 @@  static void brcm_msi_compose_msi_msg(struct irq_data *data, struct msi_msg *msg)
 	msg->data = (0xffff & PCIE_MISC_MSI_DATA_CONFIG_VAL_32) | data->hwirq;
 }
 
-static int brcm_msi_set_affinity(struct irq_data *irq_data,
-				 const struct cpumask *mask, bool force)
-{
-	return -EINVAL;
-}
-
 static void brcm_msi_ack_irq(struct irq_data *data)
 {
 	struct brcm_msi *msi = irq_data_get_irq_chip_data(data);
@@ -502,7 +496,6 @@  static void brcm_msi_ack_irq(struct irq_data *data)
 static struct irq_chip brcm_msi_bottom_irq_chip = {
 	.name			= "BRCM STB MSI",
 	.irq_compose_msi_msg	= brcm_msi_compose_msi_msg,
-	.irq_set_affinity	= brcm_msi_set_affinity,
 	.irq_ack                = brcm_msi_ack_irq,
 };