diff mbox series

[1/3] dt-bindings: display: mediatek: dpi: Add power domains

Message ID 20240820080659.2136906-2-rohiagar@chromium.org (mailing list archive)
State New
Headers show
Series Devicetree updates for MT8186 | expand

Commit Message

Rohit Agarwal Aug. 20, 2024, 8:06 a.m. UTC
Add power domain binding to the mediatek DPI controller.

Signed-off-by: Rohit Agarwal <rohiagar@chromium.org>
---
 .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml     | 3 +++
 1 file changed, 3 insertions(+)

Comments

Krzysztof Kozlowski Aug. 20, 2024, 11:10 a.m. UTC | #1
On Tue, Aug 20, 2024 at 08:06:57AM +0000, Rohit Agarwal wrote:
> Add power domain binding to the mediatek DPI controller.

Why? Who needs it? Why all devices suddenly have it (IOW, why is it not
constrained anyhow per variant)?

> 
> Signed-off-by: Rohit Agarwal <rohiagar@chromium.org>
> ---
>  .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml     | 3 +++
>  1 file changed, 3 insertions(+)

Best regards,
Krzysztof
Rohit Agarwal Aug. 20, 2024, 12:18 p.m. UTC | #2
On 20/08/24 4:40 PM, Krzysztof Kozlowski wrote:
> On Tue, Aug 20, 2024 at 08:06:57AM +0000, Rohit Agarwal wrote:
>> Add power domain binding to the mediatek DPI controller.
> Why? Who needs it? Why all devices suddenly have it (IOW, why is it not
> constrained anyhow per variant)?
>
Ok, my intent was to introduce only for this particular variant.
Let me constrain it to this particular compatible.

Thanks,
Rohit.
>> Signed-off-by: Rohit Agarwal <rohiagar@chromium.org>
>> ---
>>   .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml     | 3 +++
>>   1 file changed, 3 insertions(+)
> Best regards,
> Krzysztof
>
Krzysztof Kozlowski Aug. 21, 2024, 6:48 a.m. UTC | #3
On 20/08/2024 14:18, Rohit Agarwal wrote:
> 
> On 20/08/24 4:40 PM, Krzysztof Kozlowski wrote:
>> On Tue, Aug 20, 2024 at 08:06:57AM +0000, Rohit Agarwal wrote:
>>> Add power domain binding to the mediatek DPI controller.
>> Why? Who needs it? Why all devices suddenly have it (IOW, why is it not
>> constrained anyhow per variant)?
>>
> Ok, my intent was to introduce only for this particular variant.
> Let me constrain it to this particular compatible.

Then add property in top-level properties and in if:then: disallow it
for older devices.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
index 5ca7679d5427..10b8572dd922 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
@@ -62,6 +62,9 @@  properties:
       - const: default
       - const: sleep
 
+  power-domains:
+    maxItems: 1
+
   port:
     $ref: /schemas/graph.yaml#/properties/port
     description: