| Message ID | 20240926102238.24303-2-jason-jh.lin@mediatek.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Fix degradation problem of alpha blending series | expand |
Hi, Jason: On Thu, 2024-09-26 at 18:22 +0800, Jason-JH.Lin wrote: > Since we changed MACROs to be consistent with DRM input color format > naming, the comment for ovl_fmt_conver() is no longer needed. Reviewed-by: CK Hu <ck.hu@mediatek.com> > > Fixes: 9f428b95ac89 ("drm/mediatek: Add new color format MACROs in OVL") > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com> > --- > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > index 89b439dcf3a6..4a4bc27a67f0 100644 > --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > @@ -389,11 +389,6 @@ void mtk_ovl_layer_off(struct device *dev, unsigned int idx, > static unsigned int ovl_fmt_convert(struct mtk_disp_ovl *ovl, unsigned int fmt, > unsigned int blend_mode) > { > - /* The return value in switch "MEM_MODE_INPUT_FORMAT_XXX" > - * is defined in mediatek HW data sheet. > - * The alphabet order in XXX is no relation to data > - * arrangement in memory. > - */ > switch (fmt) { > default: > case DRM_FORMAT_RGB565:
diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c index 89b439dcf3a6..4a4bc27a67f0 100644 --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c @@ -389,11 +389,6 @@ void mtk_ovl_layer_off(struct device *dev, unsigned int idx, static unsigned int ovl_fmt_convert(struct mtk_disp_ovl *ovl, unsigned int fmt, unsigned int blend_mode) { - /* The return value in switch "MEM_MODE_INPUT_FORMAT_XXX" - * is defined in mediatek HW data sheet. - * The alphabet order in XXX is no relation to data - * arrangement in memory. - */ switch (fmt) { default: case DRM_FORMAT_RGB565:
Since we changed MACROs to be consistent with DRM input color format naming, the comment for ovl_fmt_conver() is no longer needed. Fixes: 9f428b95ac89 ("drm/mediatek: Add new color format MACROs in OVL") Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com> --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 5 ----- 1 file changed, 5 deletions(-)