| Message ID | 20241015103337.20479-1-macpaul.lin@mediatek.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] dt-bindings: usb: mediatek,mt6360-tcpc: add ports properties | expand |
On Tue, 15 Oct 2024 18:33:36 +0800, Macpaul Lin wrote: > Add 'ports' and sub node 'port' properties to specify connectors on the > High-Speed/Super-Speed data bus, or Sideband Use (SBU) AUX lines > endpoints of the USB controller. > > Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> > --- > .../bindings/usb/mediatek,mt6360-tcpc.yaml | 21 +++++++++++++++++++ > 1 file changed, 21 insertions(+) > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y mediatek/mt8395-genio-1200-evk.dtb' for 20241015103337.20479-1-macpaul.lin@mediatek.com: arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dtb: usb@11201000: 'mediatek,usb3-drd' does not match any of the regexes: '^usb@[0-9a-f]+$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/usb/mediatek,mtu3.yaml#
On Tue, Oct 15, 2024 at 06:33:36PM +0800, Macpaul Lin wrote: > Add 'ports' and sub node 'port' properties to specify connectors on the > High-Speed/Super-Speed data bus, or Sideband Use (SBU) AUX lines > endpoints of the USB controller. > > Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> > --- > .../bindings/usb/mediatek,mt6360-tcpc.yaml | 21 +++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml > index 053264e60583..5b6ea0d734ea 100644 > --- a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml > +++ b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml > @@ -32,6 +32,27 @@ properties: > description: > Properties for usb c connector. > > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + description: > + Any connector to the data bus of this controller should be specified. > + properties: > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 No need for these, already defined in the $ref'ed schema. > + > + patternProperties: > + "port@[0-2]$": > + $ref: /schemas/graph.yaml#/properties/port > + description: > + It could be one of the following interface types. High-Speed > + (HS) data bus endpoint to the Type-C connector, SuperSpeed (SS) > + data bus endpoint to the Type-C connector, or Sideband Use (SBU) > + AUX lines endpoint to the Type-C connector for the purpose of > + handling altmode muxing and orientation switching. You have to define what each port number is. However, I'm completely confused as to why you need any of this. The description sounds like the usb-c-connector which is already defined as a child node. Rob
On 10/16/24 04:54, Rob Herring wrote: > > > External email : Please do not click links or open attachments until you > have verified the sender or the content. > > On Tue, Oct 15, 2024 at 06:33:36PM +0800, Macpaul Lin wrote: >> Add 'ports' and sub node 'port' properties to specify connectors on the >> High-Speed/Super-Speed data bus, or Sideband Use (SBU) AUX lines >> endpoints of the USB controller. >> >> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> >> --- >> .../bindings/usb/mediatek,mt6360-tcpc.yaml | 21 +++++++++++++++++++ >> 1 file changed, 21 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml >> index 053264e60583..5b6ea0d734ea 100644 >> --- a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml >> +++ b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml >> @@ -32,6 +32,27 @@ properties: >> description: >> Properties for usb c connector. >> >> + ports: >> + $ref: /schemas/graph.yaml#/properties/ports >> + description: >> + Any connector to the data bus of this controller should be specified. >> + properties: > >> + "#address-cells": >> + const: 1 >> + >> + "#size-cells": >> + const: 0 > > No need for these, already defined in the $ref'ed schema. > >> + >> + patternProperties: >> + "port@[0-2]$": >> + $ref: /schemas/graph.yaml#/properties/port >> + description: >> + It could be one of the following interface types. High-Speed >> + (HS) data bus endpoint to the Type-C connector, SuperSpeed (SS) >> + data bus endpoint to the Type-C connector, or Sideband Use (SBU) >> + AUX lines endpoint to the Type-C connector for the purpose of >> + handling altmode muxing and orientation switching. > > You have to define what each port number is. > > However, I'm completely confused as to why you need any of this. The > description sounds like the usb-c-connector which is already defined as > a child node. > > Rob > After checking the internal reference DTS, I've found the intent was wrong for these ports. I'll send [2/2] of v2 for the DTS update. Hence this change to DT Schema is no longer required. Please drop this patch. Thanks! Macpaul Lin
diff --git a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml index 053264e60583..5b6ea0d734ea 100644 --- a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml +++ b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml @@ -32,6 +32,27 @@ properties: description: Properties for usb c connector. + ports: + $ref: /schemas/graph.yaml#/properties/ports + description: + Any connector to the data bus of this controller should be specified. + properties: + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + + patternProperties: + "port@[0-2]$": + $ref: /schemas/graph.yaml#/properties/port + description: + It could be one of the following interface types. High-Speed + (HS) data bus endpoint to the Type-C connector, SuperSpeed (SS) + data bus endpoint to the Type-C connector, or Sideband Use (SBU) + AUX lines endpoint to the Type-C connector for the purpose of + handling altmode muxing and orientation switching. + additionalProperties: false required:
Add 'ports' and sub node 'port' properties to specify connectors on the High-Speed/Super-Speed data bus, or Sideband Use (SBU) AUX lines endpoints of the USB controller. Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> --- .../bindings/usb/mediatek,mt6360-tcpc.yaml | 21 +++++++++++++++++++ 1 file changed, 21 insertions(+)