diff mbox series

[v2,1/2] dt-bindings: clock: mediatek,mt8188: Add VDO1_DPI1_HDMI clock

Message ID 20250212100342.33618-1-angelogioacchino.delregno@collabora.com (mailing list archive)
State New
Headers show
Series [v2,1/2] dt-bindings: clock: mediatek,mt8188: Add VDO1_DPI1_HDMI clock | expand

Commit Message

AngeloGioacchino Del Regno Feb. 12, 2025, 10:03 a.m. UTC
Add binding for the HDMI TX clock found in the VDO1 controller.
While at it, also remove the unused CLK_VDO1_NR_CLK.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 include/dt-bindings/clock/mediatek,mt8188-clk.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Conor Dooley Feb. 12, 2025, 7:17 p.m. UTC | #1
On Wed, Feb 12, 2025 at 11:03:41AM +0100, AngeloGioacchino Del Regno wrote:
> Add binding for the HDMI TX clock found in the VDO1 controller.
> While at it, also remove the unused CLK_VDO1_NR_CLK.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>  include/dt-bindings/clock/mediatek,mt8188-clk.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/dt-bindings/clock/mediatek,mt8188-clk.h b/include/dt-bindings/clock/mediatek,mt8188-clk.h
> index bd5cd100b796..0e87f61c90f4 100644
> --- a/include/dt-bindings/clock/mediatek,mt8188-clk.h
> +++ b/include/dt-bindings/clock/mediatek,mt8188-clk.h
> @@ -721,6 +721,6 @@
>  #define CLK_VDO1_DPINTF				58
>  #define CLK_VDO1_DISP_MONITOR_DPINTF		59
>  #define CLK_VDO1_26M_SLOW			60
> -#define CLK_VDO1_NR_CLK				61
> +#define CLK_VDO1_DPI1_HDMI			61

Acked-by: Conor Dooley <conor.dooley@microchip.com>

btw, I see the mt8195 has this same CLK_VDO1_NR_CLK define in it, if you
fancy getting rid of that too.
AngeloGioacchino Del Regno Feb. 18, 2025, 1:22 p.m. UTC | #2
Il 12/02/25 20:17, Conor Dooley ha scritto:
> On Wed, Feb 12, 2025 at 11:03:41AM +0100, AngeloGioacchino Del Regno wrote:
>> Add binding for the HDMI TX clock found in the VDO1 controller.
>> While at it, also remove the unused CLK_VDO1_NR_CLK.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> ---
>>   include/dt-bindings/clock/mediatek,mt8188-clk.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/dt-bindings/clock/mediatek,mt8188-clk.h b/include/dt-bindings/clock/mediatek,mt8188-clk.h
>> index bd5cd100b796..0e87f61c90f4 100644
>> --- a/include/dt-bindings/clock/mediatek,mt8188-clk.h
>> +++ b/include/dt-bindings/clock/mediatek,mt8188-clk.h
>> @@ -721,6 +721,6 @@
>>   #define CLK_VDO1_DPINTF				58
>>   #define CLK_VDO1_DISP_MONITOR_DPINTF		59
>>   #define CLK_VDO1_26M_SLOW			60
>> -#define CLK_VDO1_NR_CLK				61
>> +#define CLK_VDO1_DPI1_HDMI			61
> 
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> 
> btw, I see the mt8195 has this same CLK_VDO1_NR_CLK define in it, if you
> fancy getting rid of that too.

Thanks Conor, yeah I'll do that asap... one commit for each NR_CLK is a bit
too much... I should just clean them all up :-)

That requires a bit of work though, so it's not something that I can do in
a few minutes; let's see if I can make it for this cycle, but no promises.

Cheers,
Angelo
Conor Dooley Feb. 18, 2025, 4:50 p.m. UTC | #3
On Tue, Feb 18, 2025 at 02:22:25PM +0100, AngeloGioacchino Del Regno wrote:
> Il 12/02/25 20:17, Conor Dooley ha scritto:
> > On Wed, Feb 12, 2025 at 11:03:41AM +0100, AngeloGioacchino Del Regno wrote:
> > > Add binding for the HDMI TX clock found in the VDO1 controller.
> > > While at it, also remove the unused CLK_VDO1_NR_CLK.
> > > 
> > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> > > ---
> > >   include/dt-bindings/clock/mediatek,mt8188-clk.h | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/include/dt-bindings/clock/mediatek,mt8188-clk.h b/include/dt-bindings/clock/mediatek,mt8188-clk.h
> > > index bd5cd100b796..0e87f61c90f4 100644
> > > --- a/include/dt-bindings/clock/mediatek,mt8188-clk.h
> > > +++ b/include/dt-bindings/clock/mediatek,mt8188-clk.h
> > > @@ -721,6 +721,6 @@
> > >   #define CLK_VDO1_DPINTF				58
> > >   #define CLK_VDO1_DISP_MONITOR_DPINTF		59
> > >   #define CLK_VDO1_26M_SLOW			60
> > > -#define CLK_VDO1_NR_CLK				61
> > > +#define CLK_VDO1_DPI1_HDMI			61
> > 
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> > 
> > btw, I see the mt8195 has this same CLK_VDO1_NR_CLK define in it, if you
> > fancy getting rid of that too.
> 
> Thanks Conor, yeah I'll do that asap... one commit for each NR_CLK is a bit
> too much... I should just clean them all up :-)
> 
> That requires a bit of work though, so it's not something that I can do in
> a few minutes; let's see if I can make it for this cycle, but no promises.

Yah, no worries. Was just pointing it out, don't need to let this
particular patch wait around for it by any means.
diff mbox series

Patch

diff --git a/include/dt-bindings/clock/mediatek,mt8188-clk.h b/include/dt-bindings/clock/mediatek,mt8188-clk.h
index bd5cd100b796..0e87f61c90f4 100644
--- a/include/dt-bindings/clock/mediatek,mt8188-clk.h
+++ b/include/dt-bindings/clock/mediatek,mt8188-clk.h
@@ -721,6 +721,6 @@ 
 #define CLK_VDO1_DPINTF				58
 #define CLK_VDO1_DISP_MONITOR_DPINTF		59
 #define CLK_VDO1_26M_SLOW			60
-#define CLK_VDO1_NR_CLK				61
+#define CLK_VDO1_DPI1_HDMI			61
 
 #endif /* _DT_BINDINGS_CLK_MT8188_H */