| Message ID | 20250219083910.2255981-2-SkyLake.Huang@mediatek.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add 2.5G ethernet phy support on MT7988 | expand |
On 19/02/2025 09:39, Sky Huang wrote: > From: Sky Huang <skylake.huang@mediatek.com> > > Add 2.5Gphy firmware dt-bindings and dts node since mtk-2p5ge > driver requires firmware to run. Also, update MAINTAINERS for > MediaTek's built-in 2.5Gphy dt-bindings and change MAINTAINER's name. > > Signed-off-by: Sky Huang <skylake.huang@mediatek.com> Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. For bindings, the preferred subjects are explained here: https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters <form letter> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time. Please kindly resend and include all necessary To/Cc entries. </form letter> > --- > .../bindings/net/mediatek,2p5gphy-fw.yaml | 37 +++++++++++++++++++ > MAINTAINERS | 3 +- > 2 files changed, 39 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/net/mediatek,2p5gphy-fw.yaml > > diff --git a/Documentation/devicetree/bindings/net/mediatek,2p5gphy-fw.yaml b/Documentation/devicetree/bindings/net/mediatek,2p5gphy-fw.yaml > new file mode 100644 > index 000000000000..56ebe88b8921 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/mediatek,2p5gphy-fw.yaml > @@ -0,0 +1,37 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/mediatek,2p5gphy-fw.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek Built-in 2.5G Ethernet PHY > + > +maintainers: > + - Sky Huang <SkyLake.Huang@mediatek.com> > + > +description: | > + MediaTek Built-in 2.5G Ethernet PHY needs to load firmware so it can > + run correctly. > + > +properties: > + compatible: > + const: "mediatek,2p5gphy-fw" Not tested. I have doubts that's a real device... Model name looks exactly like 2.5G phy. "FW" suggests you do it for driver. Read writing and submitting bindings documents. Best regards, Krzysztof
> +description: | > + MediaTek Built-in 2.5G Ethernet PHY needs to load firmware so it can > + run correctly. > + > +properties: > + compatible: > + const: "mediatek,2p5gphy-fw" > + > + reg: > + items: > + - description: pmb firmware load address > + - description: firmware trigger register > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + phyfw: phy-firmware@f000000 { > + compatible = "mediatek,2p5gphy-fw"; > + reg = <0 0x0f100000 0 0x20000>, > + <0 0x0f0f0018 0 0x20>; > + }; This is not a device in itself is it? There is no driver for this. It seems like these should be properties in the PHY node, since it is the PHY driver which make use of them. This cannot be the first SoC device which is both on some sort of serial bus, but also has memory mapped registers. Please look around and find the correct way to do this. Andrew
On Wed, Feb 19, 2025 at 04:26:21PM +0100, Andrew Lunn wrote: > > +description: | > > + MediaTek Built-in 2.5G Ethernet PHY needs to load firmware so it can > > + run correctly. > > + > > +properties: > > + compatible: > > + const: "mediatek,2p5gphy-fw" > > + > > + reg: > > + items: > > + - description: pmb firmware load address > > + - description: firmware trigger register > > + > > +required: > > + - compatible > > + - reg > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + phyfw: phy-firmware@f000000 { > > + compatible = "mediatek,2p5gphy-fw"; > > + reg = <0 0x0f100000 0 0x20000>, > > + <0 0x0f0f0018 0 0x20>; > > + }; > > This is not a device in itself is it? There is no driver for this. > > It seems like these should be properties in the PHY node, since it is > the PHY driver which make use of them. This cannot be the first SoC > device which is both on some sort of serial bus, but also has memory > mapped registers. I'm afraid it is... > Please look around and find the correct way to do this. Would using a 'reserved-memory' region be an option maybe?
diff --git a/Documentation/devicetree/bindings/net/mediatek,2p5gphy-fw.yaml b/Documentation/devicetree/bindings/net/mediatek,2p5gphy-fw.yaml new file mode 100644 index 000000000000..56ebe88b8921 --- /dev/null +++ b/Documentation/devicetree/bindings/net/mediatek,2p5gphy-fw.yaml @@ -0,0 +1,37 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/mediatek,2p5gphy-fw.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: MediaTek Built-in 2.5G Ethernet PHY + +maintainers: + - Sky Huang <SkyLake.Huang@mediatek.com> + +description: | + MediaTek Built-in 2.5G Ethernet PHY needs to load firmware so it can + run correctly. + +properties: + compatible: + const: "mediatek,2p5gphy-fw" + + reg: + items: + - description: pmb firmware load address + - description: firmware trigger register + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + phyfw: phy-firmware@f000000 { + compatible = "mediatek,2p5gphy-fw"; + reg = <0 0x0f100000 0 0x20000>, + <0 0x0f0f0018 0 0x20>; + }; diff --git a/MAINTAINERS b/MAINTAINERS index de81a3d68396..42ec8b8d03bf 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14716,9 +14716,10 @@ F: include/linux/pcs/pcs-mtk-lynxi.h MEDIATEK ETHERNET PHY DRIVERS M: Daniel Golle <daniel@makrotopia.org> M: Qingfang Deng <dqfext@gmail.com> -M: SkyLake Huang <SkyLake.Huang@mediatek.com> +M: Sky Huang <SkyLake.Huang@mediatek.com> L: netdev@vger.kernel.org S: Maintained +F: Documentation/devicetree/bindings/net/mediatek,2p5gphy-fw.yaml F: drivers/net/phy/mediatek/mtk-ge-soc.c F: drivers/net/phy/mediatek/mtk-phy-lib.c F: drivers/net/phy/mediatek/mtk-ge.c