diff mbox series

[v2] arm64: defconfig: mediatek: enable PHY drivers

Message ID 20250312041943.25676-1-vignesh.raman@collabora.com (mailing list archive)
State New
Headers show
Series [v2] arm64: defconfig: mediatek: enable PHY drivers | expand

Commit Message

Vignesh Raman March 12, 2025, 4:19 a.m. UTC
The mediatek display driver fails to probe on mt8173-elm-hana and
mt8183-kukui-jacuzzi-juniper-sku16 in v6.14-rc4 due to missing PHY
configurations.

Enable the following PHY drivers for MediaTek platforms:
- CONFIG_PHY_MTK_HDMI=m for HDMI display
- CONFIG_PHY_MTK_MIPI_DSI=m for DSI display
- CONFIG_PHY_MTK_XSPHY=m for USB

Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>
---

v2:
  - Include board details in the commit message.  
  - Sort newly added PHY configs in defconfig.

---
 arch/arm64/configs/defconfig | 3 +++
 1 file changed, 3 insertions(+)

Comments

Nícolas F. R. A. Prado March 12, 2025, 2:25 p.m. UTC | #1
On Wed, Mar 12, 2025 at 09:49:26AM +0530, Vignesh Raman wrote:
> The mediatek display driver fails to probe on mt8173-elm-hana and
> mt8183-kukui-jacuzzi-juniper-sku16 in v6.14-rc4 due to missing PHY
> configurations.
> 
> Enable the following PHY drivers for MediaTek platforms:
> - CONFIG_PHY_MTK_HDMI=m for HDMI display
> - CONFIG_PHY_MTK_MIPI_DSI=m for DSI display
> - CONFIG_PHY_MTK_XSPHY=m for USB
> 
> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>
> ---
> 
> v2:
>   - Include board details in the commit message.  
>   - Sort newly added PHY configs in defconfig.
> 
> ---
>  arch/arm64/configs/defconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 1f25423de383..87e8cbd3fd26 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -1572,7 +1572,10 @@ CONFIG_PHY_HI6220_USB=y
>  CONFIG_PHY_HISTB_COMBPHY=y
>  CONFIG_PHY_HISI_INNO_USB2=y
>  CONFIG_PHY_MVEBU_CP110_COMPHY=y
> +CONFIG_PHY_MTK_HDMI=m
> +CONFIG_PHY_MTK_MIPI_DSI=m

This isn't the expected ordering. I imagine you manually added these configs in
the defconfig.

To get the right ordering, after you've added the configs anywhere in this
defconfig, do a 'make defconfig', then a 'make savedefconfig', and copy the
generated 'defconfig' file at the root to this location, then you can add just
this hunk to the commit, and it'll be in the correct order.

Thanks,
Nícolas
Vignesh Raman March 13, 2025, 3:34 a.m. UTC | #2
Hi Nícolas,

On 12/03/25 19:55, Nícolas F. R. A. Prado wrote:
> On Wed, Mar 12, 2025 at 09:49:26AM +0530, Vignesh Raman wrote:
>> The mediatek display driver fails to probe on mt8173-elm-hana and
>> mt8183-kukui-jacuzzi-juniper-sku16 in v6.14-rc4 due to missing PHY
>> configurations.
>>
>> Enable the following PHY drivers for MediaTek platforms:
>> - CONFIG_PHY_MTK_HDMI=m for HDMI display
>> - CONFIG_PHY_MTK_MIPI_DSI=m for DSI display
>> - CONFIG_PHY_MTK_XSPHY=m for USB
>>
>> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>
>> ---
>>
>> v2:
>>    - Include board details in the commit message.
>>    - Sort newly added PHY configs in defconfig.
>>
>> ---
>>   arch/arm64/configs/defconfig | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>> index 1f25423de383..87e8cbd3fd26 100644
>> --- a/arch/arm64/configs/defconfig
>> +++ b/arch/arm64/configs/defconfig
>> @@ -1572,7 +1572,10 @@ CONFIG_PHY_HI6220_USB=y
>>   CONFIG_PHY_HISTB_COMBPHY=y
>>   CONFIG_PHY_HISI_INNO_USB2=y
>>   CONFIG_PHY_MVEBU_CP110_COMPHY=y
>> +CONFIG_PHY_MTK_HDMI=m
>> +CONFIG_PHY_MTK_MIPI_DSI=m
> 
> This isn't the expected ordering. I imagine you manually added these configs in
> the defconfig.

Yes, I added them manually.

> 
> To get the right ordering, after you've added the configs anywhere in this
> defconfig, do a 'make defconfig', then a 'make savedefconfig', and copy the
> generated 'defconfig' file at the root to this location, then you can add just
> this hunk to the commit, and it'll be in the correct order.

Thanks for the explanation. I will follow this approach.

Regards,
Vignesh

> 
> Thanks,
> Nícolas
diff mbox series

Patch

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 1f25423de383..87e8cbd3fd26 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1572,7 +1572,10 @@  CONFIG_PHY_HI6220_USB=y
 CONFIG_PHY_HISTB_COMBPHY=y
 CONFIG_PHY_HISI_INNO_USB2=y
 CONFIG_PHY_MVEBU_CP110_COMPHY=y
+CONFIG_PHY_MTK_HDMI=m
+CONFIG_PHY_MTK_MIPI_DSI=m
 CONFIG_PHY_MTK_TPHY=y
+CONFIG_PHY_MTK_XSPHY=m
 CONFIG_PHY_QCOM_EDP=m
 CONFIG_PHY_QCOM_PCIE2=m
 CONFIG_PHY_QCOM_QMP=m