From patchwork Fri May 25 05:40:04 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 10426371 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A693960327 for ; Fri, 25 May 2018 05:44:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 964E2295B3 for ; Fri, 25 May 2018 05:44:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 89251295B7; Fri, 25 May 2018 05:44:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 198B1295B3 for ; Fri, 25 May 2018 05:44:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=yk1xmOAFFVDCZrnNIijnAGfYiI//KNVmDis8xnMC99o=; b=EQEvvkkBnh5Ou0DcAnHaE7aQs4 h2j0orv5DwWXfdizXnMY2FjmAuyEGruU7zufSE/zHtGG53sZj0F0fixoGaWi36ozzPMzbG4ri1MXP BeV/bO0XZN0lTRw3lNVe2XP1wzFXZHg3YDZlVjkKK6+ii8d5LgE967jOqgSJVkgFz+P/QudqN+sQE aI8Umj9YWcDE5Jl5qZsOkH8Khi/Vvi0YA3XysiugAgX/384cXin2VnlZSOtgiKO6omrWIwaJVfX7i tozQutIeShXx7Gbx75e04RswO7C3X9Ie77eO2j/x5mBZXKgBTSpvRBJ77r889J+WXwjrI9CqTSvo2 Es2c+Jsg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fM5WL-0000bX-5W for patchwork-linux-mediatek@patchwork.kernel.org; Fri, 25 May 2018 05:44:09 +0000 Received: from mail-pl0-x244.google.com ([2607:f8b0:400e:c01::244]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fM5TA-0007FQ-7e for linux-mediatek@lists.infradead.org; Fri, 25 May 2018 05:41:11 +0000 Received: by mail-pl0-x244.google.com with SMTP id n10-v6so2465839plp.0 for ; Thu, 24 May 2018 22:40:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=0R4yxojOPc8DMkNP+2+XwqTUa9Wws43ZzgN5jtGILvc=; b=d/zmHH+JWhIDThSRy/cZ01hDHm5bv44LmAxGmS6gnOHSOUzJo1V2KDlPL+zj6NcreG 24bLrxc9fXqrDLbUM3thwFqOAmsRHOVrL9rHXUnBPt2HkjXTS2TjLtX/bY3/QwB43IQk Zz7asRRPp/5TUJ/trxOjyDG5eKKV2mTRwFUFc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=0R4yxojOPc8DMkNP+2+XwqTUa9Wws43ZzgN5jtGILvc=; b=NNA5Kb2qRF6cvOQq296q7igsLNy/zHm/V8R/tsZzCzX4IKqLpyVKVhPkAf0CsETwAc GllVmmo6tlNC2RONhw/peZTTlVHgKE6IDgSP+7v3hFxCGlCMt3amzjxG+/cIw0AO7Qfj G4+ARjeGHNGSlv9gQfBXwyxXJxch/ZvlbXtR57isHyDC5iOaCx72FdYURSoOQw06riXN pWmIbt+5qObI7U/x4DtyGMPQJw42zUv9qWiO1W75xV1bZ1HwV3fH5Cyh9dCkUGTB7YOr qcTeZXs0mkxwU960w3+jMU4i58M4LnC90hHS/kYQJoluz3dV0NEeraujIiQtxaAT3xG8 3PLQ== X-Gm-Message-State: ALKqPwfThqJFwRBDIakQ0qqiFQg4tc2Xldainh1c9RcSAv7SeHjUvV0H Y2Zn1UsIDJwiS2qIBxGRiByHFA== X-Google-Smtp-Source: AB8JxZoSP6rImsMhyfLPu5Xqwj67+tfYu3iSa15W0cfqWblqEaDdplaOK73Ejw3UfR3sGneABlU9bg== X-Received: by 2002:a17:902:d20c:: with SMTP id t12-v6mr1115186ply.364.1527226841306; Thu, 24 May 2018 22:40:41 -0700 (PDT) Received: from localhost ([122.172.112.176]) by smtp.gmail.com with ESMTPSA id p6-v6sm43193894pfg.157.2018.05.24.22.40.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 May 2018 22:40:40 -0700 (PDT) From: Viresh Kumar To: arm@kernel.org, Matthias Brugger , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon Subject: [PATCH 4/6] arm64: dts: mediatek: Add missing cooling device properties for CPUs Date: Fri, 25 May 2018 11:10:04 +0530 Message-Id: <49b1086c104b0ee22f6e992a0abb380de9320c09.1527225682.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.15.0.194.g9af6a3dea062 In-Reply-To: References: In-Reply-To: References: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180524_224052_329913_8C34EE78 X-CRM114-Status: GOOD ( 12.75 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Vincent Guittot , Viresh Kumar , Daniel Lezcano , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, chris.redpath@arm.com, ionela.voinescu@arm.com, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+patchwork-linux-mediatek=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The cooling device properties, like "#cooling-cells" and "dynamic-power-coefficient", should either be present for all the CPUs of a cluster or none. If these are present only for a subset of CPUs of a cluster then things will start falling apart as soon as the CPUs are brought online in a different order. For example, this will happen because the operating system looks for such properties in the CPU node it is trying to bring up, so that it can register a cooling device. Add such missing properties. Signed-off-by: Viresh Kumar --- arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 + arch/arm64/boot/dts/mediatek/mt8173.dtsi | 2 ++ 2 files changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi index 9213c966c224..d49fe125e770 100644 --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi @@ -89,6 +89,7 @@ <&apmixedsys CLK_APMIXED_MAIN_CORE_EN>; clock-names = "cpu", "intermediate"; operating-points-v2 = <&cpu_opp_table>; + #cooling-cells = <2>; enable-method = "psci"; clock-frequency = <1300000000>; }; diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index 94597e33c806..abd2f15a544b 100644 --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi @@ -168,6 +168,7 @@ reg = <0x001>; enable-method = "psci"; cpu-idle-states = <&CPU_SLEEP_0>; + #cooling-cells = <2>; clocks = <&infracfg CLK_INFRA_CA53SEL>, <&apmixedsys CLK_APMIXED_MAINPLL>; clock-names = "cpu", "intermediate"; @@ -193,6 +194,7 @@ reg = <0x101>; enable-method = "psci"; cpu-idle-states = <&CPU_SLEEP_0>; + #cooling-cells = <2>; clocks = <&infracfg CLK_INFRA_CA57SEL>, <&apmixedsys CLK_APMIXED_MAINPLL>; clock-names = "cpu", "intermediate";