| Message ID | Y1GnFEjOWpplFjqI@makrotopia.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | clk: mediatek: fix dependency of MT7986 ADC clocks | expand |
Il 20/10/22 21:52, Daniel Golle ha scritto: > It seems like CLK_INFRA_ADC_FRC_CK always need to be enabled for > CLK_INFRA_ADC_26M_CK to work. Instead of adding this dependency to the > mtk-thermal and mt6577_auxadc drivers, add dependency to the clock > driver clk-mt7986-infracfg.c. > > Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Signed-off-by: Daniel Golle <daniel@makrotopia.org> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Il 20/10/22 21:52, Daniel Golle ha scritto: > It seems like CLK_INFRA_ADC_FRC_CK always need to be enabled for > CLK_INFRA_ADC_26M_CK to work. Instead of adding this dependency to the > mtk-thermal and mt6577_auxadc drivers, add dependency to the clock > driver clk-mt7986-infracfg.c. > > Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Signed-off-by: Daniel Golle <daniel@makrotopia.org> Sorry, I gave you my Reviewed-by tag, but I've just realized that you're missing a Fixes tag. Please send a v2 with: Fixes: ec97d23c8e22 ("clk: mediatek: add mt7986 clock support") ...and retain my reviewed-by tag after that. Cheers, Angelo
diff --git a/drivers/clk/mediatek/clk-mt7986-infracfg.c b/drivers/clk/mediatek/clk-mt7986-infracfg.c index d90727a53283c7..49666047bf0ed5 100644 --- a/drivers/clk/mediatek/clk-mt7986-infracfg.c +++ b/drivers/clk/mediatek/clk-mt7986-infracfg.c @@ -153,7 +153,7 @@ static const struct mtk_gate infra_clks[] = { 18), GATE_INFRA1(CLK_INFRA_MSDC_66M_CK, "infra_msdc_66m", "infra_sysaxi_d2", 19), - GATE_INFRA1(CLK_INFRA_ADC_26M_CK, "infra_adc_26m", "csw_f26m_sel", 20), + GATE_INFRA1(CLK_INFRA_ADC_26M_CK, "infra_adc_26m", "infra_adc_frc", 20), GATE_INFRA1(CLK_INFRA_ADC_FRC_CK, "infra_adc_frc", "csw_f26m_sel", 21), GATE_INFRA1(CLK_INFRA_FBIST2FPC_CK, "infra_fbist2fpc", "nfi1x_sel", 23), /* INFRA2 */
It seems like CLK_INFRA_ADC_FRC_CK always need to be enabled for CLK_INFRA_ADC_26M_CK to work. Instead of adding this dependency to the mtk-thermal and mt6577_auxadc drivers, add dependency to the clock driver clk-mt7986-infracfg.c. Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Signed-off-by: Daniel Golle <daniel@makrotopia.org> --- drivers/clk/mediatek/clk-mt7986-infracfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)