mbox series

[0/2] optee: fix OOM seen due to tee_shm_free()

Message ID 20210217092714.121297-1-allen.lkml@gmail.com (mailing list archive)
Headers show
Series optee: fix OOM seen due to tee_shm_free() | expand

Message

Allen Feb. 17, 2021, 9:27 a.m. UTC
From: Allen Pais <apais@linux.microsoft.com>

The following out of memory errors are seen on kexec reboot
from the optee core.
    
[    0.368428] tee_bnxt_fw optee-clnt0: tee_shm_alloc failed
[    0.368461] tee_bnxt_fw: probe of optee-clnt0 failed with error -22
    
tee_shm_release() is not invoked on dma shm buffer.
    
Implement .shutdown() in optee core as well as bnxt firmware driver
to handle the release of the buffers correctly.
    
More info:
https://github.com/OP-TEE/optee_os/issues/3637

Allen Pais (2):
  optee: fix tee out of memory failure seen during kexec reboot
  firmware: tee_bnxt: implement shutdown method to handle kexec reboots

 drivers/firmware/broadcom/tee_bnxt_fw.c |  9 ++++
 drivers/tee/optee/core.c                | 69 ++++++++++++++++++-------
 2 files changed, 58 insertions(+), 20 deletions(-)

Comments

Dhananjay Phadke Feb. 18, 2021, 6:12 p.m. UTC | #1
From: Allen Pais <apais@linux.microsoft.com>

On Wed, 17 Feb 2021 14:57:12 +0530, Allen Pais wrote:
> The following out of memory errors are seen on kexec reboot
> from the optee core.
>     
> [    0.368428] tee_bnxt_fw optee-clnt0: tee_shm_alloc failed
> [    0.368461] tee_bnxt_fw: probe of optee-clnt0 failed with error -22
>     
> tee_shm_release() is not invoked on dma shm buffer.
>     
> Implement .shutdown() in optee core as well as bnxt firmware driver
> to handle the release of the buffers correctly.
>     
> More info:
> https://github.com/OP-TEE/optee_os/issues/3637

CC: linux-kernel@vger.kernel.org instead of linux-mips?
TEE / TrustZone is ARM.

Also, for Broadcom specific -
CC: bcm-kernel-feedback-list@broadcom.com
Allen Pais Feb. 23, 2021, 6:17 a.m. UTC | #2
> 
> The following out of memory errors are seen on kexec reboot
> from the optee core.
>      
> [    0.368428] tee_bnxt_fw optee-clnt0: tee_shm_alloc failed
> [    0.368461] tee_bnxt_fw: probe of optee-clnt0 failed with error -22
>      
> tee_shm_release() is not invoked on dma shm buffer.
>      
> Implement .shutdown() in optee core as well as bnxt firmware driver
> to handle the release of the buffers correctly.
>      
> More info:
> https://github.com/OP-TEE/optee_os/issues/3637

Jens,

   Could you please take sometime out and review the series.

Thanks.

> 
> Allen Pais (2):
>    optee: fix tee out of memory failure seen during kexec reboot
>    firmware: tee_bnxt: implement shutdown method to handle kexec reboots
> 
>   drivers/firmware/broadcom/tee_bnxt_fw.c |  9 ++++
>   drivers/tee/optee/core.c                | 69 ++++++++++++++++++-------
>   2 files changed, 58 insertions(+), 20 deletions(-)
>