[0/2] mmc: ingenic: Support bi-directional DMA channel

Message

Paul Cercueil Dec. 20, 2021, 7:08 p.m. UTC

Hi Ulf,

This patchset adds support for using a single DMA channel for both RX
and TX operations, instead of using separate DMA channels for each
operation.

As some older Ingenic SoCs offer only a handful of DMA channels,
supporting bi-directional channels allow more hardware to use the
channels that would otherwise be used for the MMC/SD operation.

Note that the Device Tree binding for the DMA controller has been
updated in a (already merged) patchset, so that it accepts a 3 cells
(#dma-cells == 3) instead of just 2. It was merged in the DMA tree, so I
am not sure the autobuilders will like this YAML - but it was checked
without errors.

I also removed the descriptions of the "dmas" property in the YAML, as
they really weren't adding anything and were getting in my way.

There are patches touching the driver file merged in the PM tree (the
ones that use the new PM macros) but I expect no problem here, they
touch different parts of the file.

Cheers,
-Paul

Paul Cercueil (2):
  dt-bindings: mmc: ingenic: Support using bi-directional DMA channel
  mmc: jz4740: Support using a bi-directional DMA channel

 .../devicetree/bindings/mmc/ingenic,mmc.yaml  | 37 ++++++++++++++++---
 drivers/mmc/host/jz4740_mmc.c                 | 19 +++++++++-
 2 files changed, 48 insertions(+), 8 deletions(-)

Comments

Ulf Hansson Dec. 21, 2021, 1:03 p.m. UTC | #1

On Mon, 20 Dec 2021 at 20:08, Paul Cercueil <[e-mail]> wrote:
>
> Hi Ulf,
>
> This patchset adds support for using a single DMA channel for both RX
> and TX operations, instead of using separate DMA channels for each
> operation.
>
> As some older Ingenic SoCs offer only a handful of DMA channels,
> supporting bi-directional channels allow more hardware to use the
> channels that would otherwise be used for the MMC/SD operation.
>
> Note that the Device Tree binding for the DMA controller has been
> updated in a (already merged) patchset, so that it accepts a 3 cells
> (#dma-cells == 3) instead of just 2. It was merged in the DMA tree, so I
> am not sure the autobuilders will like this YAML - but it was checked
> without errors.
>
> I also removed the descriptions of the "dmas" property in the YAML, as
> they really weren't adding anything and were getting in my way.
>
> There are patches touching the driver file merged in the PM tree (the
> ones that use the new PM macros) but I expect no problem here, they
> touch different parts of the file.
>
> Cheers,
> -Paul
>
> Paul Cercueil (2):
>   dt-bindings: mmc: ingenic: Support using bi-directional DMA channel
>   mmc: jz4740: Support using a bi-directional DMA channel
>
>  .../devicetree/bindings/mmc/ingenic,mmc.yaml  | 37 ++++++++++++++++---
>  drivers/mmc/host/jz4740_mmc.c                 | 19 +++++++++-
>  2 files changed, 48 insertions(+), 8 deletions(-)
>

Applied for next, thanks!

Let's see how this goes when the changes hit linux-next. I will have
to drop them, if we encounter any problems.

Kind regards
Uffe