mbox series

[v5,0/9] ASoC: cleanups and improvements for jz4740-i2s

Message ID 20221022191308.82348-1-aidanmacdonald.0x0@gmail.com (mailing list archive)
Headers show
Series ASoC: cleanups and improvements for jz4740-i2s | expand

Message

Aidan MacDonald Oct. 22, 2022, 7:12 p.m. UTC
This series is a preparatory cleanup of the jz4740-i2s driver before
adding support for a new SoC. The two improvements are lifting
unnecessary restrictions on sample rates and formats -- the existing
ones appear to be derived from the limitations of the JZ4740's internal
codec and don't reflect the actual capabilities of the I2S controller.

I'm unable to test the series on any JZ47xx SoCs, but I have tested
on an X1000 (which is the SoC I'll be adding in a followup series).

Changes in v5:

* Drop 'mem' resource removal patch already upstream.
* Update FIFO flush bits fix to address Paul's review comments.
* Drop PLL clock name patch, that needs a different approach.

Link for v4: URLHERE

Aidan MacDonald (9):
  ASoC: jz4740-i2s: Handle independent FIFO flush bits
  ASoC: jz4740-i2s: Convert to regmap API
  ASoC: jz4740-i2s: Simplify using regmap fields
  ASoC: jz4740-i2s: Use FIELD_PREP() macros in hw_params callback
  ASoC: jz4740-i2s: Align macro values and sort includes
  ASoC: jz4740-i2s: Support S20_LE and S24_LE sample formats
  ASoC: jz4740-i2s: Support continuous sample rate
  ASoC: jz4740-i2s: Move component functions near the component driver
  ASoC: jz4740-i2s: Refactor DAI probe/remove ops as component ops

 sound/soc/jz4740/Kconfig      |   1 +
 sound/soc/jz4740/jz4740-i2s.c | 455 ++++++++++++++++++----------------
 2 files changed, 243 insertions(+), 213 deletions(-)

Comments

Paul Cercueil Oct. 22, 2022, 7:44 p.m. UTC | #1
Hi Aidan,

Le sam. 22 oct. 2022 à 20:12:59 +0100, Aidan MacDonald 
<aidanmacdonald.0x0@gmail.com> a écrit :
> This series is a preparatory cleanup of the jz4740-i2s driver before
> adding support for a new SoC. The two improvements are lifting
> unnecessary restrictions on sample rates and formats -- the existing
> ones appear to be derived from the limitations of the JZ4740's 
> internal
> codec and don't reflect the actual capabilities of the I2S controller.
> 
> I'm unable to test the series on any JZ47xx SoCs, but I have tested
> on an X1000 (which is the SoC I'll be adding in a followup series).
> 
> Changes in v5:
> 
> * Drop 'mem' resource removal patch already upstream.
> * Update FIFO flush bits fix to address Paul's review comments.
> * Drop PLL clock name patch, that needs a different approach.
> 
> Link for v4: URLHERE

Forgot something? ;)

-Paul

> 
> Aidan MacDonald (9):
>   ASoC: jz4740-i2s: Handle independent FIFO flush bits
>   ASoC: jz4740-i2s: Convert to regmap API
>   ASoC: jz4740-i2s: Simplify using regmap fields
>   ASoC: jz4740-i2s: Use FIELD_PREP() macros in hw_params callback
>   ASoC: jz4740-i2s: Align macro values and sort includes
>   ASoC: jz4740-i2s: Support S20_LE and S24_LE sample formats
>   ASoC: jz4740-i2s: Support continuous sample rate
>   ASoC: jz4740-i2s: Move component functions near the component driver
>   ASoC: jz4740-i2s: Refactor DAI probe/remove ops as component ops
> 
>  sound/soc/jz4740/Kconfig      |   1 +
>  sound/soc/jz4740/jz4740-i2s.c | 455 
> ++++++++++++++++++----------------
>  2 files changed, 243 insertions(+), 213 deletions(-)
> 
> --
> 2.38.1
>
Aidan MacDonald Oct. 23, 2022, 1:29 p.m. UTC | #2
Paul Cercueil <paul@crapouillou.net> writes:

> Hi Aidan,
>
> Le sam. 22 oct. 2022 à 20:12:59 +0100, Aidan MacDonald
> <aidanmacdonald.0x0@gmail.com> a écrit :
>> This series is a preparatory cleanup of the jz4740-i2s driver before
>> adding support for a new SoC. The two improvements are lifting
>> unnecessary restrictions on sample rates and formats -- the existing
>> ones appear to be derived from the limitations of the JZ4740's internal
>> codec and don't reflect the actual capabilities of the I2S controller.
>> I'm unable to test the series on any JZ47xx SoCs, but I have tested
>> on an X1000 (which is the SoC I'll be adding in a followup series).
>> Changes in v5:
>> * Drop 'mem' resource removal patch already upstream.
>> * Update FIFO flush bits fix to address Paul's review comments.
>> * Drop PLL clock name patch, that needs a different approach.
>> Link for v4: URLHERE
>
> Forgot something? ;)
>
> -Paul
>

Ah, sorry, that's why you shouldn't eat dinner between format-patch
and send-patch... :)

Link to v4: https://lore.kernel.org/alsa-devel/20220708160244.21933-1-aidanmacdonald.0x0@gmail.com/

>> Aidan MacDonald (9):
>>   ASoC: jz4740-i2s: Handle independent FIFO flush bits
>>   ASoC: jz4740-i2s: Convert to regmap API
>>   ASoC: jz4740-i2s: Simplify using regmap fields
>>   ASoC: jz4740-i2s: Use FIELD_PREP() macros in hw_params callback
>>   ASoC: jz4740-i2s: Align macro values and sort includes
>>   ASoC: jz4740-i2s: Support S20_LE and S24_LE sample formats
>>   ASoC: jz4740-i2s: Support continuous sample rate
>>   ASoC: jz4740-i2s: Move component functions near the component driver
>>   ASoC: jz4740-i2s: Refactor DAI probe/remove ops as component ops
>>  sound/soc/jz4740/Kconfig      |   1 +
>>  sound/soc/jz4740/jz4740-i2s.c | 455 ++++++++++++++++++----------------
>>  2 files changed, 243 insertions(+), 213 deletions(-)
>> --
>> 2.38.1
>>