| Message ID | 20230612-6-1-asssembler-target-llvm-17-v1-0-75605d553401@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Update as-{instr,option} to use KBUILD_AFLAGS | expand |
On Wed, Jun 14, 2023 at 11:04:34AM -0700, Nathan Chancellor wrote: > Hi all, > > This series backports commit d5c8d6e0fa61 ("kbuild: Update assembler > calls to use proper flags and language target") to linux-6.1.y to > address a recent issue caused by a change in behavior in clang: > > https://lore.kernel.org/CA+G9fYsJq0sPC+q6vLNKUgBqCGmmjDrfeP4R1-95Eu28FJRY_A@mail.gmail.com/ > https://lore.kernel.org/20230612185424.GA2891387@dev-arch.thelio-3990X/ > > While that was not the original intention of the aforementioned change, > it ends up resolving the issue for the same reason, by not passing flags > that are not supported or necessary for the current language target > (KBUILD_CFLAGS for .c files and KBUILD_AFLAGS for .S files) when testing > flags for that language target. > > All patches except the second one are direct backports from mainline. > The second patch is a stable specific patch because the upstream > solution could break stable due to the minimum supported version of > binutils in mainline being a newer version than 6.1 and earlier; it > chooses to do the more conservative fix, which was alluded to in the > changelog of the upstream commit. > > For now, this is just a 6.1 issue. If the issue occurs in older > releases, I will send separate backports. If there are any issues or > objections to this series, please let me know. All now queued up, thanks. greg k-h
Hi all, This series backports commit d5c8d6e0fa61 ("kbuild: Update assembler calls to use proper flags and language target") to linux-6.1.y to address a recent issue caused by a change in behavior in clang: https://lore.kernel.org/CA+G9fYsJq0sPC+q6vLNKUgBqCGmmjDrfeP4R1-95Eu28FJRY_A@mail.gmail.com/ https://lore.kernel.org/20230612185424.GA2891387@dev-arch.thelio-3990X/ While that was not the original intention of the aforementioned change, it ends up resolving the issue for the same reason, by not passing flags that are not supported or necessary for the current language target (KBUILD_CFLAGS for .c files and KBUILD_AFLAGS for .S files) when testing flags for that language target. All patches except the second one are direct backports from mainline. The second patch is a stable specific patch because the upstream solution could break stable due to the minimum supported version of binutils in mainline being a newer version than 6.1 and earlier; it chooses to do the more conservative fix, which was alluded to in the changelog of the upstream commit. For now, this is just a 6.1 issue. If the issue occurs in older releases, I will send separate backports. If there are any issues or objections to this series, please let me know. Cheers, Nathan --- Nathan Chancellor (2): MIPS: Move '-Wa,-msoft-float' check from as-option to cc-option MIPS: Prefer cc-option for additions to cflags Nick Desaulniers (2): x86/boot/compressed: prefer cc-option for CFLAGS additions kbuild: Update assembler calls to use proper flags and language target arch/mips/Makefile | 4 ++-- arch/mips/loongson2ef/Platform | 2 +- arch/x86/boot/compressed/Makefile | 2 +- scripts/Kconfig.include | 2 +- scripts/Makefile.compiler | 8 ++++---- scripts/as-version.sh | 2 +- 6 files changed, 10 insertions(+), 10 deletions(-) --- base-commit: ca87e77a2ef8b298aa9f69658d5898e72ee450fe change-id: 20230612-6-1-asssembler-target-llvm-17-3f8101fc008f Best regards,