| Message ID | 20250111-loongson64-boardinfo-no-size-v1-0-e9f26fcd069e@aosc.io (mailing list archive) |
|---|---|
| Headers | show |
| Series | MIPS: Loongson64: Remove ROM Size in LEFI boardinfo | expand |
在2025年1月10日一月 下午5:22，Kexy Biscuit写道： > In "MIPS: Loongson64: Add /sys/firmware/lefi/boardinfo", "ROM Size" was > added under section "BIOS Info". However, that is incorrect per Appendix > A.7 in Q/LS 0013-2014 (龙芯CPU开发系统固件与内核接口规范 V2.2, > lit. Loongson DevSys Firmware Kernel Interface Specification V2.2), > which defines the size to be the size of this interface itself. > > Removing "ROM Size" from boardinfo, and also adding comments to the > struct interface_info to clarify meanings of its members. > > Signed-off-by: Kexy Biscuit <kexybiscuit@aosc.io> For the series: Acked-by: Jiaxun Yang <jiaxun.yang@flygoat.com> Good catch, thanks! > --- > Kexy Biscuit (2): > MIPS: Loongson64: remove ROM Size unit in boardinfo > MIPS: Loongson: Add comments for interface_info > > arch/mips/include/asm/mach-loongson64/boot_param.h | 8 ++++---- > arch/mips/loongson64/boardinfo.c | 2 -- > 2 files changed, 4 insertions(+), 6 deletions(-) > --- > base-commit: 2144da25584eb10b84252230319b5783f6a83041 > change-id: 20250111-loongson64-boardinfo-no-size-a25dd2a03a8b > > Best regards, > -- > Kexy Biscuit <kexybiscuit@aosc.io>
On Sat, Jan 11, 2025 at 01:22:07AM +0800, Kexy Biscuit wrote: > In "MIPS: Loongson64: Add /sys/firmware/lefi/boardinfo", "ROM Size" was > added under section "BIOS Info". However, that is incorrect per Appendix > A.7 in Q/LS 0013-2014 (龙芯CPU开发系统固件与内核接口规范 V2.2, > lit. Loongson DevSys Firmware Kernel Interface Specification V2.2), > which defines the size to be the size of this interface itself. > > Removing "ROM Size" from boardinfo, and also adding comments to the > struct interface_info to clarify meanings of its members. > > Signed-off-by: Kexy Biscuit <kexybiscuit@aosc.io> > --- > Kexy Biscuit (2): > MIPS: Loongson64: remove ROM Size unit in boardinfo > MIPS: Loongson: Add comments for interface_info > > arch/mips/include/asm/mach-loongson64/boot_param.h | 8 ++++---- > arch/mips/loongson64/boardinfo.c | 2 -- > 2 files changed, 4 insertions(+), 6 deletions(-) > --- > base-commit: 2144da25584eb10b84252230319b5783f6a83041 > change-id: 20250111-loongson64-boardinfo-no-size-a25dd2a03a8b series applied to mips-next. Thomas.
In "MIPS: Loongson64: Add /sys/firmware/lefi/boardinfo", "ROM Size" was added under section "BIOS Info". However, that is incorrect per Appendix A.7 in Q/LS 0013-2014 (龙芯CPU开发系统固件与内核接口规范 V2.2, lit. Loongson DevSys Firmware Kernel Interface Specification V2.2), which defines the size to be the size of this interface itself. Removing "ROM Size" from boardinfo, and also adding comments to the struct interface_info to clarify meanings of its members. Signed-off-by: Kexy Biscuit <kexybiscuit@aosc.io> --- Kexy Biscuit (2): MIPS: Loongson64: remove ROM Size unit in boardinfo MIPS: Loongson: Add comments for interface_info arch/mips/include/asm/mach-loongson64/boot_param.h | 8 ++++---- arch/mips/loongson64/boardinfo.c | 2 -- 2 files changed, 4 insertions(+), 6 deletions(-) --- base-commit: 2144da25584eb10b84252230319b5783f6a83041 change-id: 20250111-loongson64-boardinfo-no-size-a25dd2a03a8b Best regards,