mbox series

[mips-next,0/3] MIPS: fix the two most annoying sparse floods

Message ID OXAnLrccR2GxIpepN5IUjppNnjyVAnjQmCIx2RmgpMLsOzOBgXMKYvmjivy4Rq0bAVf11R5V9_FwfGx-MML3dShuOOoPUtAHUHUedlVrW_g=@pm.me (mailing list archive)
Headers show
Series MIPS: fix the two most annoying sparse floods | expand

Message

Alexander Lobakin June 20, 2020, 9:33 a.m. UTC
This set addresses the two most annoying sparse floods when building the
tree with C={1,2}: one in asm/io.h (in several mangle-port.h actually),
and one in asm/checksum.h.
Both of these comes from lack of forced typecasting and hence harmless,
but complicates real bug hunting, as asm/io.h is included in almost
every driver, while asm/checksum.h is included in lots of networking
code.

I also fixed two wrong __mem_ioswabq() macros while was nearby.
Tested on Generic MIPS platform -- no more flooding in console (there's
one more source in mips-cm.h, but it's included in just a few files, so
not a real problem. It can be issued separately anyway), while objdump
doesn't see any difference at all.

Alexander Lobakin (3):
  MIPS: generic/ip32: io: fix __mem_ioswabq()
  MIPS: io: fix sparse flood on asm/io.h
  MIPS: checksum: fix sparse flooding on asm/checksum.h

 arch/mips/include/asm/checksum.h                     |  4 ++--
 .../include/asm/mach-cavium-octeon/mangle-port.h     | 12 +++++++++---
 arch/mips/include/asm/mach-generic/mangle-port.h     | 12 ++++++------
 arch/mips/include/asm/mach-ip27/mangle-port.h        |  6 +++---
 arch/mips/include/asm/mach-ip30/mangle-port.h        |  6 +++---
 arch/mips/include/asm/mach-ip32/mangle-port.h        |  6 +++---
 arch/mips/include/asm/mach-tx39xx/mangle-port.h      |  6 +++---
 arch/mips/include/asm/mach-tx49xx/mangle-port.h      |  6 +++---
 8 files changed, 32 insertions(+), 26 deletions(-)

Comments

Thomas Bogendoerfer June 25, 2020, 9:40 a.m. UTC | #1
On Sat, Jun 20, 2020 at 09:33:38AM +0000, Alexander Lobakin wrote:
> This set addresses the two most annoying sparse floods when building the
> tree with C={1,2}: one in asm/io.h (in several mangle-port.h actually),
> and one in asm/checksum.h.
> Both of these comes from lack of forced typecasting and hence harmless,
> but complicates real bug hunting, as asm/io.h is included in almost
> every driver, while asm/checksum.h is included in lots of networking
> code.
> 
> I also fixed two wrong __mem_ioswabq() macros while was nearby.
> Tested on Generic MIPS platform -- no more flooding in console (there's
> one more source in mips-cm.h, but it's included in just a few files, so
> not a real problem. It can be issued separately anyway), while objdump
> doesn't see any difference at all.
> 
> Alexander Lobakin (3):
>   MIPS: generic/ip32: io: fix __mem_ioswabq()
>   MIPS: io: fix sparse flood on asm/io.h
>   MIPS: checksum: fix sparse flooding on asm/checksum.h
> 
>  arch/mips/include/asm/checksum.h                     |  4 ++--
>  .../include/asm/mach-cavium-octeon/mangle-port.h     | 12 +++++++++---
>  arch/mips/include/asm/mach-generic/mangle-port.h     | 12 ++++++------
>  arch/mips/include/asm/mach-ip27/mangle-port.h        |  6 +++---
>  arch/mips/include/asm/mach-ip30/mangle-port.h        |  6 +++---
>  arch/mips/include/asm/mach-ip32/mangle-port.h        |  6 +++---
>  arch/mips/include/asm/mach-tx39xx/mangle-port.h      |  6 +++---
>  arch/mips/include/asm/mach-tx49xx/mangle-port.h      |  6 +++---
>  8 files changed, 32 insertions(+), 26 deletions(-)

series applied to mips-next.

Thomas.