| Message ID | 1548667176-119830-2-git-send-email-zhouyanjie@zoho.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/2] Serial: Ingenic: Add support for the X1000. | expand |
On Mon, Jan 28, 2019 at 05:19:35PM +0800, Zhou Yanjie wrote: > Add support for probing the 8250_ingenic driver on the > X1000 Soc from Ingenic. > > Signed-off-by: Zhou Yanjie <zhouyanjie@zoho.com> > --- > drivers/tty/serial/8250/8250_ingenic.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) You sent two different patches with the same subject: line, yet they did totally different things. Please fix this up and resend with a better set of subject lines. thanks, greg k-h
Hi Zhou, On Mon, Jan 28, 2019 at 10:23 AM Zhou Yanjie <zhouyanjie@zoho.com> wrote: > Add support for probing the 8250_ingenic driver on the > X1000 Soc from Ingenic. > > Signed-off-by: Zhou Yanjie <zhouyanjie@zoho.com> Thanks for your patch! > --- a/drivers/tty/serial/8250/8250_ingenic.c > +++ b/drivers/tty/serial/8250/8250_ingenic.c > @@ -145,6 +145,10 @@ EARLYCON_DECLARE(jz4780_uart, ingenic_early_console_setup); > OF_EARLYCON_DECLARE(jz4780_uart, "ingenic,jz4780-uart", > ingenic_early_console_setup); > > +EARLYCON_DECLARE(x1000_uart, ingenic_early_console_setup); > +OF_EARLYCON_DECLARE(x1000_uart, "ingenic,x1000-uart", > + ingenic_early_console_setup); As of commit 2eaa790989e03900 ("earlycon: Use common framework for earlycon declarations") it is no longer needer to specify both EARLYCON_DECLARE() and OF_EARLYCON_DECLARE(). Gr{oetje,eeting}s, Geert
My fault, I will fix these in v2. On 2019年01月28日 17:30, Greg KH wrote: > On Mon, Jan 28, 2019 at 05:19:35PM +0800, Zhou Yanjie wrote: >> Add support for probing the 8250_ingenic driver on the >> X1000 Soc from Ingenic. >> >> Signed-off-by: Zhou Yanjie <zhouyanjie@zoho.com> >> --- >> drivers/tty/serial/8250/8250_ingenic.c | 10 ++++++++++ >> 1 file changed, 10 insertions(+) > You sent two different patches with the same subject: line, yet they did > totally different things. > > Please fix this up and resend with a better set of subject lines. > > thanks, > > greg k-h
diff --git a/drivers/tty/serial/8250/8250_ingenic.c b/drivers/tty/serial/8250/8250_ingenic.c index 15a8c8d..1999e3b 100644 --- a/drivers/tty/serial/8250/8250_ingenic.c +++ b/drivers/tty/serial/8250/8250_ingenic.c @@ -145,6 +145,10 @@ EARLYCON_DECLARE(jz4780_uart, ingenic_early_console_setup); OF_EARLYCON_DECLARE(jz4780_uart, "ingenic,jz4780-uart", ingenic_early_console_setup); +EARLYCON_DECLARE(x1000_uart, ingenic_early_console_setup); +OF_EARLYCON_DECLARE(x1000_uart, "ingenic,x1000-uart", + ingenic_early_console_setup); + static void ingenic_uart_serial_out(struct uart_port *p, int offset, int value) { int ier; @@ -328,12 +332,18 @@ static const struct ingenic_uart_config jz4780_uart_config = { .fifosize = 64, }; +static const struct ingenic_uart_config x1000_uart_config = { + .tx_loadsz = 32, + .fifosize = 64, +}; + static const struct of_device_id of_match[] = { { .compatible = "ingenic,jz4740-uart", .data = &jz4740_uart_config }, { .compatible = "ingenic,jz4760-uart", .data = &jz4760_uart_config }, { .compatible = "ingenic,jz4770-uart", .data = &jz4760_uart_config }, { .compatible = "ingenic,jz4775-uart", .data = &jz4760_uart_config }, { .compatible = "ingenic,jz4780-uart", .data = &jz4780_uart_config }, + { .compatible = "ingenic,x1000-uart", .data = &x1000_uart_config }, { /* sentinel */ } }; MODULE_DEVICE_TABLE(of, of_match);
Add support for probing the 8250_ingenic driver on the X1000 Soc from Ingenic. Signed-off-by: Zhou Yanjie <zhouyanjie@zoho.com> --- drivers/tty/serial/8250/8250_ingenic.c | 10 ++++++++++ 1 file changed, 10 insertions(+)