| Message ID | 1588250184-18730-1-git-send-email-yangtiezhu@loongson.cn (mailing list archive) |
|---|---|
| State | Superseded |
| Commit | 44220fd84f3fa25208a441ae7a2cf0cf44699655 |
| Headers | show |
| Series | MIPS: tools: Show result for loongson3-llsc-check | expand |
On Thu, Apr 30, 2020 at 08:36:24PM +0800, Tiezhu Yang wrote: > It is better to show the result before loongson3-llsc-check exit, > otherwise we can see nothing if the return status is EXIT_SUCCESS, > it seems confusing. > > E.g. without this patch: > > [loongson@localhost tools]$ ./loongson3-llsc-check ../../../vmlinux > [loongson@localhost tools]$ > > With this patch: > > [loongson@localhost tools]$ ./loongson3-llsc-check ../../../vmlinux > loongson3-llsc-check returns success > [loongson@localhost tools]$ > > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> > --- > arch/mips/tools/loongson3-llsc-check.c | 2 ++ > 1 file changed, 2 insertions(+) applied to mips-next. Thomas.
Hello! On 30.04.2020 15:36, Tiezhu Yang wrote: > It is better to show the result before loongson3-llsc-check exit, > otherwise we can see nothing if the return status is EXIT_SUCCESS, > it seems confusing. > > E.g. without this patch: > > [loongson@localhost tools]$ ./loongson3-llsc-check ../../../vmlinux > [loongson@localhost tools]$ > > With this patch: > > [loongson@localhost tools]$ ./loongson3-llsc-check ../../../vmlinux > loongson3-llsc-check returns success > [loongson@localhost tools]$ > > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> > --- > arch/mips/tools/loongson3-llsc-check.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/mips/tools/loongson3-llsc-check.c b/arch/mips/tools/loongson3-llsc-check.c > index 0ebddd0..facd016 100644 > --- a/arch/mips/tools/loongson3-llsc-check.c > +++ b/arch/mips/tools/loongson3-llsc-check.c > @@ -303,5 +303,7 @@ int main(int argc, char *argv[]) > out_close: > close(vmlinux_fd); > out_ret: > + fprintf(stdout, "loongson3-llsc-check %s\n", > + status ? "returns failure" : "returns success"); Why not "loongson3-llsc-check returns %s\n"? > return status; > } > MBR, Sergei
On 05/01/2020 05:48 PM, Sergei Shtylyov wrote: > Hello! > > On 30.04.2020 15:36, Tiezhu Yang wrote: > >> It is better to show the result before loongson3-llsc-check exit, >> otherwise we can see nothing if the return status is EXIT_SUCCESS, >> it seems confusing. >> >> E.g. without this patch: >> >> [loongson@localhost tools]$ ./loongson3-llsc-check ../../../vmlinux >> [loongson@localhost tools]$ >> >> With this patch: >> >> [loongson@localhost tools]$ ./loongson3-llsc-check ../../../vmlinux >> loongson3-llsc-check returns success >> [loongson@localhost tools]$ >> >> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> >> --- >> arch/mips/tools/loongson3-llsc-check.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/mips/tools/loongson3-llsc-check.c >> b/arch/mips/tools/loongson3-llsc-check.c >> index 0ebddd0..facd016 100644 >> --- a/arch/mips/tools/loongson3-llsc-check.c >> +++ b/arch/mips/tools/loongson3-llsc-check.c >> @@ -303,5 +303,7 @@ int main(int argc, char *argv[]) >> out_close: >> close(vmlinux_fd); >> out_ret: >> + fprintf(stdout, "loongson3-llsc-check %s\n", >> + status ? "returns failure" : "returns success"); > > Why not "loongson3-llsc-check returns %s\n"? Hi Sergei, Sorry for the late reply, thanks for your review, I will send v2. Thanks, Tiezhu Yang > >> return status; >> } >> > > MBR, Sergei
diff --git a/arch/mips/tools/loongson3-llsc-check.c b/arch/mips/tools/loongson3-llsc-check.c index 0ebddd0..facd016 100644 --- a/arch/mips/tools/loongson3-llsc-check.c +++ b/arch/mips/tools/loongson3-llsc-check.c @@ -303,5 +303,7 @@ int main(int argc, char *argv[]) out_close: close(vmlinux_fd); out_ret: + fprintf(stdout, "loongson3-llsc-check %s\n", + status ? "returns failure" : "returns success"); return status; }
It is better to show the result before loongson3-llsc-check exit, otherwise we can see nothing if the return status is EXIT_SUCCESS, it seems confusing. E.g. without this patch: [loongson@localhost tools]$ ./loongson3-llsc-check ../../../vmlinux [loongson@localhost tools]$ With this patch: [loongson@localhost tools]$ ./loongson3-llsc-check ../../../vmlinux loongson3-llsc-check returns success [loongson@localhost tools]$ Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> --- arch/mips/tools/loongson3-llsc-check.c | 2 ++ 1 file changed, 2 insertions(+)