| Message ID | 1615606429-2568-1-git-send-email-wangqing@vivo.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 63d6c98168916f0c18f7bb7a28e27efd95524409 |
| Headers | show |
| Series | mips: kernel: use DEFINE_DEBUGFS_ATTRIBUTE with debugfs_create_file_unsafe() | expand |
On Sat, Mar 13, 2021 at 11:33:48AM +0800, Wang Qing wrote: > debugfs_create_file_unsafe does not protect the fops handed to it > against file removal. DEFINE_DEBUGFS_ATTRIBUTE makes the fops aware of > the file lifetime and thus protects it against removal. > > Signed-off-by: Wang Qing <wangqing@vivo.com> > --- > arch/mips/kernel/spinlock_test.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) applied to mips-next. Thomas.
diff --git a/arch/mips/kernel/spinlock_test.c b/arch/mips/kernel/spinlock_test.c index ab4e3e1..90f53e0 --- a/arch/mips/kernel/spinlock_test.c +++ b/arch/mips/kernel/spinlock_test.c @@ -35,7 +35,7 @@ static int ss_get(void *data, u64 *val) return 0; } -DEFINE_SIMPLE_ATTRIBUTE(fops_ss, ss_get, NULL, "%llu\n"); +DEFINE_DEBUGFS_ATTRIBUTE(fops_ss, ss_get, NULL, "%llu\n"); @@ -114,13 +114,13 @@ static int multi_get(void *data, u64 *val) return 0; } -DEFINE_SIMPLE_ATTRIBUTE(fops_multi, multi_get, NULL, "%llu\n"); +DEFINE_DEBUGFS_ATTRIBUTE(fops_multi, multi_get, NULL, "%llu\n"); static int __init spinlock_test(void) { - debugfs_create_file("spin_single", S_IRUGO, mips_debugfs_dir, NULL, + debugfs_create_file_unsafe("spin_single", S_IRUGO, mips_debugfs_dir, NULL, &fops_ss); - debugfs_create_file("spin_multi", S_IRUGO, mips_debugfs_dir, NULL, + debugfs_create_file_unsafe("spin_multi", S_IRUGO, mips_debugfs_dir, NULL, &fops_multi); return 0; }
debugfs_create_file_unsafe does not protect the fops handed to it against file removal. DEFINE_DEBUGFS_ATTRIBUTE makes the fops aware of the file lifetime and thus protects it against removal. Signed-off-by: Wang Qing <wangqing@vivo.com> --- arch/mips/kernel/spinlock_test.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)