diff mbox series

MIPS: VR41xx: Drop redundant spinlock initialization

Message ID 1652176527-4507-1-git-send-email-baihaowen@meizu.com (mailing list archive)
State Accepted
Commit 85663a86cdc782f6cb7090fb8bbfac00eb74d638
Headers show
Series MIPS: VR41xx: Drop redundant spinlock initialization | expand

Commit Message

baihaowen May 10, 2022, 9:55 a.m. UTC
slot_errbuf_lock has declared and initialized by DEFINE_SPINLOCK,
so we don't need to spin_lock_init again, drop it.

Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
 arch/mips/vr41xx/common/cmu.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Thomas Bogendoerfer May 12, 2022, 4:08 p.m. UTC | #1
On Tue, May 10, 2022 at 05:55:27PM +0800, Haowen Bai wrote:
> slot_errbuf_lock has declared and initialized by DEFINE_SPINLOCK,
> so we don't need to spin_lock_init again, drop it.
> 
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
>  arch/mips/vr41xx/common/cmu.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/mips/vr41xx/common/cmu.c b/arch/mips/vr41xx/common/cmu.c
> index b59ee5479313..e4cbe116b26d 100644
> --- a/arch/mips/vr41xx/common/cmu.c
> +++ b/arch/mips/vr41xx/common/cmu.c
> @@ -236,8 +236,6 @@ static int __init vr41xx_cmu_init(void)
>  	if (current_cpu_type() == CPU_VR4133)
>  		cmuclkmsk2 = cmu_read(CMUCLKMSK2);
>  
> -	spin_lock_init(&cmu_lock);
> -
>  	return 0;
>  }
>  
> -- 
> 2.7.4

applied to mips-next.

Thomas.
diff mbox series

Patch

diff --git a/arch/mips/vr41xx/common/cmu.c b/arch/mips/vr41xx/common/cmu.c
index b59ee5479313..e4cbe116b26d 100644
--- a/arch/mips/vr41xx/common/cmu.c
+++ b/arch/mips/vr41xx/common/cmu.c
@@ -236,8 +236,6 @@  static int __init vr41xx_cmu_init(void)
 	if (current_cpu_type() == CPU_VR4133)
 		cmuclkmsk2 = cmu_read(CMUCLKMSK2);
 
-	spin_lock_init(&cmu_lock);
-
 	return 0;
 }