diff mbox series

MIPS: fw: sni: Fix out of bounds init of o32 stack

Message ID 20191009151056.32289-1-tbogendoerfer@suse.de (mailing list archive)
State Mainlined
Commit efcb529694c3b707dc0471b312944337ba16e4dd
Delegated to: Paul Burton
Headers show
Series MIPS: fw: sni: Fix out of bounds init of o32 stack | expand

Commit Message

Thomas Bogendoerfer Oct. 9, 2019, 3:10 p.m. UTC
Use ARRAY_SIZE to caluculate the top of the o32 stack.

Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
---
 arch/mips/fw/sni/sniprom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paul Burton Oct. 9, 2019, 9:58 p.m. UTC | #1
Hello,

Thomas Bogendoerfer wrote:
> Use ARRAY_SIZE to caluculate the top of the o32 stack.

Applied to mips-fixes.

> commit efcb529694c3
> https://git.kernel.org/mips/c/efcb529694c3
> 
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
> Signed-off-by: Paul Burton <paul.burton@mips.com>

Thanks,
    Paul

[ This message was auto-generated; if you believe anything is incorrect
  then please email paul.burton@mips.com to report it. ]
diff mbox series

Patch

diff --git a/arch/mips/fw/sni/sniprom.c b/arch/mips/fw/sni/sniprom.c
index 8772617b64ce..80112f2298b6 100644
--- a/arch/mips/fw/sni/sniprom.c
+++ b/arch/mips/fw/sni/sniprom.c
@@ -43,7 +43,7 @@ 
 
 /* O32 stack has to be 8-byte aligned. */
 static u64 o32_stk[4096];
-#define O32_STK	  &o32_stk[sizeof(o32_stk)]
+#define O32_STK	  (&o32_stk[ARRAY_SIZE(o32_stk)])
 
 #define __PROM_O32(fun, arg) fun arg __asm__(#fun); \
 				     __asm__(#fun " = call_o32")