| Message ID | 20210913024113.220893-1-liu.yun@linux.dev (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | MIPS: loongson64: make LOONGSON64 depends on MIPS_FP_SUPPORT | expand |
Hi, Jackie, On Mon, Sep 13, 2021 at 10:42 AM Jackie Liu <liu.yun@linux.dev> wrote: > > From: Jackie Liu <liuyun01@kylinos.cn> > > mach/loongson64 fails to build when the FPU support is disabled: > > arch/mips/loongson64/cop2-ex.c:45:15: error: implicit declaration of function ‘__is_fpu_owner’; did you mean ‘is_fpu_owner’? [-Werror=implicit-function-declaration] > arch/mips/loongson64/cop2-ex.c:98:30: error: ‘struct thread_struct’ has no member named ‘fpu’ > arch/mips/loongson64/cop2-ex.c:99:30: error: ‘struct thread_struct’ has no member named ‘fpu’ > arch/mips/loongson64/cop2-ex.c:131:43: error: ‘struct thread_struct’ has no member named ‘fpu’ > arch/mips/loongson64/cop2-ex.c:137:38: error: ‘struct thread_struct’ has no member named ‘fpu’ > arch/mips/loongson64/cop2-ex.c:203:30: error: ‘struct thread_struct’ has no member named ‘fpu’ > arch/mips/loongson64/cop2-ex.c:219:30: error: ‘struct thread_struct’ has no member named ‘fpu’ > arch/mips/loongson64/cop2-ex.c:283:38: error: ‘struct thread_struct’ has no member named ‘fpu’ > arch/mips/loongson64/cop2-ex.c:301:38: error: ‘struct thread_struct’ has no member named ‘fpu’ > > Fixes: ef2f826c8f2f ("MIPS: Loongson-3: Enable the COP2 usage") I suggest moving this config option to CPU_LOONGSON64. Huacai > Reported-by: k2ci robot <kernel-bot@kylinos.cn> > Signed-off-by: Jackie Liu <liuyun01@kylinos.cn> > --- > arch/mips/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > index 24e374266fdc..1164c32fd87b 100644 > --- a/arch/mips/Kconfig > +++ b/arch/mips/Kconfig > @@ -487,6 +487,7 @@ config MACH_LOONGSON64 > select ISA > select I8259 > select IRQ_MIPS_CPU > + select MIPS_FP_SUPPORT > select NO_EXCEPT_FILL > select NR_CPUS_DEFAULT_64 > select USE_GENERIC_EARLY_PRINTK_8250 > -- > 2.25.1 >
Hi, Huacai. 在 2021/9/13 上午10:59, Huacai Chen 写道: > Hi, Jackie, > > On Mon, Sep 13, 2021 at 10:42 AM Jackie Liu <liu.yun@linux.dev> wrote: >> >> From: Jackie Liu <liuyun01@kylinos.cn> >> >> mach/loongson64 fails to build when the FPU support is disabled: >> >> arch/mips/loongson64/cop2-ex.c:45:15: error: implicit declaration of function ‘__is_fpu_owner’; did you mean ‘is_fpu_owner’? [-Werror=implicit-function-declaration] >> arch/mips/loongson64/cop2-ex.c:98:30: error: ‘struct thread_struct’ has no member named ‘fpu’ >> arch/mips/loongson64/cop2-ex.c:99:30: error: ‘struct thread_struct’ has no member named ‘fpu’ >> arch/mips/loongson64/cop2-ex.c:131:43: error: ‘struct thread_struct’ has no member named ‘fpu’ >> arch/mips/loongson64/cop2-ex.c:137:38: error: ‘struct thread_struct’ has no member named ‘fpu’ >> arch/mips/loongson64/cop2-ex.c:203:30: error: ‘struct thread_struct’ has no member named ‘fpu’ >> arch/mips/loongson64/cop2-ex.c:219:30: error: ‘struct thread_struct’ has no member named ‘fpu’ >> arch/mips/loongson64/cop2-ex.c:283:38: error: ‘struct thread_struct’ has no member named ‘fpu’ >> arch/mips/loongson64/cop2-ex.c:301:38: error: ‘struct thread_struct’ has no member named ‘fpu’ >> >> Fixes: ef2f826c8f2f ("MIPS: Loongson-3: Enable the COP2 usage") > I suggest moving this config option to CPU_LOONGSON64. Looks correct, thanks for the suggestion. -- Jackie Liu > > Huacai > >> Reported-by: k2ci robot <kernel-bot@kylinos.cn> >> Signed-off-by: Jackie Liu <liuyun01@kylinos.cn> >> --- >> arch/mips/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig >> index 24e374266fdc..1164c32fd87b 100644 >> --- a/arch/mips/Kconfig >> +++ b/arch/mips/Kconfig >> @@ -487,6 +487,7 @@ config MACH_LOONGSON64 >> select ISA >> select I8259 >> select IRQ_MIPS_CPU >> + select MIPS_FP_SUPPORT >> select NO_EXCEPT_FILL >> select NR_CPUS_DEFAULT_64 >> select USE_GENERIC_EARLY_PRINTK_8250 >> -- >> 2.25.1 >>
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig index 24e374266fdc..1164c32fd87b 100644 --- a/arch/mips/Kconfig +++ b/arch/mips/Kconfig @@ -487,6 +487,7 @@ config MACH_LOONGSON64 select ISA select I8259 select IRQ_MIPS_CPU + select MIPS_FP_SUPPORT select NO_EXCEPT_FILL select NR_CPUS_DEFAULT_64 select USE_GENERIC_EARLY_PRINTK_8250