diff mbox series

[v4] MIPS: loongson64: make CPU_LOONGSON64 depends on MIPS_FP_SUPPORT

Message ID 20210913061908.550030-1-liu.yun@linux.dev (mailing list archive)
State Accepted
Headers show
Series [v4] MIPS: loongson64: make CPU_LOONGSON64 depends on MIPS_FP_SUPPORT | expand

Commit Message

Jackie Liu Sept. 13, 2021, 6:19 a.m. UTC 
From: Jackie Liu <liuyun01@kylinos.cn>

mach/loongson64 fails to build when the FPU support is disabled:

arch/mips/loongson64/cop2-ex.c:45:15: error: implicit declaration of function ‘__is_fpu_owner’; did you mean ‘is_fpu_owner’? [-Werror=implicit-function-declaration]
arch/mips/loongson64/cop2-ex.c:98:30: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:99:30: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:131:43: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:137:38: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:203:30: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:219:30: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:283:38: error: ‘struct thread_struct’ has no member named ‘fpu’
arch/mips/loongson64/cop2-ex.c:301:38: error: ‘struct thread_struct’ has no member named ‘fpu’

Fixes: ef2f826c8f2f ("MIPS: Loongson-3: Enable the COP2 usage")
Suggested-by: Huacai Chen <chenhuacai@kernel.org>
Reviewed-by: Huacai Chen <chenhuacai@kernel.org>
Reported-by: k2ci robot <kernel-bot@kylinos.cn>
Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>
---
 v1->v2:
 move MIPS_FP_SUPPORT from MACH_LOONGSON64 to CPU_LOONGSON64

 v2->v3:
 add Huacai Chen <chenhc@lemote.com>'s suggest label.

 v3->v4:
 update Huacai Chen's email address.

 arch/mips/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Jackie Liu Sept. 22, 2021, 2:29 a.m. UTC | #1 
ping, would anyone take this patch?

在 2021/9/13 下午2:19, Jackie Liu 写道:
> From: Jackie Liu <liuyun01@kylinos.cn>
> 
> mach/loongson64 fails to build when the FPU support is disabled:
> 
> arch/mips/loongson64/cop2-ex.c:45:15: error: implicit declaration of function ‘__is_fpu_owner’; did you mean ‘is_fpu_owner’? [-Werror=implicit-function-declaration]
> arch/mips/loongson64/cop2-ex.c:98:30: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:99:30: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:131:43: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:137:38: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:203:30: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:219:30: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:283:38: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:301:38: error: ‘struct thread_struct’ has no member named ‘fpu’
> 
> Fixes: ef2f826c8f2f ("MIPS: Loongson-3: Enable the COP2 usage")
> Suggested-by: Huacai Chen <chenhuacai@kernel.org>
> Reviewed-by: Huacai Chen <chenhuacai@kernel.org>
> Reported-by: k2ci robot <kernel-bot@kylinos.cn>
> Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>
> ---
>   v1->v2:
>   move MIPS_FP_SUPPORT from MACH_LOONGSON64 to CPU_LOONGSON64
> 
>   v2->v3:
>   add Huacai Chen <chenhc@lemote.com>'s suggest label.
> 
>   v3->v4:
>   update Huacai Chen's email address.
> 
>   arch/mips/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 24e374266fdc..aea3aa16a38e 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -1408,6 +1408,7 @@ config CPU_LOONGSON64
>   	select MIPS_ASID_BITS_VARIABLE
>   	select MIPS_PGD_C0_CONTEXT
>   	select MIPS_L1_CACHE_SHIFT_6
> +	select MIPS_FP_SUPPORT
>   	select GPIOLIB
>   	select SWIOTLB
>   	select HAVE_KVM
>
Thomas Bogendoerfer Sept. 23, 2021, 9:35 a.m. UTC | #2 
On Mon, Sep 13, 2021 at 02:19:08PM +0800, Jackie Liu wrote:
> From: Jackie Liu <liuyun01@kylinos.cn>
> 
> mach/loongson64 fails to build when the FPU support is disabled:
> 
> arch/mips/loongson64/cop2-ex.c:45:15: error: implicit declaration of function ‘__is_fpu_owner’; did you mean ‘is_fpu_owner’? [-Werror=implicit-function-declaration]
> arch/mips/loongson64/cop2-ex.c:98:30: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:99:30: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:131:43: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:137:38: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:203:30: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:219:30: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:283:38: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:301:38: error: ‘struct thread_struct’ has no member named ‘fpu’
> 
> Fixes: ef2f826c8f2f ("MIPS: Loongson-3: Enable the COP2 usage")
> Suggested-by: Huacai Chen <chenhuacai@kernel.org>
> Reviewed-by: Huacai Chen <chenhuacai@kernel.org>
> Reported-by: k2ci robot <kernel-bot@kylinos.cn>
> Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>
> ---
>  v1->v2:
>  move MIPS_FP_SUPPORT from MACH_LOONGSON64 to CPU_LOONGSON64
> 
>  v2->v3:
>  add Huacai Chen <chenhc@lemote.com>'s suggest label.
> 
>  v3->v4:
>  update Huacai Chen's email address.
> 
>  arch/mips/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

applied to mips-next.

Thomas.
diff mbox series

Patch

diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 24e374266fdc..aea3aa16a38e 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -1408,6 +1408,7 @@  config CPU_LOONGSON64
 	select MIPS_ASID_BITS_VARIABLE
 	select MIPS_PGD_C0_CONTEXT
 	select MIPS_L1_CACHE_SHIFT_6
+	select MIPS_FP_SUPPORT
 	select GPIOLIB
 	select SWIOTLB
 	select HAVE_KVM