| Message ID | 20220303091521.1125841-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | firmware: tee_bnxt: remove redundant assignment to variable nbytes | expand |
diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c index a5bf4c3f6dc7..6d92ec02f2c7 100644 --- a/drivers/firmware/broadcom/tee_bnxt_fw.c +++ b/drivers/firmware/broadcom/tee_bnxt_fw.c @@ -143,8 +143,6 @@ int tee_bnxt_copy_coredump(void *buf, u32 offset, u32 size) prepare_args(TA_CMD_BNXT_COPY_COREDUMP, &arg, param); while (rbytes) { - nbytes = rbytes; - nbytes = min_t(u32, rbytes, param[0].u.memref.size); /* Fill additional invoke cmd params */
The variable nbytes is assigned a value that is never read, it is being re-assigned a new value on the following statement. The assignmen is redundant and can be removed. Cleans up cppcheck warning: drivers/firmware/broadcom/tee_bnxt_fw.c:148:10: style: Variable 'nbytes' is reassigned a value before the old one has been used. [redundantAssignment] Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/firmware/broadcom/tee_bnxt_fw.c | 2 -- 1 file changed, 2 deletions(-)