| Message ID | 20220615141123.3968401-1-windhl@126.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4becf6417bbdc293734a590fe4ed38437bbcea2c |
| Headers | show |
| Series | arch: mips: generic: Add missing of_node_put() in board-ranchu.c | expand |
On Wed, Jun 15, 2022 at 10:11:23PM +0800, Liang He wrote: > In ranchu_measure_hpt_freq(), of_find_compatible_node() will return > a node pointer with refcount incremented. We should use of_put_node() > when it is not used anymore. > > Signed-off-by: Liang He <windhl@126.com> > --- > arch/mips/generic/board-ranchu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/mips/generic/board-ranchu.c b/arch/mips/generic/board-ranchu.c > index a89aaad59cb1..930c45041882 100644 > --- a/arch/mips/generic/board-ranchu.c > +++ b/arch/mips/generic/board-ranchu.c > @@ -44,6 +44,7 @@ static __init unsigned int ranchu_measure_hpt_freq(void) > __func__); > > rtc_base = of_iomap(np, 0); > + of_node_put(np); > if (!rtc_base) > panic("%s(): Failed to ioremap Goldfish RTC base!", __func__); > > -- > 2.25.1 applied to mips-fixes. Thomas.
diff --git a/arch/mips/generic/board-ranchu.c b/arch/mips/generic/board-ranchu.c index a89aaad59cb1..930c45041882 100644 --- a/arch/mips/generic/board-ranchu.c +++ b/arch/mips/generic/board-ranchu.c @@ -44,6 +44,7 @@ static __init unsigned int ranchu_measure_hpt_freq(void) __func__); rtc_base = of_iomap(np, 0); + of_node_put(np); if (!rtc_base) panic("%s(): Failed to ioremap Goldfish RTC base!", __func__);
In ranchu_measure_hpt_freq(), of_find_compatible_node() will return a node pointer with refcount incremented. We should use of_put_node() when it is not used anymore. Signed-off-by: Liang He <windhl@126.com> --- arch/mips/generic/board-ranchu.c | 1 + 1 file changed, 1 insertion(+)