| Message ID | 20220616142756.3987475-1-windhl@126.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 608d94cb84c42585058d692f2fe5d327f8868cdb |
| Headers | show |
| Series | mips: mti-malta: Fix refcount leak in malta-time.c | expand |
On Thu, Jun 16, 2022 at 10:27:56PM +0800, Liang He wrote: > In update_gic_frequency_dt(), of_find_compatible_node() will return > a node pointer with refcount incremented. We should use of_node_put() > when it is not used anymore. > > Signed-off-by: Liang He <windhl@126.com> > --- > arch/mips/mti-malta/malta-time.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/mips/mti-malta/malta-time.c b/arch/mips/mti-malta/malta-time.c > index bbf1e38e1431..2cb708cdf01a 100644 > --- a/arch/mips/mti-malta/malta-time.c > +++ b/arch/mips/mti-malta/malta-time.c > @@ -214,6 +214,8 @@ static void update_gic_frequency_dt(void) > > if (of_update_property(node, &gic_frequency_prop) < 0) > pr_err("error updating gic frequency property\n"); > + > + of_node_put(node); > } > > #endif > -- > 2.25.1 applied to mips-fixes. Thomas.
diff --git a/arch/mips/mti-malta/malta-time.c b/arch/mips/mti-malta/malta-time.c index bbf1e38e1431..2cb708cdf01a 100644 --- a/arch/mips/mti-malta/malta-time.c +++ b/arch/mips/mti-malta/malta-time.c @@ -214,6 +214,8 @@ static void update_gic_frequency_dt(void) if (of_update_property(node, &gic_frequency_prop) < 0) pr_err("error updating gic frequency property\n"); + + of_node_put(node); } #endif
In update_gic_frequency_dt(), of_find_compatible_node() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore. Signed-off-by: Liang He <windhl@126.com> --- arch/mips/mti-malta/malta-time.c | 2 ++ 1 file changed, 2 insertions(+)