diff mbox series

[v2] irqchip: mips-gic: check the return value of ioremap() in gic_of_init()

Message ID 20220723100128.2964304-1-williamsukatube@163.com (mailing list archive)
State Handled Elsewhere
Headers show
Series [v2] irqchip: mips-gic: check the return value of ioremap() in gic_of_init() | expand

Commit Message

williamsukatube@163.com July 23, 2022, 10:01 a.m. UTC 
From: William Dean <williamsukatube@163.com>

The function ioremap() in gic_of_init() can fail, so
its return value should be checked.

Reported-by: Hacash Robot <hacashRobot@santino.com>
Signed-off-by: William Dean <williamsukatube@163.com>
---
v2: delete fixes tag and correct SoB tag

 drivers/irqchip/irq-mips-gic.c | 4 ++++
 1 file changed, 4 insertions(+)
diff mbox series

Patch

diff --git a/drivers/irqchip/irq-mips-gic.c b/drivers/irqchip/irq-mips-gic.c
index ff89b36267dd..a1f6d955794a 100644
--- a/drivers/irqchip/irq-mips-gic.c
+++ b/drivers/irqchip/irq-mips-gic.c
@@ -734,6 +734,10 @@  static int __init gic_of_init(struct device_node *node,
 	}
 
 	mips_gic_base = ioremap(gic_base, gic_len);
+	if (!mips_gic_base) {
+		pr_err("Failed to ioremap gic_base\n");
+		return -ENOMEM;
+	}
 
 	gicconfig = read_gic_config();
 	gic_shared_intrs = FIELD_GET(GIC_CONFIG_NUMINTERRUPTS, gicconfig);