| Message ID | 20221016150110.3020451-2-lis8215@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add Ingenic JZ4755 CGU driver | expand |
Hi Siarhei, Le dim., oct. 16 2022 at 18:01:06 +0300, Siarhei Volkau <lis8215@gmail.com> a écrit : > which is close to jz4725b because it is actually a low price > successor of the jz4755. > It has the same MIPS32r1 core with Xburst(R) extension > MXU version 1 release 2. > > Signed-off-by: Siarhei Volkau <lis8215@gmail.com> This patch doesn't really belong in the CGU patchset. It should go through the MIPS tree. I see why you include it, but you do not need to have the MACH_JZ4755 symbol defined anywhere for the "default MACH_JZ4755" to work, it will just default to false until the patchset that adds JZ4755 support is merged in the MIPS tree. Cheers, -Paul > --- > arch/mips/ingenic/Kconfig | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/mips/ingenic/Kconfig b/arch/mips/ingenic/Kconfig > index f595b339a..edd84cf13 100644 > --- a/arch/mips/ingenic/Kconfig > +++ b/arch/mips/ingenic/Kconfig > @@ -4,6 +4,7 @@ config MACH_INGENIC_GENERIC > bool > select MACH_INGENIC > select MACH_JZ4740 > + select MACH_JZ4755 > select MACH_JZ4725B > select MACH_JZ4770 > select MACH_JZ4780 > @@ -53,6 +54,10 @@ config MACH_JZ4740 > bool > select SYS_HAS_CPU_MIPS32_R1 > > +config MACH_JZ4755 > + bool > + select SYS_HAS_CPU_MIPS32_R1 > + > config MACH_JZ4770 > bool > select MIPS_CPU_SCACHE > -- > 2.36.1 >
пн, 17 окт. 2022 г. в 12:10, Paul Cercueil <paul@crapouillou.net>: > I see why you include it, but you do not need to have the MACH_JZ4755 > symbol defined anywhere for the "default MACH_JZ4755" to work, it will > just default to false until the patchset that adds JZ4755 support is > merged in the MIPS tree. Thank you for the clarification, Paul. Will be done in the next version.
diff --git a/arch/mips/ingenic/Kconfig b/arch/mips/ingenic/Kconfig index f595b339a..edd84cf13 100644 --- a/arch/mips/ingenic/Kconfig +++ b/arch/mips/ingenic/Kconfig @@ -4,6 +4,7 @@ config MACH_INGENIC_GENERIC bool select MACH_INGENIC select MACH_JZ4740 + select MACH_JZ4755 select MACH_JZ4725B select MACH_JZ4770 select MACH_JZ4780 @@ -53,6 +54,10 @@ config MACH_JZ4740 bool select SYS_HAS_CPU_MIPS32_R1 +config MACH_JZ4755 + bool + select SYS_HAS_CPU_MIPS32_R1 + config MACH_JZ4770 bool select MIPS_CPU_SCACHE
which is close to jz4725b because it is actually a low price successor of the jz4755. It has the same MIPS32r1 core with Xburst(R) extension MXU version 1 release 2. Signed-off-by: Siarhei Volkau <lis8215@gmail.com> --- arch/mips/ingenic/Kconfig | 5 +++++ 1 file changed, 5 insertions(+)