| Message ID | 20230116131235.18917-19-tzimmermann@suse.de (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | drm: Remove includes for drm_crtc_helper.h | expand |
On Mon, Jan 16, 2023 at 02:12:31PM +0100, Thomas Zimmermann wrote: > Several source files include drm_crtc_helper.h without needing it or > only to get its transitive include statements; leading to unnecessary > compile-time dependencies. > > Directly include required headers and drop drm_crtc_helper.h where > possible. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > --- > drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c > index 477cb6985b4d..37dc66332bbd 100644 > --- a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c > +++ b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c > @@ -8,8 +8,8 @@ > #include <linux/of_device.h> > #include <linux/platform_device.h> > > -#include <drm/drm_crtc_helper.h> > #include <drm/drm_of.h> > +#include <drm/drm_modeset_helper_vtables.h> Move one up to maintain sorting. With that fixed: Reviewed-by: Sam Ravnborg <sam@ravnborg.org> > #include <drm/drm_simple_kms_helper.h> > > #include "sun8i_dw_hdmi.h" > -- > 2.39.0
diff --git a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c index 477cb6985b4d..37dc66332bbd 100644 --- a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c +++ b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c @@ -8,8 +8,8 @@ #include <linux/of_device.h> #include <linux/platform_device.h> -#include <drm/drm_crtc_helper.h> #include <drm/drm_of.h> +#include <drm/drm_modeset_helper_vtables.h> #include <drm/drm_simple_kms_helper.h> #include "sun8i_dw_hdmi.h"
Several source files include drm_crtc_helper.h without needing it or only to get its transitive include statements; leading to unnecessary compile-time dependencies. Directly include required headers and drop drm_crtc_helper.h where possible. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> --- drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)