| Message ID | 20230302125215.214014-2-keguang.zhang@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Devicetree support for Loongson-1 GPIO | expand |
On Thu, Mar 2, 2023 at 1:52 PM Keguang Zhang <keguang.zhang@gmail.com> wrote: > > Use SPDX-License-Identifier instead of the license text and > update the author information. > > Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com> > --- > V1 -> V2: Keep GPLv2, just convert to SPDX identifier > --- > drivers/gpio/gpio-loongson1.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpio/gpio-loongson1.c b/drivers/gpio/gpio-loongson1.c > index 5d90b3bc5a25..8862c9ea0d41 100644 > --- a/drivers/gpio/gpio-loongson1.c > +++ b/drivers/gpio/gpio-loongson1.c > @@ -1,11 +1,8 @@ > +// SPDX-License-Identifier: GPL-2.0-only > /* > * GPIO Driver for Loongson 1 SoC > * > - * Copyright (C) 2015-2016 Zhang, Keguang <keguang.zhang@gmail.com> > - * > - * This file is licensed under the terms of the GNU General Public > - * License version 2. This program is licensed "as is" without any > - * warranty of any kind, whether express or implied. > + * Copyright (C) 2015-2023 Keguang Zhang <keguang.zhang@gmail.com> > */ > > #include <linux/module.h> > @@ -90,6 +87,6 @@ static struct platform_driver ls1x_gpio_driver = { > > module_platform_driver(ls1x_gpio_driver); > > -MODULE_AUTHOR("Kelvin Cheung <keguang.zhang@gmail.com>"); Why are you removing credits of the old author? Bart > +MODULE_AUTHOR("Keguang Zhang <keguang.zhang@gmail.com>"); > MODULE_DESCRIPTION("Loongson1 GPIO driver"); > MODULE_LICENSE("GPL"); > -- > 2.34.1 >
On Mon, Mar 6, 2023 at 5:29 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > On Thu, Mar 2, 2023 at 1:52 PM Keguang Zhang <keguang.zhang@gmail.com> wrote: > > > > Use SPDX-License-Identifier instead of the license text and > > update the author information. > > > > Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com> > > --- > > V1 -> V2: Keep GPLv2, just convert to SPDX identifier > > --- > > drivers/gpio/gpio-loongson1.c | 9 +++------ > > 1 file changed, 3 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/gpio/gpio-loongson1.c b/drivers/gpio/gpio-loongson1.c > > index 5d90b3bc5a25..8862c9ea0d41 100644 > > --- a/drivers/gpio/gpio-loongson1.c > > +++ b/drivers/gpio/gpio-loongson1.c > > @@ -1,11 +1,8 @@ > > +// SPDX-License-Identifier: GPL-2.0-only > > /* > > * GPIO Driver for Loongson 1 SoC > > * > > - * Copyright (C) 2015-2016 Zhang, Keguang <keguang.zhang@gmail.com> > > - * > > - * This file is licensed under the terms of the GNU General Public > > - * License version 2. This program is licensed "as is" without any > > - * warranty of any kind, whether express or implied. > > + * Copyright (C) 2015-2023 Keguang Zhang <keguang.zhang@gmail.com> > > */ > > > > #include <linux/module.h> > > @@ -90,6 +87,6 @@ static struct platform_driver ls1x_gpio_driver = { > > > > module_platform_driver(ls1x_gpio_driver); > > > > -MODULE_AUTHOR("Kelvin Cheung <keguang.zhang@gmail.com>"); > > Why are you removing credits of the old author? Kelvin Cheung and Keguang Zhang are the same person. This change is to keep pace with the related entry of MAINTAINERS. > > Bart > > > +MODULE_AUTHOR("Keguang Zhang <keguang.zhang@gmail.com>"); > > MODULE_DESCRIPTION("Loongson1 GPIO driver"); > > MODULE_LICENSE("GPL"); > > -- > > 2.34.1 > >
On Tue, Mar 7, 2023 at 3:25 AM Keguang Zhang <keguang.zhang@gmail.com> wrote: > On Mon, Mar 6, 2023 at 5:29 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > On Thu, Mar 2, 2023 at 1:52 PM Keguang Zhang <keguang.zhang@gmail.com> wrote: > > > > > > Use SPDX-License-Identifier instead of the license text and > > > update the author information. > > > > > > Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com> > > Why are you removing credits of the old author? > Kelvin Cheung and Keguang Zhang are the same person. > This change is to keep pace with the related entry of MAINTAINERS. That's a pretty interesting change! Is Kelvin Cheung the "westernized" name and Keguang Zhang the closer to the real name, such as pinyin form? That would make a lot of sense. I think some authors even use the native characters these days, as git and all tools and terminals should support Unicode now. It might make it hard for us to answer mails (not knowing which characters to refer to as given name) but I kind of like it when I see it. Yours, Linus Walleij
On Tue, Mar 7, 2023 at 3:25 AM Keguang Zhang <keguang.zhang@gmail.com> wrote: > > On Mon, Mar 6, 2023 at 5:29 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > > > On Thu, Mar 2, 2023 at 1:52 PM Keguang Zhang <keguang.zhang@gmail.com> wrote: > > > > > > Use SPDX-License-Identifier instead of the license text and > > > update the author information. > > > > > > Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com> > > > --- > > > V1 -> V2: Keep GPLv2, just convert to SPDX identifier > > > --- > > > drivers/gpio/gpio-loongson1.c | 9 +++------ > > > 1 file changed, 3 insertions(+), 6 deletions(-) > > > > > > diff --git a/drivers/gpio/gpio-loongson1.c b/drivers/gpio/gpio-loongson1.c > > > index 5d90b3bc5a25..8862c9ea0d41 100644 > > > --- a/drivers/gpio/gpio-loongson1.c > > > +++ b/drivers/gpio/gpio-loongson1.c > > > @@ -1,11 +1,8 @@ > > > +// SPDX-License-Identifier: GPL-2.0-only > > > /* > > > * GPIO Driver for Loongson 1 SoC > > > * > > > - * Copyright (C) 2015-2016 Zhang, Keguang <keguang.zhang@gmail.com> > > > - * > > > - * This file is licensed under the terms of the GNU General Public > > > - * License version 2. This program is licensed "as is" without any > > > - * warranty of any kind, whether express or implied. > > > + * Copyright (C) 2015-2023 Keguang Zhang <keguang.zhang@gmail.com> > > > */ > > > > > > #include <linux/module.h> > > > @@ -90,6 +87,6 @@ static struct platform_driver ls1x_gpio_driver = { > > > > > > module_platform_driver(ls1x_gpio_driver); > > > > > > -MODULE_AUTHOR("Kelvin Cheung <keguang.zhang@gmail.com>"); > > > > Why are you removing credits of the old author? > Kelvin Cheung and Keguang Zhang are the same person. > This change is to keep pace with the related entry of MAINTAINERS. > Even so - how could I have possibly known this? Please put it into the commit message, it's crucial information for this change. Bart
On Tue, Mar 7, 2023 at 9:31 PM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Tue, Mar 7, 2023 at 3:25 AM Keguang Zhang <keguang.zhang@gmail.com> wrote: > > On Mon, Mar 6, 2023 at 5:29 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > > On Thu, Mar 2, 2023 at 1:52 PM Keguang Zhang <keguang.zhang@gmail.com> wrote: > > > > > > > > Use SPDX-License-Identifier instead of the license text and > > > > update the author information. > > > > > > > > Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com> > > > > Why are you removing credits of the old author? > > > Kelvin Cheung and Keguang Zhang are the same person. > > This change is to keep pace with the related entry of MAINTAINERS. > > That's a pretty interesting change! > > Is Kelvin Cheung the "westernized" name and Keguang Zhang the > closer to the real name, such as pinyin form? That would make > a lot of sense. > Exactly. Kelvin Cheung is easy to pronounce, but has no direct relationship with my real name. Keguang Zhang, the Pinyin form of my real name, is the official name. That is why I'd like to make this change. > I think some authors even use the native characters these days, > as git and all tools and terminals should support Unicode now. > It might make it hard for us to answer mails (not knowing which > characters to refer to as given name) but I kind of like it when I > see it. > Yes, I did see the names written in native characters. But it's even harder for western people to identify. Maybe the real name with native characters + "westernized" name is better. > Yours, > Linus Walleij
On Wed, Mar 8, 2023 at 12:49 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > On Tue, Mar 7, 2023 at 3:25 AM Keguang Zhang <keguang.zhang@gmail.com> wrote: > > > > On Mon, Mar 6, 2023 at 5:29 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > > > > > On Thu, Mar 2, 2023 at 1:52 PM Keguang Zhang <keguang.zhang@gmail.com> wrote: > > > > > > > > Use SPDX-License-Identifier instead of the license text and > > > > update the author information. > > > > > > > > Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com> > > > > --- > > > > V1 -> V2: Keep GPLv2, just convert to SPDX identifier > > > > --- > > > > drivers/gpio/gpio-loongson1.c | 9 +++------ > > > > 1 file changed, 3 insertions(+), 6 deletions(-) > > > > > > > > diff --git a/drivers/gpio/gpio-loongson1.c b/drivers/gpio/gpio-loongson1.c > > > > index 5d90b3bc5a25..8862c9ea0d41 100644 > > > > --- a/drivers/gpio/gpio-loongson1.c > > > > +++ b/drivers/gpio/gpio-loongson1.c > > > > @@ -1,11 +1,8 @@ > > > > +// SPDX-License-Identifier: GPL-2.0-only > > > > /* > > > > * GPIO Driver for Loongson 1 SoC > > > > * > > > > - * Copyright (C) 2015-2016 Zhang, Keguang <keguang.zhang@gmail.com> > > > > - * > > > > - * This file is licensed under the terms of the GNU General Public > > > > - * License version 2. This program is licensed "as is" without any > > > > - * warranty of any kind, whether express or implied. > > > > + * Copyright (C) 2015-2023 Keguang Zhang <keguang.zhang@gmail.com> > > > > */ > > > > > > > > #include <linux/module.h> > > > > @@ -90,6 +87,6 @@ static struct platform_driver ls1x_gpio_driver = { > > > > > > > > module_platform_driver(ls1x_gpio_driver); > > > > > > > > -MODULE_AUTHOR("Kelvin Cheung <keguang.zhang@gmail.com>"); > > > > > > Why are you removing credits of the old author? > > Kelvin Cheung and Keguang Zhang are the same person. > > This change is to keep pace with the related entry of MAINTAINERS. > > > > Even so - how could I have possibly known this? Please put it into the > commit message, it's crucial information for this change. > Sure. I will amend the commit message. In addition, should I update this patch only? Or the whole patch series? > Bart
diff --git a/drivers/gpio/gpio-loongson1.c b/drivers/gpio/gpio-loongson1.c index 5d90b3bc5a25..8862c9ea0d41 100644 --- a/drivers/gpio/gpio-loongson1.c +++ b/drivers/gpio/gpio-loongson1.c @@ -1,11 +1,8 @@ +// SPDX-License-Identifier: GPL-2.0-only /* * GPIO Driver for Loongson 1 SoC * - * Copyright (C) 2015-2016 Zhang, Keguang <keguang.zhang@gmail.com> - * - * This file is licensed under the terms of the GNU General Public - * License version 2. This program is licensed "as is" without any - * warranty of any kind, whether express or implied. + * Copyright (C) 2015-2023 Keguang Zhang <keguang.zhang@gmail.com> */ #include <linux/module.h> @@ -90,6 +87,6 @@ static struct platform_driver ls1x_gpio_driver = { module_platform_driver(ls1x_gpio_driver); -MODULE_AUTHOR("Kelvin Cheung <keguang.zhang@gmail.com>"); +MODULE_AUTHOR("Keguang Zhang <keguang.zhang@gmail.com>"); MODULE_DESCRIPTION("Loongson1 GPIO driver"); MODULE_LICENSE("GPL");
Use SPDX-License-Identifier instead of the license text and update the author information. Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com> --- V1 -> V2: Keep GPLv2, just convert to SPDX identifier --- drivers/gpio/gpio-loongson1.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)