| Message ID | 20230727012040.3934021-1-robh@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e1a7566d0955cc5357903c04030aac05ced95939 |
| Headers | show |
| Series | MIPS: More explicit DT include clean-ups | expand |
On Wed, Jul 26, 2023 at 07:20:39PM -0600, Rob Herring wrote: > A couple more clean-ups in the MIPS code. > > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it was merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > I've now built all MIPS defconfigs in my tree which removes the implicit > includes. So I found a few more fixes. This can be squashed into the > previous commit if desired. > --- > arch/mips/cavium-octeon/octeon-platform.c | 2 ++ > arch/mips/cavium-octeon/octeon-usb.c | 2 ++ > arch/mips/ralink/ill_acc.c | 2 ++ > 3 files changed, 6 insertions(+) applied to mips-next. Thomas.
diff --git a/arch/mips/cavium-octeon/octeon-platform.c b/arch/mips/cavium-octeon/octeon-platform.c index ce05c0dd3acd..60da1b2091f5 100644 --- a/arch/mips/cavium-octeon/octeon-platform.c +++ b/arch/mips/cavium-octeon/octeon-platform.c @@ -8,8 +8,10 @@ */ #include <linux/etherdevice.h> +#include <linux/of.h> #include <linux/of_platform.h> #include <linux/of_fdt.h> +#include <linux/platform_device.h> #include <linux/libfdt.h> #include <asm/octeon/octeon.h> diff --git a/arch/mips/cavium-octeon/octeon-usb.c b/arch/mips/cavium-octeon/octeon-usb.c index 2add435ad038..add0f23592b3 100644 --- a/arch/mips/cavium-octeon/octeon-usb.c +++ b/arch/mips/cavium-octeon/octeon-usb.c @@ -15,7 +15,9 @@ #include <linux/io.h> #include <linux/module.h> #include <linux/mutex.h> +#include <linux/of.h> #include <linux/of_platform.h> +#include <linux/platform_device.h> /* * USB Control Register diff --git a/arch/mips/ralink/ill_acc.c b/arch/mips/ralink/ill_acc.c index f395ae218470..25341b2319d0 100644 --- a/arch/mips/ralink/ill_acc.c +++ b/arch/mips/ralink/ill_acc.c @@ -5,8 +5,10 @@ */ #include <linux/interrupt.h> +#include <linux/of.h> #include <linux/of_platform.h> #include <linux/of_irq.h> +#include <linux/platform_device.h> #include <asm/mach-ralink/ralink_regs.h>
A couple more clean-ups in the MIPS code. The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it was merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes. Signed-off-by: Rob Herring <robh@kernel.org> --- I've now built all MIPS defconfigs in my tree which removes the implicit includes. So I found a few more fixes. This can be squashed into the previous commit if desired. --- arch/mips/cavium-octeon/octeon-platform.c | 2 ++ arch/mips/cavium-octeon/octeon-usb.c | 2 ++ arch/mips/ralink/ill_acc.c | 2 ++ 3 files changed, 6 insertions(+)