| Message ID | 20230816111310.1656224-2-keguang.zhang@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Move Loongson1 MAC arch-code to the driver dir | expand |
On 16/08/2023 13:13, Keguang Zhang wrote: > Add Loongson LS1B and LS1C compatibles for system controller. I asked not to use the same compatible for different blocks. Compatible is dwmac, but are you still going to use for other blocks? Please write proper description of the hardware. > > Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com> > --- > V1 -> V2: Make the syscon compatibles more specific > > Documentation/devicetree/bindings/mfd/syscon.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml > index 8103154bbb52..d701fff02abe 100644 > --- a/Documentation/devicetree/bindings/mfd/syscon.yaml > +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml > @@ -49,6 +49,8 @@ properties: > - hisilicon,peri-subctrl > - hpe,gxp-sysreg > - intel,lgm-syscon > + - loongson,ls1b-dwmac-syscon > + - loongson,ls1c-dwmac-syscon Best regards, Krzysztof
On Sat, Aug 19, 2023 at 10:23 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 16/08/2023 13:13, Keguang Zhang wrote: > > Add Loongson LS1B and LS1C compatibles for system controller. > > I asked not to use the same compatible for different blocks. Compatible > is dwmac, but are you still going to use for other blocks? Please write > proper description of the hardware. > Sorry. I didn't make myself clear. The SoC only has one syscon with two registers. And Each register contains settings for multiple devices. Besides DWMAC, this syscon will be used for other devices. Should I keep using loongson,ls1b-syscon/loongson,ls1c-syscon? > > > > Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com> > > --- > > V1 -> V2: Make the syscon compatibles more specific > > > > Documentation/devicetree/bindings/mfd/syscon.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml > > index 8103154bbb52..d701fff02abe 100644 > > --- a/Documentation/devicetree/bindings/mfd/syscon.yaml > > +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml > > @@ -49,6 +49,8 @@ properties: > > - hisilicon,peri-subctrl > > - hpe,gxp-sysreg > > - intel,lgm-syscon > > + - loongson,ls1b-dwmac-syscon > > + - loongson,ls1c-dwmac-syscon > > > Best regards, > Krzysztof > -- Best regards, Keguang Zhang
On 21/08/2023 13:00, Keguang Zhang wrote: > On Sat, Aug 19, 2023 at 10:23 PM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On 16/08/2023 13:13, Keguang Zhang wrote: >>> Add Loongson LS1B and LS1C compatibles for system controller. >> >> I asked not to use the same compatible for different blocks. Compatible >> is dwmac, but are you still going to use for other blocks? Please write >> proper description of the hardware. >> > Sorry. I didn't make myself clear. > The SoC only has one syscon with two registers. > And Each register contains settings for multiple devices. > Besides DWMAC, this syscon will be used for other devices. > Should I keep using loongson,ls1b-syscon/loongson,ls1c-syscon? Ah, ok, then the naming of the compatible should reflect the name of this syscon block. If it does not have any name and it is the only syscon, then name like "loongson,ls1b-syscon" is good. If the block has some name - use it in compatible. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml index 8103154bbb52..d701fff02abe 100644 --- a/Documentation/devicetree/bindings/mfd/syscon.yaml +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml @@ -49,6 +49,8 @@ properties: - hisilicon,peri-subctrl - hpe,gxp-sysreg - intel,lgm-syscon + - loongson,ls1b-dwmac-syscon + - loongson,ls1c-dwmac-syscon - marvell,armada-3700-usb2-host-misc - mediatek,mt8135-pctl-a-syscfg - mediatek,mt8135-pctl-b-syscfg
Add Loongson LS1B and LS1C compatibles for system controller. Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com> --- V1 -> V2: Make the syscon compatibles more specific Documentation/devicetree/bindings/mfd/syscon.yaml | 2 ++ 1 file changed, 2 insertions(+)