From patchwork Wed Oct 4 13:12:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13408751 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47D34E7B615 for ; Wed, 4 Oct 2023 13:13:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242577AbjJDNN3 (ORCPT ); Wed, 4 Oct 2023 09:13:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242567AbjJDNN2 (ORCPT ); Wed, 4 Oct 2023 09:13:28 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE8FBE5 for ; Wed, 4 Oct 2023 06:13:24 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qo1gf-0007CZ-Rq; Wed, 04 Oct 2023 15:13:13 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qo1gf-00B2hp-9F; Wed, 04 Oct 2023 15:13:13 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qo1ge-008zD1-W1; Wed, 04 Oct 2023 15:13:13 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Borislav Petkov , Tony Luck Cc: Ralf Baechle , James Morse , Mauro Carvalho Chehab , Robert Richter , linux-edac@vger.kernel.org, linux-mips@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 13/21] EDAC/octeon-lmc: Convert to platform remove callback returning void Date: Wed, 4 Oct 2023 15:12:46 +0200 Message-Id: <20231004131254.2673842-14-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231004131254.2673842-1-u.kleine-koenig@pengutronix.de> References: <20231004131254.2673842-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1657; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=VeH3XaksoEh1y2Oj3rkICncn86zOLkB5zFze1tmESPk=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlHWSvxPO2vz9A6QU+yKqgFQ5yVN/u5UXi/jyj5 CEmmNiN3a2JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZR1krwAKCRCPgPtYfRL+ TtLOB/9fuzft1PSRbElBHB+Jt4dgjNmXw1wuaQ3tjFCqEEmg4Tgae2jIcIHaRwX/AVao7IaDfOH EbRhf32sUDpBLzcyklO2pyrJx5APW0iuE1ZpUBlMy/7QHde4X4Z71uH4cwJI6VTTNTyo1X1QST6 R4200uCPoUtBVupPlYpT3LVKutqBY6eCLGGoaRDXyg2onKXiyysYL3muT12Z7spnKDhtOOaUVtE 73gF7fQQUc46f0pPd4IOoNeCrLxVtgFcqDZY7xQXJA9Xz9CmO/PtbW9d8v7UI3W/SK/TDLXQsCc rnn2IsQyO1gCmVoO+PdIreUtDtAY7QBRenkUIVGXlX/N05jY X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mips@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Philippe Mathieu-Daudé --- drivers/edac/octeon_edac-lmc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/edac/octeon_edac-lmc.c b/drivers/edac/octeon_edac-lmc.c index aeb222ca3ed1..18615cbcd9ea 100644 --- a/drivers/edac/octeon_edac-lmc.c +++ b/drivers/edac/octeon_edac-lmc.c @@ -302,18 +302,17 @@ static int octeon_lmc_edac_probe(struct platform_device *pdev) return 0; } -static int octeon_lmc_edac_remove(struct platform_device *pdev) +static void octeon_lmc_edac_remove(struct platform_device *pdev) { struct mem_ctl_info *mci = platform_get_drvdata(pdev); edac_mc_del_mc(&pdev->dev); edac_mc_free(mci); - return 0; } static struct platform_driver octeon_lmc_edac_driver = { .probe = octeon_lmc_edac_probe, - .remove = octeon_lmc_edac_remove, + .remove_new = octeon_lmc_edac_remove, .driver = { .name = "octeon_lmc_edac", }