| Message ID | 20240125113623.2043061-2-maobibo@loongson.cn (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | irqchip/loongson-eiointc: Refine irq affinity setting during resume | expand |
Hi, Bibo, We usually use eiointc_domain_alloc() rather than eiointc_domain_alloc to describe a function, but it is not a big issue. If you will update a new version you can modify this. Huacai On Thu, Jan 25, 2024 at 7:36 PM Bibo Mao <maobibo@loongson.cn> wrote: > > There is small typo in function eiointc_domain_alloc, and there is no > definition about struct eiointc, instead it should be struct eiointc_priv. > It is strange that there is no warning with gcc compiler. This patch > fixes the typo issue. > > Signed-off-by: Bibo Mao <maobibo@loongson.cn> > Acked-by: Huacai Chen <chenhuacai@loongson.cn> > --- > drivers/irqchip/irq-loongson-eiointc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-loongson-eiointc.c b/drivers/irqchip/irq-loongson-eiointc.c > index 1623cd779175..b3736bdd4b9f 100644 > --- a/drivers/irqchip/irq-loongson-eiointc.c > +++ b/drivers/irqchip/irq-loongson-eiointc.c > @@ -241,7 +241,7 @@ static int eiointc_domain_alloc(struct irq_domain *domain, unsigned int virq, > int ret; > unsigned int i, type; > unsigned long hwirq = 0; > - struct eiointc *priv = domain->host_data; > + struct eiointc_priv *priv = domain->host_data; > > ret = irq_domain_translate_onecell(domain, arg, &hwirq, &type); > if (ret) > -- > 2.39.3 >
On 2024/1/29 下午8:23, Huacai Chen wrote: > Hi, Bibo, > > We usually use eiointc_domain_alloc() rather than eiointc_domain_alloc > to describe a function, but it is not a big issue. If you will update > a new version you can modify this. sure, will do. Regards Bibo Mao > > Huacai > > On Thu, Jan 25, 2024 at 7:36 PM Bibo Mao <maobibo@loongson.cn> wrote: >> >> There is small typo in function eiointc_domain_alloc, and there is no >> definition about struct eiointc, instead it should be struct eiointc_priv. >> It is strange that there is no warning with gcc compiler. This patch >> fixes the typo issue. >> >> Signed-off-by: Bibo Mao <maobibo@loongson.cn> >> Acked-by: Huacai Chen <chenhuacai@loongson.cn> >> --- >> drivers/irqchip/irq-loongson-eiointc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/irqchip/irq-loongson-eiointc.c b/drivers/irqchip/irq-loongson-eiointc.c >> index 1623cd779175..b3736bdd4b9f 100644 >> --- a/drivers/irqchip/irq-loongson-eiointc.c >> +++ b/drivers/irqchip/irq-loongson-eiointc.c >> @@ -241,7 +241,7 @@ static int eiointc_domain_alloc(struct irq_domain *domain, unsigned int virq, >> int ret; >> unsigned int i, type; >> unsigned long hwirq = 0; >> - struct eiointc *priv = domain->host_data; >> + struct eiointc_priv *priv = domain->host_data; >> >> ret = irq_domain_translate_onecell(domain, arg, &hwirq, &type); >> if (ret) >> -- >> 2.39.3 >>
diff --git a/drivers/irqchip/irq-loongson-eiointc.c b/drivers/irqchip/irq-loongson-eiointc.c index 1623cd779175..b3736bdd4b9f 100644 --- a/drivers/irqchip/irq-loongson-eiointc.c +++ b/drivers/irqchip/irq-loongson-eiointc.c @@ -241,7 +241,7 @@ static int eiointc_domain_alloc(struct irq_domain *domain, unsigned int virq, int ret; unsigned int i, type; unsigned long hwirq = 0; - struct eiointc *priv = domain->host_data; + struct eiointc_priv *priv = domain->host_data; ret = irq_domain_translate_onecell(domain, arg, &hwirq, &type); if (ret)