diff mbox series

[v3,1/3] mips: dts: ralink: mt7621: associate uart1_pins with serial0

Message ID 20240308155616.11742-2-justin.swartz@risingedge.co.za (mailing list archive)
State Accepted
Headers show
Series Extend devicetree coverage of MT7621's UART interfaces | expand

Commit Message

Justin Swartz March 8, 2024, 3:56 p.m. UTC 
Add missing pinctrl-name and pinctrl-0 properties to declare
that the uart1_pins group is associated with serial0.

Acked-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Justin Swartz <justin.swartz@risingedge.co.za>
---
 arch/mips/boot/dts/ralink/mt7621.dtsi | 3 +++
 1 file changed, 3 insertions(+)

--

Comments

Arınç ÜNAL March 8, 2024, 4:14 p.m. UTC | #1 
On 08/03/2024 18:56, Justin Swartz wrote:
> Add missing pinctrl-name and pinctrl-0 properties to declare
> that the uart1_pins group is associated with serial0.
> 
> Acked-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> Signed-off-by: Justin Swartz <justin.swartz@risingedge.co.za>

Reviewed-by: Arınç ÜNAL <arinc.unal@arinc9.com>

Please add the trailers from previous patch versions from now on.

Arınç
Justin Swartz March 8, 2024, 5:01 p.m. UTC | #2 
On 2024-03-08 18:14, Arınç ÜNAL wrote:
> On 08/03/2024 18:56, Justin Swartz wrote:
>> Add missing pinctrl-name and pinctrl-0 properties to declare
>> that the uart1_pins group is associated with serial0.
>> 
>> Acked-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
>> Signed-off-by: Justin Swartz <justin.swartz@risingedge.co.za>
> 
> Reviewed-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> 
> Please add the trailers from previous patch versions from now on.

What do you mean by trailers?

Regards
Justin
Krzysztof Kozlowski March 8, 2024, 5:13 p.m. UTC | #3 
On 08/03/2024 18:01, Justin Swartz wrote:
> On 2024-03-08 18:14, Arınç ÜNAL wrote:
>> On 08/03/2024 18:56, Justin Swartz wrote:
>>> Add missing pinctrl-name and pinctrl-0 properties to declare
>>> that the uart1_pins group is associated with serial0.
>>>
>>> Acked-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
>>> Signed-off-by: Justin Swartz <justin.swartz@risingedge.co.za>
>>
>> Reviewed-by: Arınç ÜNAL <arinc.unal@arinc9.com>
>>
>> Please add the trailers from previous patch versions from now on.
> 
> What do you mean by trailers?

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

Best regards,
Krzysztof
Justin Swartz March 8, 2024, 5:19 p.m. UTC | #4 
On 2024-03-08 19:13, Krzysztof Kozlowski wrote:
> On 08/03/2024 18:01, Justin Swartz wrote:
>> On 2024-03-08 18:14, Arınç ÜNAL wrote:
>>> On 08/03/2024 18:56, Justin Swartz wrote:
>>>> Add missing pinctrl-name and pinctrl-0 properties to declare
>>>> that the uart1_pins group is associated with serial0.
>>>> 
>>>> Acked-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
>>>> Signed-off-by: Justin Swartz <justin.swartz@risingedge.co.za>
>>> 
>>> Reviewed-by: Arınç ÜNAL <arinc.unal@arinc9.com>
>>> 
>>> Please add the trailers from previous patch versions from now on.
>> 
>> What do you mean by trailers?
> 
> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

Thanks, Krzysztof.

I thought I had done this with this patchset on all three patches,
but if I've accidentally left anyone out - sorry about that.

Regards
Justin
diff mbox series

Patch

diff --git a/arch/mips/boot/dts/ralink/mt7621.dtsi b/arch/mips/boot/dts/ralink/mt7621.dtsi
index 35a10258f..dca415fdd 100644
--- a/arch/mips/boot/dts/ralink/mt7621.dtsi
+++ b/arch/mips/boot/dts/ralink/mt7621.dtsi
@@ -123,6 +123,9 @@  serial0: serial@c00 {
 			reg-shift = <2>;
 			reg-io-width = <4>;
 			no-loopback-test;
+
+			pinctrl-names = "default";
+			pinctrl-0 = <&uart1_pins>;
 		};
 
 		spi0: spi@b00 {