| Message ID | 20240308161130.12228-1-justin.swartz@risingedge.co.za (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v3] mips: dts: ralink: mt7621: add cell count properties to usb | expand |
On 08/03/2024 19:11, Justin Swartz wrote: > Add default #address-cells and #size-cells properties to the > usb node, which should be suitable for hubs and devices without > explicitly declared interface nodes, as: > > "#address-cells": > description: should be 1 for hub nodes with device nodes, > should be 2 for device nodes with interface nodes. > enum: [1, 2] > > "#size-cells": > const: 0 > > -- from Documentation/devicetree/bindings/usb/usb-device.yaml > > Acked-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> > Signed-off-by: Justin Swartz <justin.swartz@risingedge.co.za> Reviewed-by: Arınç ÜNAL <arinc.unal@arinc9.com> Arınç
On Fri, Mar 08, 2024 at 06:11:30PM +0200, Justin Swartz wrote: > Add default #address-cells and #size-cells properties to the > usb node, which should be suitable for hubs and devices without > explicitly declared interface nodes, as: > > "#address-cells": > description: should be 1 for hub nodes with device nodes, > should be 2 for device nodes with interface nodes. > enum: [1, 2] > > "#size-cells": > const: 0 > > -- from Documentation/devicetree/bindings/usb/usb-device.yaml > > Acked-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> > Signed-off-by: Justin Swartz <justin.swartz@risingedge.co.za> > --- > v2 -> v3: Patch revision commentary removed from commit message > as instructed by Sergio Paracuellos. > > v1 -> v2: Reorder the properties according to > Documentation/devicetree/bindings/dts-coding-style.rst > > arch/mips/boot/dts/ralink/mt7621.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/mips/boot/dts/ralink/mt7621.dtsi b/arch/mips/boot/dts/ralink/mt7621.dtsi > index 02e1f2491..6e95e6f19 100644 > --- a/arch/mips/boot/dts/ralink/mt7621.dtsi > +++ b/arch/mips/boot/dts/ralink/mt7621.dtsi > @@ -307,6 +307,9 @@ usb: usb@1e1c0000 { > 0x1e1d0700 0x0100>; > reg-names = "mac", "ippc"; > > + #address-cells = <1>; > + #size-cells = <0>; > + > clocks = <&sysc MT7621_CLK_XTAL>; > clock-names = "sys_ck"; > > -- applied to mips-next. Thomas.
diff --git a/arch/mips/boot/dts/ralink/mt7621.dtsi b/arch/mips/boot/dts/ralink/mt7621.dtsi index 02e1f2491..6e95e6f19 100644 --- a/arch/mips/boot/dts/ralink/mt7621.dtsi +++ b/arch/mips/boot/dts/ralink/mt7621.dtsi @@ -307,6 +307,9 @@ usb: usb@1e1c0000 { 0x1e1d0700 0x0100>; reg-names = "mac", "ippc"; + #address-cells = <1>; + #size-cells = <0>; + clocks = <&sysc MT7621_CLK_XTAL>; clock-names = "sys_ck";
Add default #address-cells and #size-cells properties to the usb node, which should be suitable for hubs and devices without explicitly declared interface nodes, as: "#address-cells": description: should be 1 for hub nodes with device nodes, should be 2 for device nodes with interface nodes. enum: [1, 2] "#size-cells": const: 0 -- from Documentation/devicetree/bindings/usb/usb-device.yaml Acked-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by: Justin Swartz <justin.swartz@risingedge.co.za> --- v2 -> v3: Patch revision commentary removed from commit message as instructed by Sergio Paracuellos. v1 -> v2: Reorder the properties according to Documentation/devicetree/bindings/dts-coding-style.rst arch/mips/boot/dts/ralink/mt7621.dtsi | 3 +++ 1 file changed, 3 insertions(+) --