| Message ID | 20240315022923.178593-1-zhangyongzhen@kylinos.cn (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 34059321f4cf541d69e733cd02882d62c489bb77 |
| Headers | show |
| Series | MIPS: BCM47XX: include header for bcm47xx_prom_highmem_init() prototype | expand |
On 15/3/24 03:29, Yongzhen Zhang wrote: > bcm47xx_prom_highmem_init() is a global function declared in > arch/mips/bcm47xx/bcm47xx_private.h, but this header is not > included before the definition, causing a error: > > arch/mips/bcm47xx/prom.c:134:13: error: no previous prototype for ‘bcm47xx_prom_highmem_init’ [-Werror=missing-prototypes] > 134 | void __init bcm47xx_prom_highmem_init(void) > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > > Signed-off-by: Yongzhen Zhang <zhangyongzhen@kylinos.cn> > --- > arch/mips/bcm47xx/prom.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
On Fri, Mar 15, 2024 at 10:29:23AM +0800, Yongzhen Zhang wrote: > bcm47xx_prom_highmem_init() is a global function declared in > arch/mips/bcm47xx/bcm47xx_private.h, but this header is not > included before the definition, causing a error: > > arch/mips/bcm47xx/prom.c:134:13: error: no previous prototype for ‘bcm47xx_prom_highmem_init’ [-Werror=missing-prototypes] > 134 | void __init bcm47xx_prom_highmem_init(void) > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > > Signed-off-by: Yongzhen Zhang <zhangyongzhen@kylinos.cn> > --- > arch/mips/bcm47xx/prom.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/mips/bcm47xx/prom.c b/arch/mips/bcm47xx/prom.c > index 99a1ba5394e0..7344a5eb990e 100644 > --- a/arch/mips/bcm47xx/prom.c > +++ b/arch/mips/bcm47xx/prom.c > @@ -35,6 +35,7 @@ > #include <asm/bootinfo.h> > #include <bcm47xx.h> > #include <bcm47xx_board.h> > +#include "bcm47xx_private.h" > > static char bcm47xx_system_type[20] = "Broadcom BCM47XX"; > > -- > 2.34.1 applied to mips-next. Thomas.
diff --git a/arch/mips/bcm47xx/prom.c b/arch/mips/bcm47xx/prom.c index 99a1ba5394e0..7344a5eb990e 100644 --- a/arch/mips/bcm47xx/prom.c +++ b/arch/mips/bcm47xx/prom.c @@ -35,6 +35,7 @@ #include <asm/bootinfo.h> #include <bcm47xx.h> #include <bcm47xx_board.h> +#include "bcm47xx_private.h" static char bcm47xx_system_type[20] = "Broadcom BCM47XX";
bcm47xx_prom_highmem_init() is a global function declared in arch/mips/bcm47xx/bcm47xx_private.h, but this header is not included before the definition, causing a error: arch/mips/bcm47xx/prom.c:134:13: error: no previous prototype for ‘bcm47xx_prom_highmem_init’ [-Werror=missing-prototypes] 134 | void __init bcm47xx_prom_highmem_init(void) | ^~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Yongzhen Zhang <zhangyongzhen@kylinos.cn> --- arch/mips/bcm47xx/prom.c | 1 + 1 file changed, 1 insertion(+)