| Message ID | 20240327130538.680256-4-david@redhat.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | mm/gup: consistently call it GUP-fast | expand |
On Wed, Mar 27, 2024 at 02:05:38PM +0100, David Hildenbrand wrote: > Let's fixup the remaining comments to consistently call that thing > "GUP-fast". With this change, we consistently call it "GUP-fast". > > Signed-off-by: David Hildenbrand <david@redhat.com> Reviewed-by: Mike Rapoport (IBM) <rppt@kernel.org> > --- > mm/filemap.c | 2 +- > mm/khugepaged.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/filemap.c b/mm/filemap.c > index 387b394754fa..c668e11cd6ef 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -1810,7 +1810,7 @@ EXPORT_SYMBOL(page_cache_prev_miss); > * C. Return the page to the page allocator > * > * This means that any page may have its reference count temporarily > - * increased by a speculative page cache (or fast GUP) lookup as it can > + * increased by a speculative page cache (or GUP-fast) lookup as it can > * be allocated by another user before the RCU grace period expires. > * Because the refcount temporarily acquired here may end up being the > * last refcount on the page, any page allocation must be freeable by > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index 38830174608f..6972fa05132e 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -1169,7 +1169,7 @@ static int collapse_huge_page(struct mm_struct *mm, unsigned long address, > * huge and small TLB entries for the same virtual address to > * avoid the risk of CPU bugs in that area. > * > - * Parallel fast GUP is fine since fast GUP will back off when > + * Parallel GUP-fast is fine since GUP-fast will back off when > * it detects PMD is changed. > */ > _pmd = pmdp_collapse_flush(vma, address, pmd); > -- > 2.43.2 >
diff --git a/mm/filemap.c b/mm/filemap.c index 387b394754fa..c668e11cd6ef 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -1810,7 +1810,7 @@ EXPORT_SYMBOL(page_cache_prev_miss); * C. Return the page to the page allocator * * This means that any page may have its reference count temporarily - * increased by a speculative page cache (or fast GUP) lookup as it can + * increased by a speculative page cache (or GUP-fast) lookup as it can * be allocated by another user before the RCU grace period expires. * Because the refcount temporarily acquired here may end up being the * last refcount on the page, any page allocation must be freeable by diff --git a/mm/khugepaged.c b/mm/khugepaged.c index 38830174608f..6972fa05132e 100644 --- a/mm/khugepaged.c +++ b/mm/khugepaged.c @@ -1169,7 +1169,7 @@ static int collapse_huge_page(struct mm_struct *mm, unsigned long address, * huge and small TLB entries for the same virtual address to * avoid the risk of CPU bugs in that area. * - * Parallel fast GUP is fine since fast GUP will back off when + * Parallel GUP-fast is fine since GUP-fast will back off when * it detects PMD is changed. */ _pmd = pmdp_collapse_flush(vma, address, pmd);
Let's fixup the remaining comments to consistently call that thing "GUP-fast". With this change, we consistently call it "GUP-fast". Signed-off-by: David Hildenbrand <david@redhat.com> --- mm/filemap.c | 2 +- mm/khugepaged.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)