| Message ID | 20241106-mbly-clk-v2-1-84cfefb3f485@bootlin.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Usable clocks on Mobileye EyeQ5 & EyeQ6H | expand |
On 06/11/2024 17:03, Théo Lebrun wrote: > Some compatibles expose a single clock. For those, we used to let them > using `#clock-cells = <0>` (ie <&olb> reference rather than <&olb 0>). > > Switch away from that: enforce a cell for all compatibles. This is more > straight forward, and avoids devicetree changes whenever a compatible > goes from exposing a single clock to multiple ones. Also, dt-bindings > get simpler. > > *This is an ABI break*. Change it while EyeQ5 platform support is at its > infancy, without any user. More clocks might hide in each OLB as some > registers are still unknown. > > Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Wed, 06 Nov 2024 17:03:52 +0100, Théo Lebrun wrote: > Some compatibles expose a single clock. For those, we used to let them > using `#clock-cells = <0>` (ie <&olb> reference rather than <&olb 0>). > > Switch away from that: enforce a cell for all compatibles. This is more > straight forward, and avoids devicetree changes whenever a compatible > goes from exposing a single clock to multiple ones. Also, dt-bindings > get simpler. > > *This is an ABI break*. Change it while EyeQ5 platform support is at its > infancy, without any user. More clocks might hide in each OLB as some > registers are still unknown. > > Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> > --- > .../bindings/soc/mobileye/mobileye,eyeq5-olb.yaml | 24 +--------------------- > 1 file changed, 1 insertion(+), 23 deletions(-) > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Quoting Théo Lebrun (2024-11-06 08:03:52) > Some compatibles expose a single clock. For those, we used to let them > using `#clock-cells = <0>` (ie <&olb> reference rather than <&olb 0>). > > Switch away from that: enforce a cell for all compatibles. This is more > straight forward, and avoids devicetree changes whenever a compatible > goes from exposing a single clock to multiple ones. Also, dt-bindings > get simpler. > > *This is an ABI break*. Change it while EyeQ5 platform support is at its > infancy, without any user. More clocks might hide in each OLB as some > registers are still unknown. > > Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> > --- Applied to clk-next
diff --git a/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml b/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml index f7e606d45ebcfc46ffe076e23a2ed514bfff9b8f..6d11472ba5a704d5d20f43776e5867f507a39242 100644 --- a/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml +++ b/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml @@ -41,9 +41,7 @@ properties: enum: [ 1, 2 ] '#clock-cells': - description: - Cell is clock index. Optional if compatible has a single clock. - enum: [ 0, 1 ] + const: 1 clocks: maxItems: 1 @@ -312,26 +310,6 @@ allOf: properties: '#reset-cells': false - # Compatibles exposing a single clock. - - if: - properties: - compatible: - contains: - enum: - - mobileye,eyeq6h-central-olb - - mobileye,eyeq6h-east-olb - - mobileye,eyeq6h-west-olb - - mobileye,eyeq6h-ddr0-olb - - mobileye,eyeq6h-ddr1-olb - then: - properties: - '#clock-cells': - const: 0 - else: - properties: - '#clock-cells': - const: 1 - # Only EyeQ5 has pinctrl in OLB. - if: not:
Some compatibles expose a single clock. For those, we used to let them using `#clock-cells = <0>` (ie <&olb> reference rather than <&olb 0>). Switch away from that: enforce a cell for all compatibles. This is more straight forward, and avoids devicetree changes whenever a compatible goes from exposing a single clock to multiple ones. Also, dt-bindings get simpler. *This is an ABI break*. Change it while EyeQ5 platform support is at its infancy, without any user. More clocks might hide in each OLB as some registers are still unknown. Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> --- .../bindings/soc/mobileye/mobileye,eyeq5-olb.yaml | 24 +--------------------- 1 file changed, 1 insertion(+), 23 deletions(-)