| Message ID | 20250115090134.918023-2-thorsten.blum@linux.dev (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a3c4afc0e081f8b6b5a744afb3f69c88288d218e |
| Headers | show |
| Series | MIPS: Loongson64: env: Use str_on_off() helper in prom_lefi_init_env() | expand |
On Wed, Jan 15, 2025 at 10:01:35AM +0100, Thorsten Blum wrote: > Remove hard-coded strings by using the str_on_off() helper function. > > Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> > --- > arch/mips/loongson64/env.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/mips/loongson64/env.c b/arch/mips/loongson64/env.c > index 09ff05269861..be8d2ad10750 100644 > --- a/arch/mips/loongson64/env.c > +++ b/arch/mips/loongson64/env.c > @@ -17,6 +17,7 @@ > #include <linux/dma-map-ops.h> > #include <linux/export.h> > #include <linux/pci_ids.h> > +#include <linux/string_choices.h> > #include <asm/bootinfo.h> > #include <loongson.h> > #include <boot_param.h> > @@ -162,7 +163,7 @@ void __init prom_lefi_init_env(void) > dma_default_coherent = !eirq_source->dma_noncoherent; > } > > - pr_info("Firmware: Coherent DMA: %s\n", dma_default_coherent ? "on" : "off"); > + pr_info("Firmware: Coherent DMA: %s\n", str_on_off(dma_default_coherent)); > > loongson_sysconf.restart_addr = boot_p->reset_system.ResetWarm; > loongson_sysconf.poweroff_addr = boot_p->reset_system.Shutdown; > -- > 2.47.1 applied to mips-next. Thomas.
diff --git a/arch/mips/loongson64/env.c b/arch/mips/loongson64/env.c index 09ff05269861..be8d2ad10750 100644 --- a/arch/mips/loongson64/env.c +++ b/arch/mips/loongson64/env.c @@ -17,6 +17,7 @@ #include <linux/dma-map-ops.h> #include <linux/export.h> #include <linux/pci_ids.h> +#include <linux/string_choices.h> #include <asm/bootinfo.h> #include <loongson.h> #include <boot_param.h> @@ -162,7 +163,7 @@ void __init prom_lefi_init_env(void) dma_default_coherent = !eirq_source->dma_noncoherent; } - pr_info("Firmware: Coherent DMA: %s\n", dma_default_coherent ? "on" : "off"); + pr_info("Firmware: Coherent DMA: %s\n", str_on_off(dma_default_coherent)); loongson_sysconf.restart_addr = boot_p->reset_system.ResetWarm; loongson_sysconf.poweroff_addr = boot_p->reset_system.Shutdown;
Remove hard-coded strings by using the str_on_off() helper function. Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> --- arch/mips/loongson64/env.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)