| Message ID | ZxDVRru_o_5nqGl5@mail.google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 81205381c4facb00755b5e572aa70e6cc70db4d4 |
| Headers | show |
| Series | [v2,next] mips: sgi-ip22: Replace "s[n]?printf" with sysfs_emit in sysfs callbacks | expand |
On Thu, 17 Oct 2024, Paulo Miguel Almeida wrote: > Replace open-coded pieces with sysfs_emit() helper in sysfs .show() > callbacks. > > Signed-off-by: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com> > --- > Changelog: > - v2: amend commit message (Req: Maciej W. Rozycki) > - v1: https://lore.kernel.org/lkml/Zw2GRQkbx8Z8DlcS@mail.google.com/ > --- Reviewed-by: Maciej W. Rozycki <macro@orcam.me.uk> Thank you for this update. Maciej
On Thu, Oct 17, 2024 at 10:13:42PM +1300, Paulo Miguel Almeida wrote: > Replace open-coded pieces with sysfs_emit() helper in sysfs .show() > callbacks. > > Signed-off-by: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com> > --- > Changelog: > - v2: amend commit message (Req: Maciej W. Rozycki) > - v1: https://lore.kernel.org/lkml/Zw2GRQkbx8Z8DlcS@mail.google.com/ > --- > arch/mips/sgi-ip22/ip22-gio.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) applied to mips-next. Thomas.
diff --git a/arch/mips/sgi-ip22/ip22-gio.c b/arch/mips/sgi-ip22/ip22-gio.c index d20eec742bfa..5893ea4e382c 100644 --- a/arch/mips/sgi-ip22/ip22-gio.c +++ b/arch/mips/sgi-ip22/ip22-gio.c @@ -165,9 +165,8 @@ static ssize_t modalias_show(struct device *dev, struct device_attribute *a, char *buf) { struct gio_device *gio_dev = to_gio_device(dev); - int len = snprintf(buf, PAGE_SIZE, "gio:%x\n", gio_dev->id.id); - return (len >= PAGE_SIZE) ? (PAGE_SIZE - 1) : len; + return sysfs_emit(buf, "gio:%x\n", gio_dev->id.id); } static DEVICE_ATTR_RO(modalias); @@ -177,7 +176,7 @@ static ssize_t name_show(struct device *dev, struct gio_device *giodev; giodev = to_gio_device(dev); - return sprintf(buf, "%s", giodev->name); + return sysfs_emit(buf, "%s\n", giodev->name); } static DEVICE_ATTR_RO(name); @@ -187,7 +186,7 @@ static ssize_t id_show(struct device *dev, struct gio_device *giodev; giodev = to_gio_device(dev); - return sprintf(buf, "%x", giodev->id.id); + return sysfs_emit(buf, "%x\n", giodev->id.id); } static DEVICE_ATTR_RO(id);
Replace open-coded pieces with sysfs_emit() helper in sysfs .show() callbacks. Signed-off-by: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com> --- Changelog: - v2: amend commit message (Req: Maciej W. Rozycki) - v1: https://lore.kernel.org/lkml/Zw2GRQkbx8Z8DlcS@mail.google.com/ --- arch/mips/sgi-ip22/ip22-gio.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)