| Message ID | e30eb541f2fc615b264a70af2f40a5f9@208suo.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | MIPS: prefer 'unsigned int' to bare use of 'unsigned' | expand |
On 9/7/23 16:19, xuanzhenggang001@208suo.com wrote: > Fix the following warnings reported by checkpatch: > > arch/mips/kernel/linux32.c:128: WARNING: Prefer 'unsigned int' to bare > use of 'unsigned' > arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare > use of 'unsigned' > arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare > use of 'unsigned' > arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare > use of 'unsigned' > > Signed-off-by: Zhenggang Xuan <xuanzhenggang001@208suo.com> > --- > arch/mips/kernel/linux32.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
On Sun, Jul 09, 2023 at 10:19:50PM +0800, xuanzhenggang001@208suo.com wrote: > Fix the following warnings reported by checkpatch: > > arch/mips/kernel/linux32.c:128: WARNING: Prefer 'unsigned int' to bare use > of 'unsigned' > arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare use > of 'unsigned' > arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare use > of 'unsigned' > arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare use > of 'unsigned' > > Signed-off-by: Zhenggang Xuan <xuanzhenggang001@208suo.com> > --- > arch/mips/kernel/linux32.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/mips/kernel/linux32.c b/arch/mips/kernel/linux32.c > index 6b61be486303..4bd52b38dd00 100644 > --- a/arch/mips/kernel/linux32.c > +++ b/arch/mips/kernel/linux32.c > @@ -125,8 +125,8 @@ asmlinkage long sys32_fadvise64_64(int fd, int __pad, > flags); > } > > -asmlinkage long sys32_fallocate(int fd, int mode, unsigned offset_a2, > - unsigned offset_a3, unsigned len_a4, unsigned len_a5) > +asmlinkage long sys32_fallocate(int fd, int mode, unsigned int offset_a2, > + unsigned int offset_a3, unsigned int len_a4, unsigned int len_a5) > { > return ksys_fallocate(fd, mode, merge_64(offset_a2, offset_a3), > merge_64(len_a4, len_a5)); this is white-space damaged, please resend with that corrected. Thomas.
diff --git a/arch/mips/kernel/linux32.c b/arch/mips/kernel/linux32.c index 6b61be486303..4bd52b38dd00 100644 --- a/arch/mips/kernel/linux32.c +++ b/arch/mips/kernel/linux32.c @@ -125,8 +125,8 @@ asmlinkage long sys32_fadvise64_64(int fd, int __pad, flags); } -asmlinkage long sys32_fallocate(int fd, int mode, unsigned offset_a2, - unsigned offset_a3, unsigned len_a4, unsigned len_a5) +asmlinkage long sys32_fallocate(int fd, int mode, unsigned int offset_a2, + unsigned int offset_a3, unsigned int len_a4, unsigned int len_a5) {
Fix the following warnings reported by checkpatch: arch/mips/kernel/linux32.c:128: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by: Zhenggang Xuan <xuanzhenggang001@208suo.com> --- arch/mips/kernel/linux32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) return ksys_fallocate(fd, mode, merge_64(offset_a2, offset_a3), merge_64(len_a4, len_a5));