mbox series

[net-next,mlxsw,v2,0/3] mlxsw: Enable MC-aware mode for mlxsw ports

Message ID cover.1533133664.git.petrm@mellanox.com (mailing list archive)
Headers show
Series mlxsw: Enable MC-aware mode for mlxsw ports | expand

Message

Petr Machata Aug. 1, 2018, 2:29 p.m. UTC
Due to an issue in Spectrum chips, when unicast traffic shares the same
queue as BUM traffic, and there is a congestion, the BUM traffic is
admitted to the queue anyway, thus pushing out all UC traffic. In order
to give unicast traffic precedence over BUM traffic, configure
multicast-aware mode on all ports.

Under multicast-aware regime, when assigning traffic class to a packet,
the switch doesn't merely take the value prescribed by the QTCT
register. For BUM traffic, it instead assigns that value plus 8. That
limits the number of available TCs, but since mlxsw currently only uses
the lower eight anyway, it is no real loss.

The two TCs (UC and MC one) are then mapped to the same subgroup and
strictly prioritized so that UC traffic is preferred in case of
congestion.

In patch #1, introduce a new register, QTCTM, which enables the
multicast-aware mode.

In patch #2, fix a typo in related code.

In patch #3, set up TCs and QTCTM to enable multicast-aware mode.

Changes from v1 to v2:

- In patch #3, disable MC mode again on error path of
  mlxsw_sp_port_create() and in mlxsw_sp_port_remove().

Petr Machata (3):
  mlxsw: reg: Add QoS Switch Traffic Class Table is Multicast-Aware
    Register
  mlxsw: spectrum: Fix a typo
  mlxsw: spectrum: Configure MC-aware mode on mlxsw ports

 drivers/net/ethernet/mellanox/mlxsw/reg.h      | 37 ++++++++++++++++++++++++++
 drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 29 +++++++++++++++++++-
 2 files changed, 65 insertions(+), 1 deletion(-)