| Message ID | 72ffc13424de1e5a9b3dada6a6b62e0e2525f722.1526996911.git.petrm@mellanox.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Ido Schimmel |
| Headers | show
Return-Path: <linux-mlxsw-bounces+patchwork-linux-mlxsw=patchwork.kernel.org@lists.ozlabs.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5C97C6053B for <patchwork-linux-mlxsw@patchwork.kernel.org>; Tue, 22 May 2018 13:50:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4A8AB28CDA for <patchwork-linux-mlxsw@patchwork.kernel.org>; Tue, 22 May 2018 13:50:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3D20928D18; Tue, 22 May 2018 13:50:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED, MAILING_LIST_MULTI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3D20228CDA for <patchwork-linux-mlxsw@patchwork.kernel.org>; Tue, 22 May 2018 13:50:06 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 40qxq00P7FzDqp5 for <patchwork-linux-mlxsw@patchwork.kernel.org>; Tue, 22 May 2018 23:50:03 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=mellanox.com Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.b="IOZOe6DJ"; dkim-atps=neutral X-Original-To: linux-mlxsw@lists.ozlabs.org Delivered-To: linux-mlxsw@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=mellanox.com (client-ip=104.47.2.73; helo=eur01-db5-obe.outbound.protection.outlook.com; envelope-from=petrm@mellanox.com; receiver=<UNKNOWN>) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=mellanox.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.b="IOZOe6DJ"; dkim-atps=neutral Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0073.outbound.protection.outlook.com [104.47.2.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 40qxpp4fgFzDqgs for <linux-mlxsw@lists.ozlabs.org>; Tue, 22 May 2018 23:49:52 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TG6cikfW1M6VhP4p9PxJUU3t+t7rXguSnXYuvRqtgc8=; b=IOZOe6DJ42FQqY3R7GvKUkF1FnbGyobplg99KboQ1mrbreHIq7zx1HCiqgxKwVkRk8we28a1IhrARfjm6uap842APmT40qDasa3EGoH+6SZcoKkA8hqWxMdSuGwArLqEx0qVsB2+8cmKk8irwM0oF3JiCPPpcS/11cmQ7918jpI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=petrm@mellanox.com; Received: from t540p (78.45.160.211) by AM0PR05MB4179.eurprd05.prod.outlook.com (2603:10a6:208:57::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.776.16; Tue, 22 May 2018 13:49:46 +0000 From: Petr Machata <petrm@mellanox.com> To: <linux-internal@mellanox.com> Subject: [PATCH net mlxsw] mlxsw: spectrum: Forbid creation of VLAN 1 over port/LAG Message-Id: <72ffc13424de1e5a9b3dada6a6b62e0e2525f722.1526996911.git.petrm@mellanox.com> Date: Tue, 22 May 2018 15:49:30 +0200 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 X-Originating-IP: [78.45.160.211] X-ClientProxiedBy: LO2P265CA0037.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:61::25) To AM0PR05MB4179.eurprd05.prod.outlook.com (2603:10a6:208:57::28) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM0PR05MB4179; X-Microsoft-Exchange-Diagnostics: 1; AM0PR05MB4179; 3:OLbtlspSVNJ8KOKqm7wOXyejLbz2VmDsmaFGTzItkauihu+1RnAE7vCkqRb3p/6en44CMpuNhJJByQcUnX6xC+9mRqlk1+EbgKW9DbcMFdSYri5IEzp4rk1mfNW9YgYz/Xkz5aV/zfCq8YRS4KnEJI78M/AfHgomLZSMrVBMWQYGaW0f9mRADSD5S+j86bprNHfzIU4fx3YuxoqbXiGGXxgOc1bmclF3GIiWxcQbxREq4hNOvCJBQGXuLmeGzmdi; 25:GUYqbegRZDjb1c9s8jKzx7zvysdk6b1uDw7XqvkeOgxr5THJzqsKIOXd8T5YNO3YIpv5w/d0IKJezGbi2WdGT4qAgNWRDgYv/+2bo5jUTOzp9IKeikv8S5/O0amnSpzEbq45n9M2rouJuYapXQgW21v9OPBjSGmXS21SRAwClodc3FL+U8wh9qRxU5LgMGUYdG3I15pPDQB4xFUvvL6LBRB8CsAJmwZo5rzrNEags/TCR/buIP9ddl+IWO8efucMIRq9Z/tOE/i886AEsAelWRG7bjkYo4nE+pBL0HmwIKp71MWCSBONnd7WpVe1oUOj6hg8NFr/jOR2WrDDc9qbXA==; 31:aX8zocjHpZM1fwK2S7azyUD3F5wwGefZ3iR4efWWv+d+W0Juk6jXEqyJSEsBg2V/C7iC+JWsIkttwbOsjmY/3/o6siyf2NLR31w62+chElEffgWB3sVtqYHPPaRi3IDwOIePNDjLFMOpljm5oqrqHv039cVfelTnMmsME/4/ddAO7Z0dSuEOciTosDjI/z0F/kytEsUIiCFnsUCWVYiBqeCywwFmcT1nqupX0c8RDhA= X-MS-TrafficTypeDiagnostic: AM0PR05MB4179: X-Microsoft-Exchange-Diagnostics: 1; AM0PR05MB4179; 20:hgc1xywv3Qbi5mW6/zMq1rQkI8ALEphTUBcXjH+g2aD8JktIMb+rJ5tGttcSV8jV60dpzpRzSv5hTZ1sg65d6zvhzOnqiugS1cFWepq6c0IfH3FJIpE+eCjFVhMR2wf0eRnjPftCU14SQW9E3gngZtufNj4qqlO7JTmTmBqg+5GxfGE6LbFTV/lJAXOsML4yo124pX/WAcqZsSgGdE3pznipvs0xrkX3b5CqmHqjNL2xddUAtOqVb/uS+e7K6FVcOO51aNGQdy4fm17glMuE0Uo5b7dR2DSAR3IubPRwpq3o8tPsPe0poyeudMbsiU2HsFXNDYFUjKaW3f8hAA3HSiXgh7SlKx1pWGYbwUTE9p78v2W1iC03SpC4ZS5o80LQIFE1Kdiv4QQzv6+ffrPfdFUbjQgdfe/mmBqrvHOAoQvs0/PWN4CKk0qvepV7SAmQtrjj0bn04proSBR7S++kIjCqz0XH3qFkkp3AqksRzJdWWHpMXlQzmF8ArciwLwxX; 4:LXiC/GOQCTyJYaBc3R3teBXuLxo8UwPWtYHx0L1YfoqYm3IPxaly0KcUM1MwQu5gJ2cmtqMBKepin8No95mA8zlg5UOEJhtVhysBwebvO1Vh2B3+t2i+eWlmyfC4IgV6+fXFtKz5T2Clw/kqJRwr2nE7r3byG80sHExPz6EfG81PkzLtrP8IzPomNOukqlO6sz1TY97d1bH/lJYQOxVXTqkOQUEDWmi4eO7MYWv0yl+xXFYGXq9lEdPY/zVcvDX2kzwgOE8wMks32okgFves8Q== X-Microsoft-Antispam-PRVS: <AM0PR05MB4179A41D28316BBDE261BAD1DB940@AM0PR05MB4179.eurprd05.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(3231254)(944501410)(52105095)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM0PR05MB4179; BCL:0; PCL:0; RULEID:; SRVR:AM0PR05MB4179; X-Forefront-PRVS: 0680FADD48 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(346002)(39380400002)(366004)(396003)(39860400002)(189003)(199004)(6496006)(81156014)(118296001)(478600001)(53936002)(6486002)(2351001)(59450400001)(305945005)(386003)(52116002)(8676002)(8936002)(51416003)(6666003)(81166006)(68736007)(7736002)(48376002)(16586007)(5660300001)(50466002)(316002)(6862004)(6636002)(25786009)(58126008)(37006003)(86362001)(2906002)(476003)(2616005)(26005)(186003)(66066001)(36756003)(97736004)(47776003)(486006)(16526019)(3846002)(6116002)(956004)(106356001)(105586002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB4179; H:t540p; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM0PR05MB4179; 23:wjXQ+2B9j3qxbORDn/bg5r1TdzptU8bI1gJSi+fwN?= =?us-ascii?Q?/0Gsrqxf4Q0hnrhmEgNST7x4hibpXDRoU3MV+j1bntbRDbChqZqz/Wgkv1Ef?= =?us-ascii?Q?pbo7TQsjJ7FtIZr3kfPTW2+N9gBOiXS0oZvRVeP0lMNt1LoFMMY/4rAlvXxi?= =?us-ascii?Q?bp60hjEPRx09Qgk2m5yidLx2frYd30/gANxpsBHMrtFul6eMb7RVm1rWP7N0?= =?us-ascii?Q?cpMiag9QEQF9DMDr3A27IJPmM/Q9d/bPnk8Zf7KYIhY78IT0J/w+1hGCGdlM?= =?us-ascii?Q?2VcSt6bfNUEloXXJ0+t+H2ubl+Fvdmhgysjet/SESzUM24eGKJqlugm8ImRq?= =?us-ascii?Q?kCY0yMQUJWN306Zja1rC2EP9pPKyCkwsdgJ/L0d4R7BXYPPTauCk77sE14eD?= =?us-ascii?Q?jR4Yko7dYJ4bUTF9/TQ9YAUymfU14+VeC3sF+AuwdKJ3yyFtHBLBIn21sEM8?= =?us-ascii?Q?kT7Wkxm5OVKaJuDL7cdqehh9cBWx2OsDegfc3TVnRwFtV9Zns6OT7TyQFQYs?= =?us-ascii?Q?L7iT1NW+cNNls61Y9iiGpelJCOoQaobsy+NZz7OE7Mav2x/UH0YK8WUwGDfI?= =?us-ascii?Q?qPy71zQ/tqOaYIakLbyTb0cYBvdhdr3a/zd4PPVrAniO20riC9cmrhkyY7ll?= =?us-ascii?Q?Tm7hh6kSkoykxoQ0wDUhNWAlMrV/sL0cywVF6cbBuzMLkdkQjyYuZTl7s9W8?= =?us-ascii?Q?LWXCMQzNE5VetB+Vk47FPk733u5Pg76LtEQenMK6Q4LyrwDVRBvVFlVXlKQN?= =?us-ascii?Q?nFkEA8xJ3fAqvO8KPhkzRgYd1tcnmGIsd0q03MfDpsLAQkHIm6bdQlNdiWXy?= =?us-ascii?Q?sx6ivA5QYpqu1JOOgcNgkhBcJVIKtrRC4mFHofRd3B7d2rxUVw4p9h92IIJd?= =?us-ascii?Q?TOCZngkbeDa9zGO60WsvDgimcQFVKwg+AFp5NpISXteEYyWEyHh77OxgFeVj?= =?us-ascii?Q?0xTPE6YP5wC4mhigegPpaaMEEPCVAhmsPts1N2bvtuMZ/GIw9PUqTuUuOEYE?= =?us-ascii?Q?bB4TZ6KKrxrIf0tS84PleoyRtwn2l5zqemj698BNluaEI2oYvojB3upisRSI?= =?us-ascii?Q?vr9F6mQmFrRihojw0xPFxnckHa3AFoUaCVQKOSLfBhtMyVb1jYQRfJhaJyAv?= =?us-ascii?Q?wsVkMnlj0eLwrJivnh0HPaMLjEdQhcuugMUHqhPJsc8pKtNQcViXddKET0Bj?= =?us-ascii?Q?wT75dAMOytFeeU=3D?= X-Microsoft-Antispam-Message-Info: nOuMoR9hqAdKPUM87Ajr+z2MDVpeUhLlDBBnMXbbntZvNU+rc9UNUkoo8kWEhnd633DNhSCZo/Y3lkpw7FoqSBsJDTc1GUJR0aovehKSrxwmdq3w6TNdpfKxzSM2Q1cbLEM49aWYmhl2kyUg8cFQP4CQF1ixcyoxr8RhGghbm8ts8Sn++FUy5b4DyXf6Gk4Y X-Microsoft-Exchange-Diagnostics: 1; AM0PR05MB4179; 6:1JDnpbUO/skzk/YwcosxowciZywZsHSbw3yTctgFhbiOJekvtb6Q84caC0Ku3KubfcRnDw095LQcf3D5gAri64UUPtlWPqi4M2H0oTIVF1h0ZrZmJii4iyPVgE0c7WAxSQ2TroUopSk1JhD+6NKKdRnfBw5lLGN4sScPcyNXsilq4rkrnuY2vvxcDwnSO2v+KbF7P87CmH9yoOsOgiGcNWXWIXmZm0OoNd0Ygv9XOmYspdtjtD0AbEfNgXfVCcXiPHIxnNgdpcP/S7vvJY/Nv2fkzNwlklYTZ8VAQKmMoJ7Jhj8patK+04lPgOkS+b8e2yii4tg6bFKCv0KLM5EblCbQz6zSdOV8i2Cuc6OrQo+363T8Bqux4xt1sXngqVizQCbnEX4eaUaLh0KZSDW349gwX5yr+TmrxWcs/1T6PQGJAAmX/+FFjGe5DtevMRyyq7AQiz7HjCLrpcX10alxTA==; 5:LkvQGG7E33zACxnkZ4oRVAfb7udyX8rOjR6s/ovBforzvx7bf68VJwJJ8WObmmvzVjWfWPiO7rW28XSPcuzBlEVFxNxQe1Z59HaxyNrHC3BgMx+nGLbwNLcnPI3lR2JNhqRZrbWg/C6FqMWUfwLRRQijGIIBSV6bttyCrcB1Vco=; 24:/uzcdSUTAQad9ok0PtewBD/OXfRdUzbOj1A9o594Iof/kskZJU5m7rjqJ1tbcAdCDCl5cT86vTUrrZ/WicIDnyA7duGTEN5N96PJIxsaiuY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM0PR05MB4179; 7:/iT3GesupIGvrvoPzyR6J2mBKlG/Pcuon6Blr2UNvGlsq0gdtIejrxsX8rW3wuiPJcdcfTyJQAsN0tsL6UfFYmAuSNBKXOryBABAct/iu2rkgl18kERRUiCHQgO5tcmEBAlYIvMPqgiMYw7VNSVRDfQHYCToEb+pWPnrkEzTSDHupTC6euvk/T0X2dV+djcXzYp0XGuAkdQKBkfKI2X8/xi70pJ3YcNcrcR57bExnhqm8MgYnSPvWFQeuwhCR65c X-MS-Office365-Filtering-Correlation-Id: b529f478-c52a-4801-a446-08d5bfeae149 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2018 13:49:46.3089 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b529f478-c52a-4801-a446-08d5bfeae149 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4179 X-BeenThere: linux-mlxsw@lists.ozlabs.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: mlxsw driver development <linux-mlxsw.lists.ozlabs.org> List-Unsubscribe: <https://lists.ozlabs.org/options/linux-mlxsw>, <mailto:linux-mlxsw-request@lists.ozlabs.org?subject=unsubscribe> List-Archive: <http://lists.ozlabs.org/pipermail/linux-mlxsw/> List-Post: <mailto:linux-mlxsw@lists.ozlabs.org> List-Help: <mailto:linux-mlxsw-request@lists.ozlabs.org?subject=help> List-Subscribe: <https://lists.ozlabs.org/listinfo/linux-mlxsw>, <mailto:linux-mlxsw-request@lists.ozlabs.org?subject=subscribe> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-mlxsw-bounces+patchwork-linux-mlxsw=patchwork.kernel.org@lists.ozlabs.org X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c index ca38a30..adc6ab2 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c @@ -4433,6 +4433,11 @@ static int mlxsw_sp_netdevice_port_upper_event(struct net_device *lower_dev, NL_SET_ERR_MSG_MOD(extack, "Can not put a VLAN on an OVS port"); return -EINVAL; } + if (is_vlan_dev(upper_dev) && + vlan_dev_vlan_id(upper_dev) == 1) { + NL_SET_ERR_MSG_MOD(extack, "Creating a VLAN device with VID 1 is unsupported: VLAN 1 carries untagged traffic"); + return -EINVAL; + } break; case NETDEV_CHANGEUPPER: upper_dev = info->upper_dev;
VLAN 1 is internally used for untagged traffic. Prevent creation of explicit netdevice for that VLAN, because that currently isn't supported and leads to the NULL pointer dereference cited below. Fix by preventing creation of VLAN devices with VID of 1 over mlxsw devices or LAG devices that involve mlxsw devices. [ 327.184544] UBSAN: Undefined behaviour in drivers/net/ethernet/mellanox/mlxsw/spectrum_fid.c:200:12 [ 327.193667] member access within null pointer of type 'const struct mlxsw_sp_fid' [ 327.201226] CPU: 0 PID: 8983 Comm: ip Not tainted 4.17.0-rc4-petrm_net_ip6gre_headroom-custom-140 #11 [ 327.210496] Hardware name: Mellanox Technologies Ltd. "MSN2410-CB2F"/"SA000874", BIOS 4.6.5 03/08/2016 [ 327.219872] Call Trace: [ 327.222384] dump_stack (lib/dump_stackc:115) [ 327.225848] ? show_regs_print_info (lib/dump_stackc:89) [ 327.230092] ? ubsan_prologue (lib/ubsanc:150) [ 327.234007] ubsan_epilogue (lib/ubsanc:160) [ 327.237638] ubsan_type_mismatch_common (lib/ubsanc:276 lib/ubsanc:318) [ 327.242582] ? ucs2_as_utf8 (lib/ubsanc:315) [ 327.246493] ? debug_check_no_locks_freed (kernel/locking/lockdepc:3290) [ 327.251599] ? addrconf_ifdown (net/ipv6/addrconfc:3762) [ 327.255769] __ubsan_handle_type_mismatch (lib/ubsanc:327) [ 327.260710] ? ubsan_epilogue (lib/ubsanc:327) [ 327.264716] mlxsw_sp_fid_type (drivers/net/ethernet/mellanox/mlxsw/spectrum_fidc:200) mlxsw_spectrum [ 327.270255] mlxsw_sp_port_vlan_router_leave (drivers/net/ethernet/mellanox/mlxsw/spectrum_routerc:6295) mlxsw_spectrum [ 327.277019] mlxsw_sp_inetaddr_port_vlan_event (drivers/net/ethernet/mellanox/mlxsw/spectrum_routerc:6329) mlxsw_spectrum [ 327.284058] ? mlxsw_sp_port_vlan_router_leave (drivers/net/ethernet/mellanox/mlxsw/spectrum_routerc:6312) mlxsw_spectrum [ 327.290984] ? mlxsw_sp_lower_get (drivers/net/ethernet/mellanox/mlxsw/spectrumc:4027 (discriminator 1)) mlxsw_spectrum [ 327.296739] ? mlxsw_core_res_get (drivers/net/ethernet/mellanox/mlxsw/resourcesh:127 drivers/net/ethernet/mellanox/mlxsw/corec:1684) mlxsw_core [ 327.302180] ? mlxsw_sp_port_dev_check (drivers/net/ethernet/mellanox/mlxsw/spectrumc:3993) mlxsw_spectrum [ 327.308430] ? __mlxsw_sp_inetaddr_event (/include/linux/netdeviceh:4303 drivers/net/ethernet/mellanox/mlxsw/spectrum_routerc:6337 drivers/net/ethernet/mellanox/mlxsw/spectrum_routerc:6431) mlxsw_spectrum [ 327.315031] mlxsw_sp_netdevice_vrf_event (drivers/net/ethernet/mellanox/mlxsw/spectrum_routerc:6658 drivers/net/ethernet/mellanox/mlxsw/spectrum_routerc:6689) mlxsw_spectrum [ 327.321626] mlxsw_sp_netdevice_event (drivers/net/ethernet/mellanox/mlxsw/spectrumc:4659) mlxsw_spectrum [ 327.327923] ? mlxsw_sp_netdevice_port_event (drivers/net/ethernet/mellanox/mlxsw/spectrumh:285 drivers/net/ethernet/mellanox/mlxsw/spectrumc:4222 drivers/net/ethernet/mellanox/mlxsw/spectrumc:4456 drivers/net/ethernet/mellanox/mlxsw/spectrumc:4504) mlxsw_spectrum [ 327.335024] ? mlxsw_sp_netdevice_port_event (drivers/net/ethernet/mellanox/mlxsw/spectrumh:285 drivers/net/ethernet/mellanox/mlxsw/spectrumc:4222 drivers/net/ethernet/mellanox/mlxsw/spectrumc:4456 drivers/net/ethernet/mellanox/mlxsw/spectrumc:4504) mlxsw_spectrum [ 327.342125] ? mlxsw_sp_netdevice_port_event (drivers/net/ethernet/mellanox/mlxsw/spectrumh:285 drivers/net/ethernet/mellanox/mlxsw/spectrumc:4222 drivers/net/ethernet/mellanox/mlxsw/spectrumc:4456 drivers/net/ethernet/mellanox/mlxsw/spectrumc:4504) mlxsw_spectrum [ 327.349231] ? mlxsw_sp_netdevice_port_event (drivers/net/ethernet/mellanox/mlxsw/spectrumh:285 drivers/net/ethernet/mellanox/mlxsw/spectrumc:4222 drivers/net/ethernet/mellanox/mlxsw/spectrumc:4456 drivers/net/ethernet/mellanox/mlxsw/spectrumc:4504) mlxsw_spectrum [ 327.356259] ? __module_text_address (kernel/modulec:4349) [ 327.360818] ? mlxsw_sp_netdevice_port_event (drivers/net/ethernet/mellanox/mlxsw/spectrumh:285 drivers/net/ethernet/mellanox/mlxsw/spectrumc:4222 drivers/net/ethernet/mellanox/mlxsw/spectrumc:4456 drivers/net/ethernet/mellanox/mlxsw/spectrumc:4504) mlxsw_spectrum [ 327.367863] notifier_call_chain (kernel/notifierc:95) [ 327.372128] __netdev_upper_dev_link (/include/linux/notifierh:182 net/core/devc:6471) [ 327.376816] ? netdev_upper_dev_unlink (net/core/devc:6426) [ 327.381671] ? debug_check_no_locks_freed (kernel/locking/lockdepc:3290) [ 327.386800] ? deref_stack_reg (arch/x86/kernel/unwind_orcc:320) [ 327.390793] ? vrf_add_slave (drivers/net/vrfc:784 drivers/net/vrfc:808) vrf [ 327.395208] ? __dev_get_by_index (net/core/devc:817) [ 327.399450] vrf_add_slave (drivers/net/vrfc:784 drivers/net/vrfc:808) vrf [ 327.403703] do_setlink (net/core/rtnetlinkc:2369) [... etc ...] Fixes: 9589a7b5d7d9 ("mlxsw: spectrum: Handle VLAN devices linking / unlinking") Suggested-by: Ido Schimmel <idosch@mellanox.com> Signed-off-by: Petr Machata <petrm@mellanox.com> --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 5 +++++ 1 file changed, 5 insertions(+)